Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part #10: Final UI All topics text #315

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Fix part #10: Final UI All topics text #315

merged 3 commits into from
Nov 11, 2019

Conversation

veena14cs
Copy link
Contributor

nikitamarysolomanpvt
nikitamarysolomanpvt reviewed Nov 7, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

app/src/main/res/layout/all_topics.xml Outdated Show resolved Hide resolved
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Nov 7, 2019
rt4914
rt4914 suggested changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

app/src/main/res/layout/all_topics.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/all_topics.xml Show resolved Hide resolved
app/src/main/res/layout/all_topics.xml Show resolved Hide resolved
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 8, 2019
rt4914
rt4914 approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rt4914 rt4914 removed their assignment Nov 8, 2019
nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 mentioned this pull request Nov 11, 2019
Merged
@seanlip
Copy link
Member

seanlip commented Nov 11, 2019

Hi @veena14cs -- what would you like me to look at here? If the UI, perhaps showing a screenshot in context would be helpful -- I can't tell much from just looking at the text.

(Also, for UI reviews, it's fine to just loop in @mschanteltc instead rather than me.)

@seanlip seanlip removed their request for review November 11, 2019 07:05
@seanlip seanlip removed their assignment Nov 11, 2019
@veena14cs
Copy link
Contributor Author

Hi @veena14cs -- what would you like me to look at here? If the UI, perhaps showing a screenshot in context would be helpful -- I can't tell much from just looking at the text.

(Also, for UI reviews, it's fine to just loop in @mschanteltc instead rather than me.)

Ok got it :) thanks.

@veena14cs veena14cs merged commit b0edee8 into develop Nov 11, 2019
@veena14cs veena14cs deleted the hi-fi-all-topics branch November 11, 2019 09:48
@mschanteltc
Copy link

Hi Veena! As mentioned by Sean, is there something specific that needs checking?

@rt4914 rt4914 mentioned this pull request Jun 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

@rt4914 rt4914 rt4914 approved these changes

@mschanteltc mschanteltc Awaiting requested review from mschanteltc

@BenHenning BenHenning Awaiting requested review from BenHenning

Assignees

@BenHenning BenHenning

@mschanteltc mschanteltc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@veena14cs @seanlip @mschanteltc @rt4914 @nikitamarysolomanpvt @BenHenning