Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part #10: HiFi topic list on home screen #319

Merged
merged 15 commits into from
Nov 12, 2019
Merged

Fix part #10: HiFi topic list on home screen #319

merged 15 commits into from
Nov 12, 2019

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Nov 8, 2019 •
edited
Loading

Explaination

This PR corresponds to Topic Summary list and Topic Summary list items.

Mock

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/d47aa8de-a7a8-4d25-b011-5baefc7b7098/HP-Home-Page-/

Screenshots

Screenshot_20191112-105355

GIF-191112_105525

Accessibility Scanner Test

GIF-191108_174653

@veena14cs
Copy link
Contributor Author

@mschanteltc Please take a look in the Gif provided in this PR. For topic name and number of lessons we need to give contrast colors.

nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rt4914
rt4914 suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes

app/src/main/res/layout/home_fragment.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_summary_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_summary_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_summary_view.xml Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Nov 11, 2019
@rt4914
Copy link
Contributor

rt4914 commented Nov 11, 2019

@veena14cs forgot to mention thi earlier, all these cards have an elevation too, please add that to each card.

@veena14cs
Copy link
Contributor Author

@veena14cs forgot to mention thi earlier, all these cards have an elevation too, please add that to each card.

Added elevation. PTAL.

@veena14cs veena14cs assigned rt4914 and unassigned rt4914 Nov 12, 2019
@veena14cs veena14cs removed their assignment Nov 12, 2019
rt4914
rt4914 approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, suggested some nit changes.

app/src/main/res/drawable/bottom_rounded_rect_white_background.xml Show resolved Hide resolved
app/src/main/res/layout/welcome.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/welcome.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_summary_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_summary_view.xml Outdated Show resolved Hide resolved
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Nov 12, 2019
@veena14cs veena14cs changed the title Fix part #10: HiFi Topic summary list items Fix part #10: HiFi topic list on home screen Nov 12, 2019
@veena14cs veena14cs merged commit 1da1a22 into develop Nov 12, 2019
@veena14cs veena14cs deleted the hifi-topicsummarylist branch November 12, 2019 12:19
@rt4914 rt4914 mentioned this pull request Jun 24, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@mschanteltc mschanteltc Awaiting requested review from mschanteltc

@nikitamarysolomanpvt nikitamarysolomanpvt Awaiting requested review from nikitamarysolomanpvt

Assignees

@veena14cs veena14cs

@mschanteltc mschanteltc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veena14cs @rt4914 @mschanteltc @nikitamarysolomanpvt