Fix part of #10: Hifi Home part 1 [Copy of #509] #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR has been repeated as the earlier branch was based off from
temp-integration-pt-3
, which we were not able to merge in develop.This PR mainly works around margin/padding between varius items. The main focus in this PR was on custom SnapHelper for carousel.
Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/cb72aed9-af32-4ab6-9a80-394d9b30f6a3/HP-Home-Page-1
If you see the carousel in mock, when we are on second item, the left and right margins for the item are not equal, meaning the item tends to be more towards left side.
Screenshots:
First Item
Second Item
##Third Item
Checklist