Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #10: Hifi Home part 1 [Copy of #509] #538

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Dec 10, 2019

Explanation

This PR has been repeated as the earlier branch was based off from temp-integration-pt-3, which we were not able to merge in develop.

This PR mainly works around margin/padding between varius items. The main focus in this PR was on custom SnapHelper for carousel.

Mock: https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/cb72aed9-af32-4ab6-9a80-394d9b30f6a3/HP-Home-Page-1

If you see the carousel in mock, when we are on second item, the left and right margins for the item are not equal, meaning the item tends to be more towards left side.

Screenshots:

First Item

Screenshot_1575399336

Second Item

Screenshot_1575399339
##Third Item
Screenshot_1575399342

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Fix part of #10: Hifi Home part 1 Fix part of #10: Hifi Home part 1 [Copy of #509] Dec 10, 2019
@rt4914 rt4914 mentioned this pull request Dec 10, 2019
8 tasks
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914
Copy link
Contributor Author

rt4914 commented Dec 10, 2019

@nikitamarysolomanpvt Thanks

@rt4914 rt4914 merged commit 2bb639d into develop Dec 10, 2019
@rt4914 rt4914 deleted the hifi-home-part-1-repeat branch December 10, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants