Fix part of #117 and #118: Introduce sample lesson thumbnails and thumbnail data structure #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for thumbnails that can be used for lessons.
BenHenning
requested review from
rt4914,
veena14cs and
nikitamarysolomanpvt
This was referenced Sep 22, 2019
|
Thanks for the review! |
BenHenning
added a commit
that referenced
this pull request
Sep 25, 2019
…176) * Introduce initially viable TopicListController interface with tests, and no real implementation. This commit includes thumbnail structures that should be split into its own branch/PR since other controllers will depend on it. * Introduce 6 sample thumbnail graphics locally and a proto data structure for thumbnails that can be used for lessons. * Update topic list controller to use new-and-improved thumbnail options. * Fix post-merge breakages. * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is introducing a thumbnail data structure for lessons that's directly relevant to topics and stories (per #117 and #118). This also introduces 6 sample SVG thumbnails provided by Chantel.
For the prototype, it seems preferable that we use locally rendered SVGs converted to Android vector XML rather than needing to ensure SVGs are properly rendered in-app. For the later MVP work we will want to add support for dynamic SVGs that can be downloaded from the Oppia server.
Thumbnails also include a tile color per the mocks (for example on the home page). The graphics themselves are transparent in background to facilitate this coloring. It's not yet clear how we will color the darker parts of the tiles, or how color association will happen for lessons. The prototype may need to fake this for now, but long-term we will need to solve this.
See sample graphics (these were initial exports by Chantel--they may need to be cleaned up as we polish the prototype UI per #10, #141, and others): svg thumbnails.zip.