Fix #117: Introduce topic list controller interface [Blocked: #175] #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no real implementation. This commit includes thumbnail structures that should be split into its own branch/PR since other controllers will depend on it.
for thumbnails that can be used for lessons.
… introduce-topic-list-controller-interface Conflicts: model/src/main/proto/thumbnail.proto
BenHenning
requested review from
rt4914,
veena14cs,
jamesxu0 and
nikitamarysolomanpvt
rt4914
approved these changes
Sep 23, 2019
domain/src/main/java/org/oppia/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
|
LGTM |
Conflicts: model/src/main/proto/topic.proto
BenHenning
changed the base branch from
introduce-initial-lesson-thumbnails-and-structure
to
develop
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new interface provides the necessary data to display the list of topics on the home page, including both an in-progress promoted story and a recommended story. It also provides a second
LiveDatafor the continue playing activity which shows up if there is more than 1 ongoing lesson. The sample structures provided here are meant to have some consistency with #174.This is blocked on #175 to be mergerd first, hence the base branch.