Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce topic list management system [DO NOT MERGE] #106

Conversation

BenHenning
Copy link
Member

Initial commit of the topic list management system. This includes a bit of test code, incomplete documentation, and no tests. However, it does introduce a new way to handle recycler view binding, and demonstrates end-to-end integration with Oppia's backend.

This PR will actually be split up into several to demonstrate how we should approach end-to-end projects like this in pieces.

…it of

test code, incomplete documentation, and no tests. However, it does
introduce a new way to handle recycler view binding, and demonstrates
end-to-end integration with Oppia's backend.

This PR will actually be split up into several to demonstrate how we
should approach end-to-end projects like this in pieces.
@BenHenning
Copy link
Member Author

/cc @veena14cs and @nikitamarysolomanpvt since this may affect how the recycler view is being set up for content card list. I'd like to extract the adapter out of this and move it to its own PR to get that in earlier.

/cc @vinitamurthi for how this hooks up the backend controller to a custom data provider with the proto-based cache in the middle for caching. I started off trying to create a generic solution, but decided that we don't need it yet since there are few data stores we actually need (see #103 for a more exhaustive braindump).

@veena14cs
Copy link
Contributor

veena14cs commented Sep 16, 2019 via email

@BenHenning
Copy link
Member Author

@veena14cs I'll answer your question in #172.

@rt4914
Copy link
Contributor

rt4914 commented Jan 30, 2020

@BenHenning Is this PR still relevant?

@oppiabot
Copy link

oppiabot bot commented Jun 15, 2020

Hi @BenHenning. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@BenHenning
Copy link
Member Author

I don't think so--it seems this was split up and finished in multiple pieces (including #176).

@BenHenning BenHenning closed this Jun 23, 2020
@BenHenning BenHenning deleted the introduce-topic-list-management-system-fully-integrated-demo branch June 23, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants