Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final UI: Topic overview tab fragment [Blocked: #15, #136] #141

Closed
2 of 5 tasks
BenHenning opened this issue Sep 19, 2019 · 4 comments · Fixed by #1395
Closed
2 of 5 tasks

Final UI: Topic overview tab fragment [Blocked: #15, #136] #141

BenHenning opened this issue Sep 19, 2019 · 4 comments · Fixed by #1395
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 19, 2019 •
edited by veena14cs
Loading

This is tracking implementing the high fidelity UI for the topic overview tab.

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-

Task List

  • Topic thumbnail (Image) with gradient over image (without topic-name) (Assigned to @veena14cs )

Screenshot 2019-10-31 at 6 17 29 PM

  • Topic content including topic-name, story-count, topic description

Screenshot 2019-10-31 at 6 17 37 PM

  • See More text and Download Status (Assigned to @veena14cs )

Screenshot 2019-11-07 at 3 30 29 PM

Screenshot 2019-11-07 at 3 29 24 PM
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 19, 2019
@BenHenning
Copy link
Member Author

This is blocked on #136 for structure and #15 for full domain functionality.

@BenHenning BenHenning mentioned this issue Sep 22, 2019
Merged
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Oct 20, 2019
@rt4914 rt4914 assigned rt4914 and unassigned rt4914 Oct 29, 2019
@veena14cs
Copy link
Contributor

@rt4914 @BenHenning @nikitamarysolomanpvt I will work on 1st task Topic thumbnail (Image) with gradient over image (without topic-name)

@veena14cs
Copy link
Contributor

veena14cs commented Nov 6, 2019 •
edited
Loading

@rt4914 @BenHenning @nikitamarysolomanpvt I will be working on 3rd task See More text and story downloaded information.

veena14cs added a commit that referenced this issue Nov 12, 2019
@veena14cs
Fix part #141: Final UI topic overview tab see more (#314)
50ebaab 
* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* added offline icon

* update changes

* updated text color
veena14cs added a commit that referenced this issue Nov 14, 2019
@veena14cs
Fix part #141 : Final UI for topic thumbnail (Image) with gradient ov…
c1d1798 
…er image (without topic-name). (#291)

* added gradient

* added gradient color

* Update AndroidManifest.xml

* Update topic_overview_fragment.xml

* changed color

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* replaced thumbnail.

* Update topic_overview_fragment.xml

* Update thumbnail_gradient.xml

* added rectangle drawable

* Update rectangle_background.xml

* Changed drawable image.
@veena14cs
Copy link
Contributor

@rt4914 I will take up all the tasks from this issue.

veena14cs added a commit that referenced this issue Nov 22, 2019
@veena14cs
Fix part #141: Hi-Fi Topic overview tab fragment (#342)
078afb1 
* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update topic_overview_fragment.xml

* Update ic_available_offline_primary_24dp.xml

* Update colors.xml

* Update ic_available_offline_primary_24dp.xml

* Update topic_overview_fragment.xml
@rt4914 rt4914 assigned PrarabdhGarg and unassigned PrarabdhGarg Feb 13, 2020
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. and removed Workstream: Highfi UI Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Jun 23, 2020
@rt4914 rt4914 mentioned this issue Jun 24, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Jun 30, 2020
@rt4914
Fix #141 & Fix #1392: Update topic description (#1395)
8b976b3 
* Update topic description

* Nit change

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #141 & Fix #1392: Update topic description oppia/oppia-android
4 participants
@rt4914 @BenHenning @veena14cs @PrarabdhGarg