Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI structure: Introduce topic list on home screen #134

Closed
2 tasks done
BenHenning opened this issue Sep 19, 2019 · 5 comments
Closed
2 tasks done

UI structure: Introduce topic list on home screen #134

BenHenning opened this issue Sep 19, 2019 · 5 comments
Assignees
@rt4914 @BenHenning
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.3 Release Block...

Comments

@BenHenning
Copy link
Member

BenHenning commented Sep 19, 2019 •
edited by rt4914
Loading

This is tracking introducing the activity/fragment/view structures to hook up #117 to prepare for #10.

Two things needs to done in this:
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Sep 19, 2019
@BenHenning BenHenning changed the title UI structure: Introduce topic list on home screen [Blocked: #9] UI structure: Introduce topic list on home screen [Blocked: #117] Sep 19, 2019
@BenHenning
Copy link
Member Author

This is blocked on #117.

@BenHenning BenHenning mentioned this issue Sep 19, 2019
Closed
10 tasks
@BenHenning BenHenning modified the milestones: Prototype -- UI (low fidelity), Proof of concept Sep 20, 2019
@BenHenning BenHenning self-assigned this Sep 20, 2019
@BenHenning BenHenning changed the title UI structure: Introduce topic list on home screen [Blocked: #117] UI structure: Introduce topic list on home screen Sep 30, 2019
@BenHenning BenHenning modified the milestones: Proof of concept, Prototype -- Important fast-follows Oct 20, 2019
@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. and removed Priority: Essential This work item must be completed for its milestone. labels Oct 20, 2019
@BenHenning BenHenning mentioned this issue Oct 22, 2019
Merged
6 tasks
@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Nov 3, 2019
@BenHenning BenHenning mentioned this issue Nov 4, 2019
Merged
6 tasks
rt4914 added a commit that referenced this issue Nov 5, 2019
@rt4914
Fix part of #134: Home fragment low fi with TopicList (#289)
8bfbbec 
* HomeFragment xml introduction

* Promoted Story ViewModel

* PromotedStoryViewModel

* Basic promoted story

* Promoted story data display

* Promoted card display

* GridLayoutManager

* Functional HomeFragment

* Click listeners

* Click listeners final

* Chapter name issue fixed

* Fully functional with click listeners

* Introduce ContinuePlayingActivity

* Click listener integration

* Test for ContinuePlayingActivity

* HomeTest cases

* Nit changes

* Nit suggested changes

* Code updated as per suggestions

* Added HomeItemViewModel

* Nit changes

* Orientation Change

* EOF

* Test fix
@rt4914 rt4914 closed this as completed in 4613ff8 Nov 6, 2019
@rt4914
Copy link
Contributor

rt4914 commented Nov 6, 2019

Reopening this because of design changes

@rt4914 rt4914 reopened this Nov 6, 2019
rt4914 added a commit that referenced this issue Nov 7, 2019
@rt4914
Fix part of #134: Home fragment text fix (#311)
a9d3e63 
* Home fragment text fix

* Nit change
@rt4914
Copy link
Contributor

rt4914 commented Nov 7, 2019

@BenHenning @seanlip
Currently on HomeFragment PromotedStory is a single tile and not a list, so should we close this issue and raise a new one of should be keep this issue open for now. Also, check issue description too.

@seanlip
Copy link
Member

seanlip commented Nov 7, 2019

I need to defer to @BenHenning on this one, in order to ensure consistency in the scheme for organizing issues on this repo.

@BenHenning
Copy link
Member Author

Agreed. I filed #389. This is complete per our original goals.

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

@BenHenning BenHenning

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.3 Release Blockers (Prototype MR3) ...
Development

No branches or pull requests
3 participants
@rt4914 @seanlip @BenHenning