【Optimize】unified image pull policy #805
Conversation
|
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -668,7 +668,7 @@ spec: | |||
| command: | |||
| - /usr/local/bin/yurt-app-manager | |||
| image: {{.image}} | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
yurt-app-manager is recommended to deploy on cloud nodes, so it's better to set imagePullPolicy as Always instead of IfNotPresent
There was a problem hiding this comment.
I know you means, but yurt-tunnel-server is also deploy on cloud nodes, it's set imagePullPolicy as IfNotPresent, I just think we need to unify, but that's just a suggestion
There was a problem hiding this comment.
@JameKeal ok. please git rebase the newest master branch to fix e2e test error.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * unified image pull policy
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix git safe dir error (#807) Signed-off-by: Congrool <[email protected]> * 【Optimize】unified image pull policy (#805) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * unified image pull policy * 【Optimize】optimize kubernetes util function (#808) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * optimize kubernetes util func * 【FIX】fix cloud node was heterogeneous (#806) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix bug: when cloud node was heterogeneous, this parameter will be error * cleanup: io/ioutil (#813) Signed-off-by: cndoit18 <[email protected]> * use constants instead the string (#814) * ingress: update edge ingress proposal to add enhancement (#816) * finish ut of sa token replacement (#787) * finish ut of sa token replacement add tenant sa token subsitute * add tenant sa token subsitute * add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822) * Remove convert and revert command (#826) Signed-off-by: lonelyCZ <[email protected]> * uniform processCreateErr func to deal the resource create Co-authored-by: Yifei Zhang <[email protected]> Co-authored-by: cndoit18 <[email protected]> Co-authored-by: pengbinbin1 <[email protected]> Co-authored-by: zzguang <[email protected]> Co-authored-by: MrGirl <[email protected]> Co-authored-by: rambohe <[email protected]> Co-authored-by: Zhe Cheng <[email protected]>
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * unified image pull policy
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * unified image pull policy
What type of PR is this?
What this PR does / why we need it:
unified image pull policy, It all becomes the same as
imagePullPolicy: IfNotPresentWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note