Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove convert and revert command from yurtctl #826

Merged
merged 1 commit into from
May 13, 2022
Merged

Remove convert and revert command from yurtctl #826

merged 1 commit into from
May 13, 2022

Conversation

lonelyCZ
Copy link
Member

Signed-off-by: lonelyCZ [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

Remove convert and revert command

Which issue(s) this PR fixes:

Fixes #736

Special notes for your reviewer:

lifted from #748

Does this PR introduce a user-facing change?

Remove convert and revert command from yurtctl

other Note

@openyurt-bot
Copy link
Collaborator

@lonelyCZ: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: lonelyCZ [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

Remove convert and revert command

Which issue(s) this PR fixes:

Fixes #736

Special notes for your reviewer:

lifted from #748

Does this PR introduce a user-facing change?

Remove convert and revert command from yurtctl

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label May 13, 2022
@openyurt-bot openyurt-bot requested review from DrmagicE and SataQiu May 13, 2022 02:43
@Congrool
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label May 13, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, lonelyCZ, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label May 13, 2022
@openyurt-bot openyurt-bot merged commit 4e2a6ad into openyurtio:master May 13, 2022
@rambohe-ch rambohe-ch mentioned this pull request May 13, 2022
Closed
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@lonelyCZ @JameKeal
Remove convert and revert command (openyurtio#826)
83c8d13 
Signed-off-by: lonelyCZ <[email protected]>
openyurt-bot pushed a commit that referenced this pull request May 16, 2022
@JameKeal @Congrool
@cndoit18 @pengbinbin1 @MrGirl @rambohe-ch @lonelyCZ
【ADD】Uniform use processCreateErr func to create resource (#828)
536db52 
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix git safe dir error (#807)

Signed-off-by: Congrool <[email protected]>

* 【Optimize】unified image pull policy (#805)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* unified image pull policy

* 【Optimize】optimize kubernetes util function (#808)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* optimize kubernetes util func

* 【FIX】fix cloud node was heterogeneous (#806)

* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix bug: when cloud node was heterogeneous, this parameter will be error

* cleanup: io/ioutil (#813)

Signed-off-by: cndoit18 <[email protected]>

* use constants instead the string (#814)

* ingress: update edge ingress proposal to add enhancement (#816)

* finish ut of sa token replacement (#787)

* finish ut of sa token replacement
add tenant sa token subsitute

* add tenant sa token subsitute

* add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822)

* Remove convert and revert command (#826)

Signed-off-by: lonelyCZ <[email protected]>

* uniform processCreateErr func to deal the resource create

Co-authored-by: Yifei Zhang <[email protected]>
Co-authored-by: cndoit18 <[email protected]>
Co-authored-by: pengbinbin1 <[email protected]>
Co-authored-by: zzguang <[email protected]>
Co-authored-by: MrGirl <[email protected]>
Co-authored-by: rambohe <[email protected]>
Co-authored-by: Zhe Cheng <[email protected]>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@lonelyCZ @JameKeal
Remove convert and revert command (openyurtio#826)
40a49ab 
Signed-off-by: lonelyCZ <[email protected]>
JameKeal pushed a commit to JameKeal/openyurt that referenced this pull request May 16, 2022
@lonelyCZ @JameKeal
Remove convert and revert command (openyurtio#826)
8c35093 
Signed-off-by: lonelyCZ <[email protected]>
@lonelyCZ lonelyCZ mentioned this pull request May 20, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@Congrool Congrool Congrool approved these changes

@DrmagicE DrmagicE Awaiting requested review from DrmagicE

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@Congrool Congrool

Labels
approved approved kind/feature kind/feature lgtm lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request]deprecate Yurtctl convert/revert command
4 participants
@lonelyCZ @openyurt-bot @Congrool @rambohe-ch