【FIX】fix cloud node was heterogeneous #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rambohe-ch
approved these changes
Apr 18, 2022
|
@JameKeal please |
|
OK，finished. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JameKeal
added a commit
to JameKeal/openyurt
that referenced
this pull request
May 16, 2022
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix bug: when cloud node was heterogeneous, this parameter will be error
openyurt-bot
pushed a commit
that referenced
this pull request
May 16, 2022
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix git safe dir error (#807) Signed-off-by: Congrool <[email protected]> * 【Optimize】unified image pull policy (#805) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * unified image pull policy * 【Optimize】optimize kubernetes util function (#808) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * optimize kubernetes util func * 【FIX】fix cloud node was heterogeneous (#806) * add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix bug: when cloud node was heterogeneous, this parameter will be error * cleanup: io/ioutil (#813) Signed-off-by: cndoit18 <[email protected]> * use constants instead the string (#814) * ingress: update edge ingress proposal to add enhancement (#816) * finish ut of sa token replacement (#787) * finish ut of sa token replacement add tenant sa token subsitute * add tenant sa token subsitute * add enable-node-pool parameter for yurthub in order to disable nodepools list/watch in filters when testing. (#822) * Remove convert and revert command (#826) Signed-off-by: lonelyCZ <[email protected]> * uniform processCreateErr func to deal the resource create Co-authored-by: Yifei Zhang <[email protected]> Co-authored-by: cndoit18 <[email protected]> Co-authored-by: pengbinbin1 <[email protected]> Co-authored-by: zzguang <[email protected]> Co-authored-by: MrGirl <[email protected]> Co-authored-by: rambohe <[email protected]> Co-authored-by: Zhe Cheng <[email protected]>
JameKeal
added a commit
to JameKeal/openyurt
that referenced
this pull request
May 16, 2022
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix bug: when cloud node was heterogeneous, this parameter will be error
JameKeal
added a commit
to JameKeal/openyurt
that referenced
this pull request
May 16, 2022
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert * Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert" This reverts commit ba28364. * fix bug: when cloud node was heterogeneous, this parameter will be error
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
when cloud node was heterogeneous, this parameter will be error
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note