Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【ADD】Uniform use processCreateErr func to create resource #828

Merged
merged 14 commits into from
May 16, 2022

Conversation

JameKeal
Copy link
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Uniform use processCreateErr func to create resource, so wu can create deployment or daemonset workload when it`s exist.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Uniform use processCreateErr func to create resource, so wu can create deployment or daemonset workload when it`s exist.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label May 13, 2022
@Congrool
Copy link
Member

LGTM. could you please rebase your commits before merging this pr?

Congrool and others added 11 commits May 16, 2022 09:28
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* unified image pull policy
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* optimize kubernetes util func
* add yurt-app-manager yurtappdaemon/yurtingress deploy and revert

* Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and revert"

This reverts commit ba28364.

* fix bug: when cloud node was heterogeneous, this parameter will be error
* finish ut of sa token replacement
add tenant sa token subsitute

* add tenant sa token subsitute
@openyurt-bot openyurt-bot added size/XXL and removed size/S size/S 10-29 labels May 16, 2022
@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XXL labels May 16, 2022
@JameKeal
Copy link
Member Author

LGTM. could you please rebase your commits before merging this pr?

Of course, It's done.

@openyurt-bot openyurt-bot added the approved approved label May 16, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 536db52 into openyurtio:master May 16, 2022
@JameKeal JameKeal deleted the 20220513-pr1 branch May 16, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants