Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Optimize】unified image pull policy #805

Merged
merged 4 commits into from
Apr 18, 2022
Merged

【Optimize】unified image pull policy #805

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba28364
add yurt-app-manager yurtappdaemon/yurtingress deploy and revert
JameKeal Apr 12, 2022
3ce2582
Revert "add yurt-app-manager yurtappdaemon/yurtingress deploy and rev…
JameKeal Apr 15, 2022
957d0b9
unified image pull policy
JameKeal Apr 15, 2022
5a20408
Merge branch 'openyurtio:master' into 20220415-pr
JameKeal Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/setup/yurthub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
containers:
- name: yurt-hub
image: openyurt/yurthub:latest
imagePullPolicy: Always
imagePullPolicy: IfNotPresent
volumeMounts:
- name: hub-dir
mountPath: /var/lib/yurthub
Expand Down
2 changes: 1 addition & 1 deletion config/yaml-template/yurthub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
containers:
- name: __project_prefix__-hub
image: __repo__/__project_prefix__hub:__tag__
imagePullPolicy: Always
imagePullPolicy: IfNotPresent
volumeMounts:
- name: hub-dir
mountPath: /var/lib/yurthub
Expand Down
2 changes: 1 addition & 1 deletion pkg/yurtctl/constants/yurt-app-manager-tmpl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ spec:
command:
- /usr/local/bin/yurt-app-manager
image: {{.image}}
imagePullPolicy: Always
imagePullPolicy: IfNotPresent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yurt-app-manager is recommended to deploy on cloud nodes, so it's better to set imagePullPolicy as Always instead of IfNotPresent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you means, but yurt-tunnel-server is also deploy on cloud nodes, it's set imagePullPolicy as IfNotPresent, I just think we need to unify, but that's just a suggestion

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JameKeal ok. please git rebase the newest master branch to fix e2e test error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK，finished.

name: manager
ports:
- containerPort: 9443
Expand Down