Add adamzhoul as reviewer of openYurt #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamzhoul welcome you to apply reviewer of OpenYurt. agree +1 |
|
agree +1 |
|
Welcome @adamzhoul +1 from me |
|
+1 |
|
@adamzhoul Congratulations to you as reviewer, and you can check the reviewer's responsibilities and privileges here: https://github.com/openyurtio/community/blob/main/community-membership.md#reviewer |
|
/lgtm |
rambohe-ch
approved these changes
Nov 5, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adamzhoul, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
MrGirl
pushed a commit
to MrGirl/openyurt
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Username
@adamzhoul
Organization you are requesting membership in
openyurtio
Sponsors
@rambohe-ch
Requirements
List of your contributions
PRs reviewed/authored:
add node-servant #516
use default staticPath #506
add create to yurt-tunnel-server ClusterRole #500
Add tunnel server address #494
add DeleteYurthubSetting to revert #492
rm duplicated code #490
read podManifestPath from kubeadm file #473
fix typo; covert->convert #463
Docs: add more nodes for --cloud-nodes #459
Issues :
[feature request] yurtctl revert use node-servant in dispatch job #547
[feature request] yurtctl convert use node-servant in dispatch job #546
[feature request] yurtctl join use node-servant to finish some job #545
[feature request] add disable-node-controller/enable-node-controller to module node-servant #544
[feature request] set job template imagePullPolicy to Always from IfNotPresent #505
[BUG] Yurt-controller-manager scheduled to edge node leads to yurthub csr approval failed #502
[feature request] Do we miss delete all resource for yurt-app-manager #499
[BUG] Do we miss
createfor ClusterRole yurt-tunnel-server ? #498[feature request] DeployYurthubSetting, not delete when revert #489
[Question] Why not check is-edge-worker==true #488
[BUG] redundant code #486
[feature request] idempotent when execute yurtctl convert or yurtctl revert #485
[Question] How should tunnel-server be deployed #462
[feature request] add --tunnelserver-addr for yurtctl convert comand #461
[feature request] Create STATIC_POD_PATH dir if not exists #460