Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo; covert->convert #463

Merged
merged 1 commit into from
Sep 10, 2021
Merged

fix typo; covert->convert #463

merged 1 commit into from
Sep 10, 2021

Conversation

adamzhoul
Copy link
Member

What type of PR is this?

fix typo

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@adamzhoul: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

fix typo

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 9, 2021
SataQiu
SataQiu reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adamzhoul
/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 10, 2021
@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 10, 2021
@openyurt-bot openyurt-bot merged commit 0cbc4ef into openyurtio:master Sep 10, 2021
@adamzhoul adamzhoul mentioned this pull request Nov 5, 2021
Merged
6 tasks
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@adamzhoul
fix typo; covert->convert (openyurtio#463)
d30c897 
Co-authored-by: zhoulei5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SataQiu SataQiu SataQiu left review comments

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

@yixingjia yixingjia Awaiting requested review from yixingjia

Assignees

@SataQiu SataQiu

Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamzhoul @openyurt-bot @rambohe-ch @SataQiu