Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add node-servant #516

Merged
merged 1 commit into from
Oct 29, 2021
Merged

add node-servant #516

merged 1 commit into from
Oct 29, 2021

Conversation

adamzhoul
Copy link
Member

What type of PR is this?

/kind feature

Which issue(s) this PR fixes:

Fixes #425

Special notes for your reviewer:

The whole refactor is a big task.
pr here is only for task 1, supporting basic ability.
after this is done, the rest tasks can process with synchronization.

code is still under going, with no test. But ok for discussion.

Tasks TODO:

  • add local node level convert/revert cmd、pkg to support basic ability
  • refactor yurtctl convert
  • refactor yurtctl revert
  • refactor yurtctl join
  • refactor yurtctl reset
  • yurtcluster operator
  • replace other place using yurtctl_servant_image

@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Oct 12, 2021
@adamzhoul adamzhoul marked this pull request as draft October 12, 2021 05:43
@adamzhoul adamzhoul force-pushed the node-servant branch 3 times, most recently from 28a1660 to 1741106 Compare October 12, 2021 08:03
@adamzhoul adamzhoul force-pushed the node-servant branch 6 times, most recently from f737df4 to bb91d4d Compare October 13, 2021 15:06
@adamzhoul adamzhoul force-pushed the node-servant branch 5 times, most recently from da3eec7 to f1fd5a9 Compare October 22, 2021 16:22
@adamzhoul adamzhoul force-pushed the node-servant branch 4 times, most recently from 2174edd to 1569c9e Compare October 29, 2021 02:23
rambohe-ch
rambohe-ch reviewed Oct 29, 2021
View reviewed changes
pkg/node-servant/components/yurthub.go Outdated

func getYurthubCacheDir() string {
// get default dir
return filepath.Join(disk.CacheBaseDir, "yurthub")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default dir is /etc/kubernetes/cache, not /etc/kubernetes/cache/yurthub

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@adamzhoul adamzhoul force-pushed the node-servant branch 2 times, most recently from 33ef597 to 5506b1c Compare October 29, 2021 06:18
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 29, 2021
@rambohe-ch
Copy link
Member

/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Oct 29, 2021
@openyurt-bot openyurt-bot merged commit 13e9011 into openyurtio:master Oct 29, 2021
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Oct 30, 2021
@adamzhoul @Congrool
add node-servant (openyurtio#516)
fa72f3a
This was referenced Nov 1, 2021
Closed
Closed
Closed
Closed
Merged
@adamzhoul adamzhoul mentioned this pull request Nov 25, 2021
Closed
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@adamzhoul
add node-servant (openyurtio#516)
9d28f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch left review comments

@Peeknut Peeknut Peeknut left review comments

@DrmagicE DrmagicE DrmagicE left review comments

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

@kadisi kadisi Awaiting requested review from kadisi

Assignees

@rambohe-ch rambohe-ch

Labels
approved approved lgtm lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[yurtctl] Refactor yurtctl: Separate the image used by the conversion job from yurtctl
5 participants
@adamzhoul @rambohe-ch @openyurt-bot @DrmagicE @Peeknut