Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] add disable-node-controller/enable-node-controller to module node-servant #544

Closed
adamzhoul opened this issue Nov 1, 2021 · 4 comments
Labels

Comments

@adamzhoul
Copy link
Member

adamzhoul commented Nov 1, 2021

now the node-servant module has supported convert/revert node.

to complete the convert/revert job.
disable-node-controller/enable-node-controller is required since it's only sed op to update static YAML on a specific node.

it's a job after #516
/help

@adamzhoul adamzhoul added the kind/feature kind/feature label Nov 1, 2021
@adamzhoul
Copy link
Member Author

since it's only sed
add to node-servant/job.go 、 node-servant/constant.go maybe enough.

@adamzhoul
Copy link
Member Author

/help

@openyurt-bot
Copy link
Collaborator

@adamzhoul:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Jan 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 30, 2022
@stale stale bot closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants