Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Do we miss delete all resource for yurt-app-manager #499

Closed
adamzhoul opened this issue Sep 26, 2021 · 1 comment
Closed
Labels
kind/feature kind/feature

Comments

@adamzhoul
Copy link
Member

see DeployYurtAppManager when yurtctl convert

func DeployYurtAppManager(

it does:

1. create CRD:                                  nodepool uniteddeployment
2. create Role:                                 yurt-app-leader-election-role
3. create ClusterRole:                          yurt-app-manager-role
4. create RoleBinding:                          yurt-app-leader-election-rolebinding
5. create ClusterRoleBinding:                   yurt-app-manager-rolebinding
6. create secret:                               yurt-app-webhook-certs
7. create service:                              yurt-app-webhook-service
8. create deployment:                           yurt-app-manager
9. create MutatingWebhookConfiguration:         yurt-app-mutating-webhook-configuration
10. create ValidatingWebhookConfiguration:      yurt-app-validating-webhook-configuration

but can't find any delete in yurtctl revert

besides:

// 3.1 remove the serviceaccount for yurt-controller-manager

why not put remove `yurt-controller-manager` resource in a function in apply_addons.go 
so deploy /delete can put together.

others
/kind feature

@adamzhoul adamzhoul added the kind/feature kind/feature label Sep 26, 2021
@rambohe-ch
Copy link
Member

@adamzhoul Thank you for raising issue.
In fact, @yanyhui has made a pull request for this feature: #393, and some errors and comments have been not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants