Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default staticPath #506

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Conversation

adamzhoul
Copy link
Member

What type of PR is this?

/kind feature

Which issue(s) this PR fixes:

Fixes #484

@openyurt-bot openyurt-bot added do-not-merge/work-in-progress do-not-merge/work-in-progress kind/feature kind/feature labels Sep 28, 2021
@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Sep 28, 2021
@openyurt-bot openyurt-bot added size/XL size/XL: 500-999 and removed size/M size/M: 30-99 labels Oct 9, 2021
@openyurt-bot openyurt-bot added size/M size/M: 30-99 and removed size/XL size/XL: 500-999 labels Oct 9, 2021
@adamzhoul adamzhoul force-pushed the staticpath branch 4 times, most recently from 96eb9cc to f2318b5 Compare October 9, 2021 01:49
@adamzhoul adamzhoul changed the title [WIP] use default staticPath use default staticPath Oct 9, 2021
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Oct 9, 2021
@openyurt-bot openyurt-bot added the approved approved label Oct 10, 2021
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamzhoul, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot setup openyurt with yurtctl convert --provider kind
3 participants