Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v21.7.0 proposal #51932

Merged
merged 209 commits into from
Mar 6, 2024
Merged

v21.7.0 proposal #51932

merged 209 commits into from
Mar 6, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Mar 1, 2024

2024-03-06, Version 21.7.0 (Current), @RafaelGSS prepared by @marco-ippolito

Text Styling

  • util.styleText(format, text): This function returns a formatted text considering the format passed.

A new API has been created to format text based on util.inspect.colors, enabling you to style text in different colors (such as red, blue, ...) and emphasis (italic, bold, ...).

const { styleText } = require('node:util');
const errorMessage = styleText('red', 'Error! Error!');
console.log(errorMessage);

Contributed by Rafael Gonzaga in #51850.

Loading and parsing environment variables

  • process.loadEnvFile(path):

    • Use this function to load the .env file. If no path is specified, it automatically loads the .env file in the current directory. Example: process.loadEnvFile().
    • Load a specific .env file by specifying its path. Example: process.loadEnvFile('./development.env').
  • util.parseEnv(content):

    • Use this function to parse an existing string containing environment variable assignments.
    • Example usage: require('node:util').parseEnv('HELLO=world').

Contributed by Yagiz Nizipli in #51476

Support for multi-line values for .env file

Node.js 21.7.0 will now support multi-line values in the .env file:

MULTI_LINE="HELLO
WORLD"

Contributed by Ilyas Shabi #51289

sea: support embedding assets

Users can now include assets by adding a key-path dictionary
to the configuration as the assets field. At build time, Node.js
would read the assets from the specified paths and bundle them into
the preparation blob. In the generated executable, users can retrieve
the assets using the sea.getAsset() and sea.getAssetAsBlob() API.

{
  "main": "/path/to/bundled/script.js",
  "output": "/path/to/write/the/generated/blob.blob",
  "assets": {
    "a.jpg": "/path/to/a.jpg",
    "b.txt": "/path/to/b.txt"
  }
}

The single-executable application can access the assets as follows:

const { getAsset } = require('node:sea');
// Returns a copy of the data in an ArrayBuffer
const image = getAsset('a.jpg');
// Returns a string decoded from the asset as UTF8.
const text = getAsset('b.txt', 'utf8');
// Returns a Blob containing the asset without copying.
const blob = getAssetAsBlob('a.jpg');

Contributed by Joyee Cheung in #50960

vm: support using the default loader to handle dynamic import()

This patch adds support for using vm.constants.USE_MAIN_CONTEXT_DEFAULT_LOADER as the
importModuleDynamically option in all vm APIs that take this option except vm.SourceTextModule. This allows users to have a shortcut to support dynamic import() in the compiled code without missing the compilation cache if they don't need customization of the loading process. We emit an experimental warning when the import() is actually handled by the default loader through this option instead of requiring --experimental-vm-modules.

const { Script, constants } = require('node:vm');
const { resolve } = require('node:path');
const { writeFileSync } = require('node:fs');

// Write test.js and test.txt to the directory where the current script
// being run is located.
writeFileSync(resolve(__dirname, 'test.mjs'),
              'export const filename = "./test.json";');
writeFileSync(resolve(__dirname, 'test.json'),
              '{"hello": "world"}');

// Compile a script that loads test.mjs and then test.json
// as if the script is placed in the same directory.
const script = new Script(
  `(async function() {
    const { filename } = await import('./test.mjs');
    return import(filename, { with: { type: 'json' } })
  })();`,
  {
    filename: resolve(__dirname, 'test-with-default.js'),
    importModuleDynamically: constants.USE_MAIN_CONTEXT_DEFAULT_LOADER,
  });

// { default: { hello: 'world' } }
script.runInThisContext().then(console.log);

Contributed by Joyee Cheung in #51244

crypto: implement crypto.hash()

This patch introduces a helper crypto.hash() that computes
a digest from the input at one shot. This can be 1.2-2x faster
than the object-based createHash() for smaller inputs (<= 5MB)
that are readily available (not streamed) and incur less memory
overhead since no intermediate objects will be created.

const crypto = require('node:crypto');

// Hashing a string and return the result as a hex-encoded string.
const string = 'Node.js';
// 10b3493287f831e81a438811a1ffba01f8cec4b7
console.log(crypto.hash('sha1', string));

Contributed by Joyee Cheung in #51044

Other Notable Changes

  • [8ae0eeb7f4] - (SEMVER-MINOR) build: build opt to set local location of headers (Michael Dawson) #51525
  • [496776cc78] - crypto: update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
  • [a8c9e6f7e9] - doc: add zcbenz to collaborators (Cheng Zhao) #51812
  • [adbf2d3837] - doc: add lemire to collaborators (Daniel Lemire) #51572
  • [4b1c6839f4] - (SEMVER-MINOR) http2: add h2 compat support for appendHeader (Tim Perry) #51412
  • [d8aa2bac0b] - (SEMVER-MINOR) http2: add server handshake utility (snek) #51172
  • [b9275d9039] - (SEMVER-MINOR) http2: receive customsettings (Marten Richter) #51323
  • [5a2d2daad5] - (SEMVER-MINOR) lib: move encodingsMap to internal/util (Joyee Cheung) #51044
  • [e8d9065262] - (SEMVER-MINOR) sea: support sea.getRawAsset() (Joyee Cheung) #50960
  • [47186fbad5] - (SEMVER-MINOR) src: print string content better in BlobDeserializer (Joyee Cheung) #50960
  • [119e045053] - (SEMVER-MINOR) src: do not coerce dotenv paths (Tobias Nießen) #51425
  • [9ab353af00] - (SEMVER-MINOR) stream: implement min option for ReadableStreamBYOBReader.read (Mattias Buelens) #50888
Commits
  • [4ddb9b33d5] - async_hooks,inspector: implement inspector api without async_wrap (Gabriel Bota) #51501
  • [7e06c11f55] - benchmark: update iterations of assert/deepequal-typedarrays.js (Lei Shi) #51419
  • [72be232006] - benchmark: update iterations of benchmark/assert/deepequal-map.js (Lei Shi) #51416
  • [92e7c310cb] - benchmark: rename startup.js to startup-core.js (Joyee Cheung) #51669
  • [c9ada533a2] - build: remove librt libs link for Android compatibility (BuShe Pie) #51632
  • [86ac787889] - build: do not rely on gn_helpers in GN build (Cheng Zhao) #51439
  • [9be6b7ccf0] - build: fix warning in cares under GN build (Cheng Zhao) #51687
  • [d1a8c2e989] - build: fix building js2c with GN (Cheng Zhao) #51818
  • [9840715dc0] - build: encode non-ASCII Latin1 characters as one byte in JS2C (Joyee Cheung) #51605
  • [8ae0eeb7f4] - (SEMVER-MINOR) build: build opt to set local location of headers (Michael Dawson) #51525
  • [1999719877] - build: use macOS m1 machines for testing (Yagiz Nizipli) #51620
  • [85f63f3d7d] - build: check before removing %config% link (liudonghua) #51437
  • [cc37959232] - build: increase parallel executions in github (Yagiz Nizipli) #51554
  • [2921d55121] - build: remove copyright header in node.gni (Cheng Zhao) #51535
  • [9da0926396] - build: update GN build files for ngtcp2 (Cheng Zhao) #51313
  • [59117317f3] - build,tools: make addons tests work with GN (Cheng Zhao) #50737
  • [78c226281c] - (SEMVER-MINOR) crypto: implement crypto.hash() (Joyee Cheung) #51044
  • [496776cc78] - crypto: update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
  • [17c554f1ca] - crypto: use EVP_MD_fetch and cache EVP_MD for hashes (Joyee Cheung) #51034
  • [014cc53541] - deps: upgrade npm to 10.5.0 (npm team) #51913
  • [4ebb944800] - deps: update undici to 6.6.2 (Michaël Zasso) #51667
  • [3b29dff0ed] - deps: update ngtcp2 to 1.3.0 (Node.js GitHub Bot) #51796
  • [28c0ffb363] - deps: update simdjson to 3.7.0 (Daniel Lemire) #51859
  • [58b1403693] - deps: update corepack to 0.25.2 (Node.js GitHub Bot) #51810
  • [c7083720cc] - deps: update c-ares to 1.27.0 (Node.js GitHub Bot) #51846
  • [6d2699d40b] - deps: update timezone to 2024a (Michaël Zasso) #51723
  • [8d2222714d] - deps: update icu to 74.2 (Michaël Zasso) #51723
  • [c3dbd7cccd] - deps: update c-ares to 1.26.0 (Node.js GitHub Bot) #51582
  • [dfc3811056] - deps: update googletest to 6a59382 (Node.js GitHub Bot) #51580
  • [8235c2676e] - deps: update nghttp2 to 1.59.0 (Node.js GitHub Bot) #51581
  • [2ad665e24f] - deps: V8: cherry-pick efb1133eb894 (Joyee Cheung) #51551
  • [e5db8d416f] - deps: update corepack to 0.24.1 (Node.js GitHub Bot) #51459
  • [fe597de72e] - deps: update ada to 2.7.6 (Node.js GitHub Bot) #51542
  • [5aca6f54f9] - deps: update ada to 2.7.5 (Node.js GitHub Bot) #51542
  • [8f63f6ff57] - deps: update ngtcp2 to 1.2.0 (Node.js GitHub Bot) #51584
  • [a04aa36ce8] - deps: update googletest to 7c07a86 (Node.js GitHub Bot) #51458
  • [4b1d25b68d] - deps: update ngtcp2 to 1.1.0 (Node.js GitHub Bot) #51319
  • [682f4f67b0] - deps: update acorn-walk to 8.3.2 (Node.js GitHub Bot) #51457
  • [365a9dc2cb] - deps: update timezone to 2023d (Node.js GitHub Bot) #51461
  • [40e8b362a2] - deps: update base64 to 0.5.2 (Node.js GitHub Bot) #51455
  • [139a626264] - deps: compile c-ares with C11 support (Michaël Zasso) #51410
  • [1cc37c4355] - deps: upgrade npm to 10.3.0 (npm team) #51431
  • [942e10f5b5] - deps: update c-ares to 1.25.0 (Node.js GitHub Bot) #51385
  • [17cb4af5a9] - deps: update uvwasi to 0.0.20 and fixup tests (Michael Dawson) #51355
  • [76582e434c] - deps: add nghttp3/**/.deps to .gitignore (Luigi Pinca) #51400
  • [4a889e8ea3] - doc: add stability index to crypto.hash() (Joyee Cheung) #51978
  • [3fdaeba9e6] - doc: remove redundant backquote which breaks sentence (JounQin) #51904
  • [58747734a2] - doc: update node-api/node-addon-api team link to sharing project news (Ulises Gascón) #51877
  • [2cdfe35437] - doc: add website team to sharing project news (Ulises Gascón) #49002
  • [db30428f06] - doc: update guide link for Event Loop (Shrujal Shah) #51874
  • [a5a17a18e3] - doc: change ExperimentalWarnings to ExperimentalWarning (Ameet Kaustav) #51741
  • [32d92aca1f] - doc: add Paolo to TSC members (Michael Dawson) #51825
  • [2de1e85268] - doc: reserve 123 for Electron 30 (Keeley Hammond) #51803
  • [ad8cefcbf1] - doc: add mention to GPG_TTY (Rafael Gonzaga) #51806
  • [a8c9e6f7e9] - doc: add zcbenz to collaborators (Cheng Zhao) #51812
  • [4e0c79bea9] - doc: add entry to stewards (Rafael Gonzaga) #51760
  • [7fa30812ea] - doc: update technical priorities for 2023 (Jean Burellier) #47523
  • [af6b5b1722] - doc: mark isWebAssemblyCompiledModule eol (Marco Ippolito) #51442
  • [a62f69ecad] - doc: fix globals.md introduction (Antoine du Hamel) #51742
  • [519dc8aad6] - doc: updates for better json generating (Dmitry Semigradsky) #51592
  • [1b45ca4e38] - doc: document the GN build (Cheng Zhao) #51676
  • [37182c4c1f] - doc: fix uncaught exception example (Gabriel Schulhof) #51638
  • [c9be260b7d] - doc: clarify execution of after hook on test suite completion (Ognjen Jevremović) #51523
  • [8c0a257021] - doc: fix dns.lookup and dnsPromises.lookup description (Duncan Chiu) #51517
  • [177e13cb0d] - doc: note that path.normalize deviates from POSIX (Tobias Nießen) #51513
  • [adbf2d3837] - doc: add lemire to collaborators (Daniel Lemire) #51572
  • [fd2a3cef57] - doc: fix historical experimental fetch flag (Kenrick) #51506
  • [1d40a0067a] - doc: fix type of connectionAttempt parameter (Rafael Gonzaga) #51490
  • [d3b78051ce] - doc: remove reference to resolved child_process v8 issue (Ian Kerins) #51467
  • [2bf371886a] - doc: update typos (Aranđel Šarenac) #51475
  • [10f95283c6] - doc: add notes on inspector breakpoints (Chengzhong Wu) #51417
  • [4ea194ab33] - doc: add links in offboarding.md (Antoine du Hamel) #51440
  • [fc5629616b] - doc: fix spelling mistake (u9g) #51454
  • [70e88cf159] - doc: add check for security reverts (Michael Dawson) #51376
  • [74d4e382a7] - doc: fix some policy scope typos (Tim Kuijsten) #51234
  • [d7658ca6a2] - doc: improve subtests documentation (Marco Ippolito) #51379
  • [c18a813638] - doc: add missing word in child_process.md (Joseph Joy) #50370
  • [fabd5c4b21] - doc: fixup alignment of warning subsection (James M Snell) #51374
  • [80c750c8c1] - doc,crypto: further clarify RSA_PKCS1_PADDING support (Tobias Nießen) #51799
  • [b53919d988] - doc,crypto: add changelog and note about disabled RSA_PKCS1_PADDING (Filip Skokan) #51782
  • [08832e76d3] - esm: improve error when calling import.meta.resolve from data: URL (Antoine du Hamel) #49516
  • [78f818069a] - events: no stopPropagation call in cancelBubble (mert.altin) #50405
  • [f130a33438] - Revert "fs: remove workaround for esm package" (Jeremy Meng) #50907
  • [5a8af3d362] - fs: load rimraf lazily in fs/promises (Joyee Cheung) #51617
  • [15a7f2103b] - fs: remove race condition for recursive watch on Linux (Matteo Collina) #51406
  • [d8bb4b2c1e] - fs: update jsdoc for filehandle.createWriteStream and appendFile (Jungku Lee) #51494
  • [e8fffebdd3] - fs,test: add URL to string to fs.watch (Rafael Gonzaga) #51346
  • [ec17fd73cc] - http: fix close return value mismatch between doc and implementation (kylo5aby) #51797
  • [b8e7a87aa9] - http: split set-cookie when using setHeaders (Marco Ippolito) #51649
  • [682951af60] - http2: close idle connections when allowHTTP1 is true (xsbchen) #51569
  • [4b1c6839f4] - (SEMVER-MINOR) http2: add h2 compat support for appendHeader (Tim Perry) #51412
  • [d8aa2bac0b] - (SEMVER-MINOR) http2: add server handshake utility (snek) #51172
  • [b9275d9039] - (SEMVER-MINOR) http2: receive customsettings (Marten Richter) #51323
  • [58e2015a03] - inspector: add NodeRuntime.waitingForDebugger event (mary marchini) #51560
  • [af32d433ee] - lib: account for cwd access from snapshot serialization cb (Anna Henningsen) #51901
  • [1edbc7d353] - lib: fix http client socket path (theanarkh) #51900
  • [4dfc9e092e] - lib: only build the ESM facade for builtins when they are needed (Joyee Cheung) #51669
  • [5a2d2daad5] - (SEMVER-MINOR) lib: move encodingsMap to internal/util (Joyee Cheung) #51044
  • [eb1089ab17] - lib: do not access process.noDeprecation at build time (Joyee Cheung) #51447
  • [614ca327c8] - lib: add assertion for user ESM execution (Joyee Cheung) #51748
  • [77ae03f723] - lib: create global console properties at snapshot build time (Joyee Cheung) #51700
  • [7f698f064e] - lib: define FormData and fetch etc. in the built-in snapshot (Joyee Cheung) #51598
  • [4b583bfcc5] - lib: allow checking the test result from afterEach (Tim Stableford) #51485
  • [ec60639cc0] - lib: remove unnecessary refreshHrtimeBuffer() (Joyee Cheung) #51446
  • [8dc3f91eb4] - lib,src: extract sourceMappingURL from module (unbyte) #51690
  • [84c71fa895] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #51726
  • [e5c52a2a6b] - meta: bump codecov/codecov-action from 3.1.4 to 4.0.1 (dependabot[bot]) #51648
  • [16aa6e5341] - meta: bump actions/download-artifact from 4.1.0 to 4.1.1 (dependabot[bot]) #51644
  • [97825603ae] - meta: bump actions/upload-artifact from 4.0.0 to 4.3.0 (dependabot[bot]) #51643
  • [51f0d80876] - meta: bump step-security/harden-runner from 2.6.1 to 2.7.0 (dependabot[bot]) #51641
  • [97e3cb5844] - meta: bump actions/cache from 3.3.2 to 4.0.0 (dependabot[bot]) #51640
  • [dcf5f28d68] - meta: bump github/codeql-action from 3.22.12 to 3.23.2 (dependabot[bot]) #51639
  • [c4a28b2211] - meta: add .mailmap entry for lemire (Daniel Lemire) #51600
  • [dbf44744ba] - meta: mark security-wg codeowner for deps folder (Marco Ippolito) #51529
  • [16fea71d08] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #51468
  • [015c4dcacf] - meta: move RaisinTen to emeritus and remove from strategic initiatives (Darshan Sen) #51411
  • [e942dc1d0c] - meta: add .temp and .lock tags to ignore (Rafael Gonzaga) #51343
  • [595542e330] - meta: bump actions/setup-python from 4.7.1 to 5.0.0 (dependabot[bot]) #51335
  • [6c3ba73d03] - meta: bump actions/setup-node from 4.0.0 to 4.0.1 (dependabot[bot]) #51334
  • [e4f9f0a260] - meta: bump github/codeql-action from 2.22.8 to 3.22.12 (dependabot[bot]) #51333
  • [77598c3a8e] - meta: bump actions/stale from 8.0.0 to 9.0.0 (dependabot[bot]) #51332
  • [22a11c32c0] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #51329
  • [391aeb1996] - module: fix crash when built-in module export a default key (Antoine du Hamel) #51481
  • [615b0ae307] - module: fix --preserve-symlinks-main (per4uk) #51312
  • [c6cc3ed3b4] - net: fix connect crash when call destroy in lookup handler (theanarkh) #51826
  • [63e0ceb48f] - net: fix example IPv4 in dns docs (Aras Abbasi) #51377
  • [bc6f33d8d1] - node-api: make napi_get_buffer_info check if passed buffer is valid (Janrupf) #51571
  • [5b94ff44ec] - node-api: move NAPI_EXPERIMENTAL definition to gyp file (Gabriel Schulhof) #51254
  • [66c11f31c3] - node-api: optimize napi_set_property for perf (Mert Can Altın) #50282
  • [cb621863c6] - perf_hooks: performance milestone time origin timestamp improvement (IlyasShabi) #51713
  • [4d06d80675] - quic: various additional cleanups, fixes in Endpoint (James M Snell) #51310
  • [3e579ab2fd] - repl: fix NO_COLORS env var is ignored (Moshe Atlow) #51568
  • [7ceb6d6700] - sea: update stability index (Joyee Cheung) #51774
  • [e8d9065262] - (SEMVER-MINOR) sea: support sea.getRawAsset() (Joyee Cheung) #50960
  • [cea5295c16] - (SEMVER-MINOR) sea: support embedding assets (Joyee Cheung) #50960
  • [7543e774bd] - src: simplify direct queries of env vars in C++ land (Joyee Cheung) #51829
  • [8f10543c58] - src: stop the profiler and the inspector before snapshot serialization (Joyee Cheung) #51815
  • [ccc76bbfd7] - src: simplify embedder entry point execution (Joyee Cheung) #51557
  • [0c41210865] - src: compile code eagerly in snapshot builder (Joyee Cheung) #51672
  • [2a46dc7b86] - src: check empty before accessing string (Cheng Zhao) #51665
  • [47186fbad5] - (SEMVER-MINOR) src: print string content better in BlobDeserializer (Joyee Cheung) #50960
  • [6603d32ce3] - src: fix vm bug for configurable globalThis (F. Hinkelmann) #51602
  • [c7912c3d5a] - (SEMVER-MINOR) src: support multi-line values for .env file (IlyasShabi) #51289
  • [b8ae5c27c6] - (SEMVER-MINOR) src: add process.loadEnvFile and util.parseEnv (Yagiz Nizipli) #51476
  • [e3a63843f2] - src: terminate correctly double-quote in env variable (Marco Ippolito) #51510
  • [119e045053] - (SEMVER-MINOR) src: do not coerce dotenv paths (Tobias Nießen) #51425
  • [b271cc5b16] - src: refactor GetCreationContext calls (Jungku Lee) #51367
  • [36e42aa570] - src: do not read string out of bounds (Cheng Zhao) #51358
  • [8ea7d79082] - src: avoid shadowed string in fs_permission (Shelley Vohr) #51123
  • [5b06af7814] - stream: fix eventNames() to not return not defined events (IlyasShabi) #51331
  • [438b7fd049] - stream: fix cloned webstreams not being unref correctly (tsctx) #51526
  • [9ab353af00] - (SEMVER-MINOR) stream: implement min option for ReadableStreamBYOBReader.read (Mattias Buelens) #50888
  • [17ab5ae570] - test: fix unreliable assumption in js-native-api/test_cannot_run_js (Joyee Cheung) #51898
  • [e2c51385c7] - test: test surrogate pair filenames on windows (Mert Can Altın) #51800
  • [049e5f5e8c] - test: deflake test-http2-large-write-multiple-requests (Joyee Cheung) #51863
  • [2bf03ee678] - test: fix test-debugger-profile for coverage generation (Joyee Cheung) #51816
  • [d47a95f3b1] - test: fix test-bootstrap-modules for coverage generation (Joyee Cheung) #51816
  • [c0918f082f] - test: ensure delay in recursive fs watch tests (Joyee Cheung) #51842
  • [1f6551dda2] - test: fix test-child-process-fork-net (Joyee Cheung) #51841
  • [f845a16c58] - test: split wasi tests (Joyee Cheung) #51836
  • [275cea0fdb] - test: mark test-wasi as flaky on Windows on ARM (Joyee Cheung) #51834
  • [2fb620cd00] - test: remove test-fs-stat-bigint flaky designation (Luigi Pinca) #51735
  • [b046712e86] - test: skip test-http-correct-hostname on loong64 (Shi Pujin) #51663
  • [83f581d4c1] - test: increase platform timeout zlib-brotli-16gb (Rafael Gonzaga) #51792
  • [ea08350c83] - test: remove test-cli-node-options flaky designation (Luigi Pinca) #51716
  • [9d3a014f67] - test: remove test-domain-error-types flaky designation (Luigi Pinca) #51717
  • [d7563a5448] - test: fix internet/test-inspector-help-page (Richard Lau) #51693
  • [e9299255ca] - test: remove duplicate entry for flaky test (Luigi Pinca) #51654
  • [a8ac337250] - test: remove test-crypto-keygen flaky designation (Luigi Pinca) #51567
  • [c820166e4b] - test: remove test-fs-rmdir-recursive flaky designation (Luigi Pinca) #51566
  • [db88bf185f] - test: remove common.expectsError calls for asserts (Paulo Chaves) #51504
  • [fc0c1309b2] - test: mark test-http2-large-file as flaky (Michaël Zasso) #51549
  • [c88f0b6db9] - test: use checkIfCollectableByCounting in SourceTextModule leak test (Joyee Cheung) #51512
  • [d4d07f4a44] - test: remove test-file-write-stream4 flaky designation (Luigi Pinca) #51472
  • [7420a7d2f8] - test: add URL tests to fs-write (Rafael Gonzaga) #51352
  • [28c2bf3e42] - test: remove unneeded common.expectsError for asserts (Andrés Morelos) #51353
  • [9dfb36fbe5] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #51533
  • [e4d4bc6f9a] - test_runner: serialize 'expected' and 'actual' in isolation (Malthe Borch) #51851
  • [5f9491237c] - test_runner: add ref methods to mocked timers (Marco Ippolito) #51809
  • [af5875c6e8] - test_runner: check if timeout was cleared by own callback (Ben Richeson) #51673
  • [e0789fbc8a] - test_runner: do not invoke after hook when test is empty (Marco Ippolito) #51389
  • [27f8549903] - tools: fix installing node with shared mode (Cheng Zhao) #51910
  • [71a809bd43] - tools: update eslint to 8.57.0 (Node.js GitHub Bot) #51867
  • [20effe638a] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51795
  • [6c0a3b9c0d] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51795
  • [03f926ddca] - tools: fix missing [[fallthrough]] in js2c (Cheng Zhao) #51845
  • [b502be1d09] - tools: disable automated libuv updates (Rafael Gonzaga) #51775
  • [787fb32557] - tools: fix update-icu.sh (Michaël Zasso) #51723
  • [ba22c614c1] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51720
  • [751821fa21] - tools: update github_reporter to 1.6.0 (Node.js GitHub Bot) #51658
  • [5fe493d0e4] - tools: run build-windows workflow only on source changes (Antoine du Hamel) #51596
  • [e1b9655bdc] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51583
  • [d8e1058f18] - tools: fix loong64 build (Shi Pujin) #51401
  • [e0eeebc960] - tools: set normalizeTD text default to empty string (Marco Ippolito) #51543
  • [81fd7d1ca9] - tools: limit parallelism with ninja in V8 builds (Richard Lau) #51473
  • [e88a301e98] - tools: do not pass invalid flag to C compiler (Michaël Zasso) #51409
  • [129d3b3293] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51460
  • [f3845de204] - tools: update inspector_protocol to 83b1154 (Kohei Ueno) #51309
  • [58901d08fd] - tools: update github_reporter to 1.5.4 (Node.js GitHub Bot) #51395
  • [29492e2c88] - tools: fix version parsing in brotli update script (Richard Lau) #51373
  • [17593d95ba] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #51396
  • [35f33d3a31] - tools: remove openssl v1 update script (Marco Ippolito) #51378
  • [83b3aa838b] - tools: remove deprecated python api (Alex Yang) #49731
  • [adb2c36f0f] - typings: lib/internal/vm.js (Geoffrey Booth) #50112
  • [407341e25c] - url: don't update URL immediately on update to URLSearchParams (Matt Cowley) #51520
  • [88e08bbe80] - (SEMVER-MINOR) util: add styleText API to text formatting (Rafael Gonzaga) #51850
  • [ba444a949d] - vm: implement isContext() directly in JS land with private symbol (Joyee Cheung) #51685
  • [4c508269cd] - (SEMVER-MINOR) vm: support using the default loader to handle dynamic import() (Joyee Cheung) #51244

nodejs-github-bot and others added 30 commits February 15, 2024 12:00
PR-URL: #51329
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #51123
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 8.0.0 to 9.0.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@1160a22...28ca103)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #51332
Refs: actions/stale@28ca103
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.8 to 3.22.12.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@407ffaf...012739e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #51333
Refs: github/codeql-action@012739e
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@8f152de...b39b52d)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #51334
Refs: actions/setup-node@b39b52d
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@65d7f2d...0a5c615)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #51335
Refs: actions/setup-python@0a5c615
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #50888
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
PR-URL: #51343
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #51346
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #51313
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Subsection was accidentally aligned with the wrong event.

PR-URL: #51374
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
PR-URL: #50282
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
On OpenSSL 3, migrate from EVP_get_digestbyname() to EVP_MD_fetch()
to get the implementation and use a per-Environment cache for it.
The EVP_MDs are freed during Environment cleanup.

Drive-by: declare the smart pointer for EVP_MD_CTX as EVPMDCtxPointer
instead of EVPMDPointer to avoid confusion with EVP_MD pointers.

PR-URL: #51034
Refs: https://www.openssl.org/docs/man3.0/man7/crypto.html#Explicit-fetching
Refs: nodejs/performance#136
Reviewed-By: James M Snell <[email protected]>
PR-URL: #51358
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
PR-URL: #49731
Fixes: #49729
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #51377
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
PR-URL: #51378
Fixes: nodejs/security-wg#1182
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #50370
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
PR-URL: #51396
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #51379
Fixes: #51359
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Update `tools/dep_updaters/update-brotli.sh` to parse the current
version of brotli from the newer macros `BROTLI_VERSION_MAJOR`,
`BROTLI_VERSION_MINOR` and `BROTLI_VERSION_PATCH`.

PR-URL: #51373
Refs: #50804
Refs: nodejs/security-wg#1181
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #51367
Refs: #51287
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This commit gives node.js the ability to also receive custom settings,
in addition to sending, them which was implemented before.
The custom settings received are limited to setting ids,
that were specified before, when creating the session eithers through
the server or the client.

PR-URL: #51323
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #51353
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #51400
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #51389
Fixes: #51371
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
PR-URL: #51234
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51355
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
- Add step to check that any PRs with breaking changes
  have command line options to revert
- Add info on how to easily add command line option
  to revert a breaking change related to a CVE

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #51376
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5838/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5838/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 5, 2024

https://ci.nodejs.org/job/node-test-pull-request/57589/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5838/

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Mar 5, 2024

@nodejs/build
https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes=osx11/16047/

14:52:08 fatal error: error in backend: IO failure on output stream: No space left on device

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5838/
failure related to #51308

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57596/

joyeecheung and others added 2 commits March 5, 2024 21:13
PR-URL: #51978
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024
@RafaelGSS
Copy link
Member

CITGM https://ci.nodejs.org/job/citgm-smoker/3397/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 5, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57599/ ✔️
📦 https://ci-release.nodejs.org/job/iojs+release/10017/
CITGM https://ci.nodejs.org/job/citgm-smoker/3397/ ✔️

@RafaelGSS RafaelGSS merged commit 47e6820 into v21.x Mar 6, 2024
53 checks passed
@RafaelGSS RafaelGSS deleted the v21.7.0-proposal branch March 6, 2024 18:33
RafaelGSS added a commit that referenced this pull request Mar 6, 2024
RafaelGSS pushed a commit that referenced this pull request Mar 6, 2024
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) #51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) #51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) #51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) #51812
  * add lemire to collaborators (Daniel Lemire) #51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) #51412
  * (SEMVER-MINOR) add server handshake utility (snek) #51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) #51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) #51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) #50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) #50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) #50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) #51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) #51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) #51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) #51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) #51244

PR-URL: #51932
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2024
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2024
RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2024
marco-ippolito pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2024
marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request Mar 6, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) nodejs#51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) nodejs#51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) nodejs#51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) nodejs#51812
  * add lemire to collaborators (Daniel Lemire) nodejs#51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) nodejs#51412
  * (SEMVER-MINOR) add server handshake utility (snek) nodejs#51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) nodejs#51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) nodejs#51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) nodejs#50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) nodejs#50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) nodejs#50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) nodejs#51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) nodejs#51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) nodejs#51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) nodejs#50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) nodejs#51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) nodejs#51244

PR-URL: nodejs#51932
jcbhmr pushed a commit to jcbhmr/node that referenced this pull request May 15, 2024
Notable changes:

build:
  * (SEMVER-MINOR) build opt to set local location of headers (Michael Dawson) nodejs#51525
crypto:
  * (SEMVER-MINOR) implement crypto.hash() (Joyee Cheung) nodejs#51044
  * update root certificates to NSS 3.98 (Node.js GitHub Bot) nodejs#51794
doc:
  * add zcbenz to collaborators (Cheng Zhao) nodejs#51812
  * add lemire to collaborators (Daniel Lemire) nodejs#51572
http2:
  * (SEMVER-MINOR) add h2 compat support for appendHeader (Tim Perry) nodejs#51412
  * (SEMVER-MINOR) add server handshake utility (snek) nodejs#51172
  * (SEMVER-MINOR) receive customsettings (Marten Richter) nodejs#51323
lib:
  * (SEMVER-MINOR) move encodingsMap to internal/util (Joyee Cheung) nodejs#51044
sea:
  * (SEMVER-MINOR) support sea.getRawAsset() (Joyee Cheung) nodejs#50960
  * (SEMVER-MINOR) support embedding assets (Joyee Cheung) nodejs#50960
src:
  * (SEMVER-MINOR) print string content better in BlobDeserializer (Joyee Cheung) nodejs#50960
  * (SEMVER-MINOR) support multi-line values for .env file (IlyasShabi) nodejs#51289
  * (SEMVER-MINOR) add `process.loadEnvFile` and `util.parseEnv` (Yagiz Nizipli) nodejs#51476
  * (SEMVER-MINOR) do not coerce dotenv paths (Tobias Nießen) nodejs#51425
stream:
  * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) nodejs#50888
util:
  * (SEMVER-MINOR) add styleText API to text formatting (Rafael Gonzaga) nodejs#51850
vm:
  * (SEMVER-MINOR) support using the default loader to handle dynamic import() (Joyee Cheung) nodejs#51244

PR-URL: nodejs#51932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.