test: use checkIfCollectableByCounting in SourceTextModule leak test #51512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which may be more reliable than than checkIfCollectable().
nodejs-github-bot
added
esm
|
Should I try to apply it to #51362 for validation? |
aduh95
reviewed
Jan 18, 2024
aduh95
approved these changes
Jan 19, 2024
lpinca
approved these changes
Jan 19, 2024
github-actions
bot
removed
the
request-ci
debadree25
added
the
author ready
targos
approved these changes
Jan 22, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in aef9d4e |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
...which may be more reliable than than checkIfCollectable(). PR-URL: nodejs#51512 Refs: nodejs#51362 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
...which may be more reliable than than checkIfCollectable(). PR-URL: #51512 Refs: #51362 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
...which may be more reliable than than checkIfCollectable(). PR-URL: nodejs#51512 Refs: nodejs#51362 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
...which may be more reliable than than checkIfCollectable(). PR-URL: #51512 Refs: #51362 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
...which may be more reliable than than checkIfCollectable(). PR-URL: #51512 Refs: #51362 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which may be more reliable than than checkIfCollectable().
Refs: #51362