Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reserve 123 for Electron 30 #51803

Closed
wants to merge 1 commit into from
Closed

doc: reserve 123 for Electron 30 #51803

wants to merge 1 commit into from

Conversation

VerteDinde
Copy link
Contributor

This PR reserves NMV 123 for Electron 30.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 19, 2024
@VerteDinde VerteDinde mentioned this pull request Feb 19, 2024
Merged
5 tasks
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2024
codebytere pushed a commit that referenced this pull request Feb 21, 2024
@VerteDinde @codebytere
doc: reserve 123 for Electron 30
a0ac8bd 
PR-URL: #51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@codebytere
Copy link
Member

Landed in a0ac8bd

@codebytere codebytere closed this Feb 21, 2024
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@VerteDinde @marco-ippolito
doc: reserve 123 for Electron 30
5985e56 
PR-URL: #51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@VerteDinde @marco-ippolito
doc: reserve 123 for Electron 30
2de1e85 
PR-URL: #51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
@VerteDinde @rdw-msft
doc: reserve 123 for Electron 30
f758866 
PR-URL: nodejs#51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@VerteDinde @richardlau
doc: reserve 123 for Electron 30
deaa273 
PR-URL: #51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@VerteDinde @richardlau
doc: reserve 123 for Electron 30
3240a2f 
PR-URL: #51803
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@targos targos targos approved these changes

@codebytere codebytere codebytere approved these changes

@lpinca lpinca lpinca approved these changes

@edsadr edsadr edsadr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@VerteDinde @codebytere @edsadr @lpinca @targos @UlisesGascon @marco-ippolito @legendecas @nodejs-github-bot