build: update GN build files for ngtcp2 #51313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Dec 31, 2023
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
|
An early merge would be appreciated so we can bring CI of GN build to green to continue monitoring the health of GN build . |
jasnell
approved these changes
Jan 3, 2024
gengjiawen
approved these changes
Jan 5, 2024
gengjiawen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 68c8472 |
27 tasks
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51313 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51313 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51313 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51313 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51313 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #51291 for the GN side changes.