Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release a patch release for 2024a tzdata #51933

Closed
danielt998 opened this issue Mar 1, 2024 · 4 comments
Closed

Release a patch release for 2024a tzdata #51933

danielt998 opened this issue Mar 1, 2024 · 4 comments
Labels
feature request Issues that request new features to be added to Node.js. icu Issues and PRs related to the ICU dependency. release Issues and PRs related to Node.js releases. release-agenda Issues and PRs to discuss during the meetings of the Release team.

Comments

@danielt998
Copy link

danielt998 commented Mar 1, 2024 •
edited
Loading

What is the problem this feature will solve?

As far as I can tell, the code has already been updated to 2024a, however the last release is using 2023d. This is important because it includes a change to Kazakhstan's time zone, which starts on the 1 Mar 2024 (today!)

What is the feature you are proposing to solve the problem?

releasing a patch version, (afaik) no code changes required
To confirm the fix, one can run
process.versions.tz in a node console

What alternatives have you considered?

No response
@danielt998 danielt998 added the feature request Issues that request new features to be added to Node.js. label Mar 1, 2024
@github-project-automation github-project-automation bot moved this to Pending Triage in Node.js feature requests Mar 1, 2024
@meixg meixg added the release Issues and PRs related to Node.js releases. label Mar 2, 2024
@VoltrexKeyva VoltrexKeyva added the icu Issues and PRs related to the ICU dependency. label Mar 2, 2024
@aduh95
Copy link
Contributor

aduh95 commented Mar 3, 2024

/cc @nodejs/releasers

It might be worth considering having a "simplified release process" for releasing timely sensitive patches as this one.

@richardlau richardlau added the release-agenda Issues and PRs to discuss during the meetings of the Release team. label Mar 5, 2024
@richardlau
Copy link
Member

richardlau commented Mar 5, 2024 •
edited
Loading

As far as I can tell, the code has already been updated to 2024a, however the last release is using 2023d. This is important because it includes a change to Kazakhstan's time zone, which starts on the 1 Mar 2024 (today!)

The release proposal for Node.js 21.7.0 includes this: #51932

#51723 updated the timezone for ICU 74. Node.js 20 and 18 are still on ICU 73.

@nodejs/lts Thoughts on whether we should separately patch the timezone database for ICU 73 for Node.js 20 and 18 or update with the commits on main (including updating to ICU 74.2)?

@richardlau richardlau mentioned this issue Mar 5, 2024
Open
This was referenced Mar 5, 2024
Closed
Closed
@targos
Copy link
Member

targos commented Mar 5, 2024

I opened #51972 and #51973.

richardlau pushed a commit that referenced this issue Mar 18, 2024
@nodejs-github-bot @richardlau
deps: update icu to 74.1
2a2bf57 
PR-URL: #50515
Backport-PR-URL: #51973
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 18, 2024
@nodejs-github-bot @richardlau
deps: update timezone to 2023d
90c73d2 
PR-URL: #51461
Backport-PR-URL: #51973
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 18, 2024
@targos @richardlau
tools: fix update-icu.sh
3184bef 
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 18, 2024
@targos @richardlau
deps: update icu to 74.2
f9b229e 
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51973
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 18, 2024
@targos @richardlau
deps: update timezone to 2024a
68fd751 
PR-URL: #51723
Backport-PR-URL: #51973
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 25, 2024
@nodejs-github-bot @richardlau
deps: update icu to 74.1
4ee0f83 
PR-URL: #50515
Backport-PR-URL: #51972
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 25, 2024
@nodejs-github-bot @richardlau
deps: update timezone to 2023d
e6fc5a5 
PR-URL: #51461
Backport-PR-URL: #51972
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 25, 2024
@targos @richardlau
tools: fix update-icu.sh
bc6bdda 
The name of the sources MD5 file has changed.

Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51972
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 25, 2024
@targos @richardlau
deps: update icu to 74.2
452d74c 
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
PR-URL: #51723
Backport-PR-URL: #51972
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
richardlau pushed a commit that referenced this issue Mar 25, 2024
@targos @richardlau
deps: update timezone to 2024a
4ee7f29 
PR-URL: #51723
Backport-PR-URL: #51972
Refs: https://github.com/unicode-org/icu/releases/tag/release-74-2
Refs: #51721
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Steven R Loomis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #51933
@richardlau
Copy link
Member

FTR Node.js included the 2024a tzdata update in:

  • 21.7.0
  • 20.12.0
  • 18.20.0

@RedYetiDev RedYetiDev moved this from Awaiting Triage to Done in Node.js feature requests Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. icu Issues and PRs related to the ICU dependency. release Issues and PRs related to Node.js releases. release-agenda Issues and PRs to discuss during the meetings of the Release team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@targos @richardlau @danielt998 @meixg @aduh95 @VoltrexKeyva