Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v21.7.0 proposal #51932

Merged
merged 209 commits into from
Mar 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
209 commits
Select commit Hold shift + click to select a range
22a11c3
meta: move one or more collaborators to emeritus
nodejs-github-bot Jan 3, 2024
8ea7d79
src: avoid shadowed string in fs_permission
codebytere Jan 3, 2024
77598c3
meta: bump actions/stale from 8.0.0 to 9.0.0
dependabot[bot] Jan 3, 2024
e4f9f0a
meta: bump github/codeql-action from 2.22.8 to 3.22.12
dependabot[bot] Jan 3, 2024
6c3ba73
meta: bump actions/setup-node from 4.0.0 to 4.0.1
dependabot[bot] Jan 3, 2024
595542e
meta: bump actions/setup-python from 4.7.1 to 5.0.0
dependabot[bot] Jan 3, 2024
9ab353a
stream: implement `min` option for `ReadableStreamBYOBReader.read`
MattiasBuelens Jan 4, 2024
e942dc1
meta: add .temp and .lock tags to ignore
RafaelGSS Jan 4, 2024
e8fffeb
fs,test: add URL to string to fs.watch
RafaelGSS Jan 5, 2024
9da0926
build: update GN build files for ngtcp2
zcbenz Jan 5, 2024
fabd5c4
doc: fixup alignment of warning subsection
jasnell Jan 5, 2024
66c11f3
node-api: optimize napi_set_property for perf
mertcanaltin Dec 19, 2023
17c554f
crypto: use EVP_MD_fetch and cache EVP_MD for hashes
joyeecheung Jan 5, 2024
4d06d80
quic: various additional cleanups, fixes in Endpoint
jasnell Dec 27, 2023
36e42aa
src: do not read string out of bounds
zcbenz Jan 6, 2024
83b3aa8
tools: remove deprecated python api
himself65 Sep 20, 2023
63e0ceb
net: fix example IPv4 in dns docs
Uzlopak Jan 7, 2024
35f33d3
tools: remove openssl v1 update script
marco-ippolito Jan 7, 2024
c18a813
doc: add missing word in `child_process.md`
joseph0007 Jan 7, 2024
17593d9
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Jan 7, 2024
d7658ca
doc: improve subtests documentation
marco-ippolito Jan 7, 2024
29492e2
tools: fix version parsing in brotli update script
richardlau Jan 7, 2024
b271cc5
src: refactor `GetCreationContext` calls
Jan 7, 2024
b9275d9
http2: receive customsettings
martenrichter Jan 7, 2024
28c2bf3
test: remove unneeded common.expectsError for asserts
AndresMorelos Jan 7, 2024
76582e4
deps: add nghttp3/**/.deps to .gitignore
lpinca Jan 8, 2024
e0789fb
test_runner: do not invoke after hook when test is empty
marco-ippolito Jan 8, 2024
74d4e38
doc: fix some policy scope typos
timkuijsten Jan 8, 2024
17cb4af
deps: update uvwasi to 0.0.20 and fixup tests
mhdawson Jan 3, 2024
70e88cf
doc: add check for security reverts
mhdawson Jan 4, 2024
942e10f
deps: update c-ares to 1.25.0
nodejs-github-bot Jan 5, 2024
5b94ff4
node-api: move NAPI_EXPERIMENTAL definition to gyp file
gabrielschulhof Jan 10, 2024
58901d0
tools: update github_reporter to 1.5.4
nodejs-github-bot Jan 10, 2024
615b0ae
module: fix `--preserve-symlinks-main`
per4uk Jan 10, 2024
f3845de
tools: update inspector_protocol to 83b1154
cola119 Jan 11, 2024
1cc37c4
deps: upgrade npm to 10.3.0
npm-cli-bot Jan 11, 2024
015c4dc
meta: move RaisinTen to emeritus and remove from strategic initiatives
RaisinTen Jan 12, 2024
7420a7d
test: add URL tests to fs-write
RafaelGSS Jan 12, 2024
119e045
src: do not coerce dotenv paths
tniessen Jan 12, 2024
d8aa2ba
http2: add server handshake utility
devsnek Jan 12, 2024
4b1c683
http2: add h2 compat support for appendHeader
pimterry Jan 12, 2024
fc56296
doc: fix spelling mistake
u9g Jan 14, 2024
4ea194a
doc: add links in `offboarding.md`
aduh95 Jan 14, 2024
129d3b3
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Jan 14, 2024
ec60639
lib: remove unnecessary refreshHrtimeBuffer()
joyeecheung Jan 14, 2024
e88a301
tools: do not pass invalid flag to C compiler
targos Jan 9, 2024
139a626
deps: compile c-ares with C11 support
targos Jan 9, 2024
16fea71
meta: move one or more collaborators to emeritus
nodejs-github-bot Jan 15, 2024
81fd7d1
tools: limit parallelism with ninja in V8 builds
richardlau Jan 17, 2024
d4d07f4
test: remove test-file-write-stream4 flaky designation
lpinca Jan 17, 2024
10f9528
doc: add notes on inspector breakpoints
legendecas Jan 18, 2024
2bf3718
doc: update typos
big-kahuna-burger Jan 18, 2024
d3b7805
doc: remove reference to resolved child_process v8 issue
isker Jan 18, 2024
391aeb1
module: fix crash when built-in module export a `default` key
aduh95 Jan 19, 2024
4b583bf
lib: allow checking the test result from afterEach
tims-bsquare Jan 19, 2024
40e8b36
deps: update base64 to 0.5.2
nodejs-github-bot Jan 19, 2024
1d40a00
doc: fix type of connectionAttempt parameter
RafaelGSS Jan 19, 2024
fd2a3ce
doc: fix historical experimental fetch flag
kenrick95 Jan 20, 2024
e3a6384
src: terminate correctly double-quote in env variable
marco-ippolito Jan 20, 2024
d8bb4b2
fs: update jsdoc for `filehandle.createWriteStream` and `appendFile`
Jan 20, 2024
dbf4474
meta: mark security-wg codeowner for deps folder
marco-ippolito Jan 21, 2024
365a9dc
deps: update timezone to 2023d
nodejs-github-bot Jan 21, 2024
9dfb36f
test,crypto: update WebCryptoAPI WPT
panva Jan 22, 2024
c88f0b6
test: use checkIfCollectableByCounting in SourceTextModule leak test
joyeecheung Jan 22, 2024
682f4f6
deps: update acorn-walk to 8.3.2
nodejs-github-bot Jan 22, 2024
4b1d25b
deps: update ngtcp2 to 1.1.0
nodejs-github-bot Jan 22, 2024
438b7fd
stream: fix cloned webstreams not being unref correctly
tsctx Jan 23, 2024
b8ae5c2
src: add `process.loadEnvFile` and `util.parseEnv`
anonrig Jan 23, 2024
2921d55
build: remove copyright header in node.gni
zcbenz Jan 24, 2024
4ddb9b3
async_hooks,inspector: implement inspector api without async_wrap
dygabo Jan 24, 2024
e0eeebc
tools: set normalizeTD text default to empty string
marco-ippolito Jan 24, 2024
d8e1058
tools: fix loong64 build
shipujin Jan 24, 2024
15a7f21
fs: remove race condition for recursive watch on Linux
mcollina Jan 25, 2024
fc0c130
test: mark test-http2-large-file as flaky
targos Jan 25, 2024
cc37959
build: increase parallel executions in github
anonrig Jan 25, 2024
85f63f3
build: check before removing %config% link
liudonghua123 Jan 25, 2024
db88bf1
test: remove common.expectsError calls for asserts
opchaves Jan 25, 2024
adbf2d3
doc: add lemire to collaborators
lemire Jan 26, 2024
a04aa36
deps: update googletest to 7c07a86
nodejs-github-bot Jan 27, 2024
177e13c
doc: note that path.normalize deviates from POSIX
tniessen Jan 29, 2024
c4a28b2
meta: add .mailmap entry for lemire
lemire Jan 29, 2024
e1b9655
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Jan 30, 2024
8c0a257
doc: fix `dns.lookup` and `dnsPromises.lookup` description
duncanchiu409 Jan 30, 2024
3e579ab
repl: fix `NO_COLORS` env var is ignored
MoLow Jan 31, 2024
c7912c3
src: support multi-line values for .env file
IlyasShabi Jan 31, 2024
5fe493d
tools: run `build-windows` workflow only on source changes
aduh95 Jan 31, 2024
8f63f6f
deps: update ngtcp2 to 1.2.0
nodejs-github-bot Jan 31, 2024
7f698f0
lib: define FormData and fetch etc. in the built-in snapshot
joyeecheung Jan 31, 2024
5aca6f5
deps: update ada to 2.7.5
nodejs-github-bot Jan 22, 2024
fe597de
deps: update ada to 2.7.6
nodejs-github-bot Jan 30, 2024
e5db8d4
deps: update corepack to 0.24.1
nodejs-github-bot Jan 31, 2024
08832e7
esm: improve error when calling `import.meta.resolve` from `data:` URL
aduh95 Jan 31, 2024
c820166
test: remove test-fs-rmdir-recursive flaky designation
lpinca Feb 1, 2024
6603d32
src: fix vm bug for configurable globalThis
fhinkel Feb 1, 2024
2ad665e
deps: V8: cherry-pick efb1133eb894
joyeecheung Feb 1, 2024
682951a
http2: close idle connections when allowHTTP1 is true
xsbchen Feb 1, 2024
8235c26
deps: update nghttp2 to 1.59.0
nodejs-github-bot Feb 1, 2024
5a8af3d
fs: load rimraf lazily in fs/promises
joyeecheung Feb 2, 2024
47186fb
src: print string content better in BlobDeserializer
joyeecheung Nov 20, 2023
cea5295
sea: support embedding assets
joyeecheung Nov 14, 2023
e8d9065
sea: support sea.getRawAsset()
joyeecheung Nov 28, 2023
1999719
build: use macOS m1 machines for testing
anonrig Feb 2, 2024
c9be260
doc: clarify execution of `after` hook on test suite completion
ognjenjevremovic Feb 3, 2024
dfc3811
deps: update googletest to 6a59382
nodejs-github-bot Feb 3, 2024
a8ac337
test: remove test-crypto-keygen flaky designation
lpinca Feb 3, 2024
37182c4
doc: fix uncaught exception example
gabrielschulhof Feb 3, 2024
dcf5f28
meta: bump github/codeql-action from 3.22.12 to 3.23.2
dependabot[bot] Feb 3, 2024
97e3cb5
meta: bump actions/cache from 3.3.2 to 4.0.0
dependabot[bot] Feb 3, 2024
51f0d80
meta: bump step-security/harden-runner from 2.6.1 to 2.7.0
dependabot[bot] Feb 3, 2024
9782560
meta: bump actions/upload-artifact from 4.0.0 to 4.3.0
dependabot[bot] Feb 3, 2024
16aa6e5
meta: bump actions/download-artifact from 4.1.0 to 4.1.1
dependabot[bot] Feb 3, 2024
e5c52a2
meta: bump codecov/codecov-action from 3.1.4 to 4.0.1
dependabot[bot] Feb 4, 2024
b8e7a87
http: split set-cookie when using setHeaders
marco-ippolito Feb 4, 2024
e929925
test: remove duplicate entry for flaky test
lpinca Feb 5, 2024
c3dbd7c
deps: update c-ares to 1.26.0
nodejs-github-bot Feb 5, 2024
751821f
tools: update github_reporter to 1.6.0
nodejs-github-bot Feb 6, 2024
ba22c61
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Feb 11, 2024
1b45ca4
doc: document the GN build
zcbenz Feb 12, 2024
519dc8a
doc: updates for better json generating
Semigradsky Feb 13, 2024
a62f69e
doc: fix `globals.md` introduction
aduh95 Feb 15, 2024
af6b5b1
doc: mark isWebAssemblyCompiledModule eol
marco-ippolito Jan 14, 2024
4c50826
vm: support using the default loader to handle dynamic import()
joyeecheung Feb 1, 2024
407341e
url: don't update URL immediately on update to URLSearchParams
MattIPv4 Feb 15, 2024
787fb32
tools: fix update-icu.sh
targos Feb 11, 2024
8d22227
deps: update icu to 74.2
targos Feb 11, 2024
6d2699d
deps: update timezone to 2024a
targos Feb 11, 2024
8ae0eeb
build: build opt to set local location of headers
mhdawson Dec 13, 2023
7fa3081
doc: update technical priorities for 2023
sheplu Apr 12, 2023
d7563a5
test: fix `internet/test-inspector-help-page`
richardlau Feb 16, 2024
ba444a9
vm: implement isContext() directly in JS land with private symbol
joyeecheung Feb 16, 2024
2a46dc7
src: check empty before accessing string
zcbenz Feb 16, 2024
4e0c79b
doc: add entry to stewards
RafaelGSS Feb 16, 2024
9d3a014
test: remove test-domain-error-types flaky designation
lpinca Feb 16, 2024
ea08350
test: remove test-cli-node-options flaky designation
lpinca Feb 17, 2024
9840715
build: encode non-ASCII Latin1 characters as one byte in JS2C
joyeecheung Feb 17, 2024
7ceb6d6
sea: update stability index
joyeecheung Feb 17, 2024
af5875c
test_runner: check if timeout was cleared by own callback
Benricheson101 Feb 18, 2024
b53919d
doc,crypto: add changelog and note about disabled RSA_PKCS1_PADDING
panva Feb 18, 2024
adb2c36
typings: lib/internal/vm.js
GeoffreyBooth Feb 19, 2024
83f581d
test: increase platform timeout zlib-brotli-16gb
RafaelGSS Feb 19, 2024
a8c9e6f
doc: add zcbenz to collaborators
zcbenz Feb 20, 2024
80c750c
doc,crypto: further clarify RSA_PKCS1_PADDING support
tniessen Feb 18, 2024
b046712
test: skip test-http-correct-hostname on loong64
shipujin Feb 4, 2024
77ae03f
lib: create global console properties at snapshot build time
joyeecheung Feb 20, 2024
0c41210
src: compile code eagerly in snapshot builder
joyeecheung Feb 20, 2024
92e7c31
benchmark: rename startup.js to startup-core.js
joyeecheung Feb 5, 2024
614ca32
lib: add assertion for user ESM execution
joyeecheung Feb 21, 2024
ad8cefc
doc: add mention to GPG_TTY
RafaelGSS Feb 21, 2024
2de1e85
doc: reserve 123 for Electron 30
VerteDinde Feb 19, 2024
32d92ac
doc: add Paolo to TSC members
mhdawson Feb 21, 2024
2fb620c
test: remove test-fs-stat-bigint flaky designation
lpinca Feb 22, 2024
275cea0
test: mark test-wasi as flaky on Windows on ARM
joyeecheung Feb 22, 2024
ccc76bb
src: simplify embedder entry point execution
joyeecheung Feb 23, 2024
d1a8c2e
build: fix building js2c with GN
zcbenz Feb 21, 2024
9be6b7c
build: fix warning in cares under GN build
zcbenz Feb 7, 2024
5911731
build,tools: make addons tests work with GN
zcbenz Nov 16, 2023
86ac787
build: do not rely on gn_helpers in GN build
zcbenz Jan 11, 2024
bc6f33d
node-api: make napi_get_buffer_info check if passed buffer is valid
Janrupf Feb 23, 2024
58e2015
inspector: add NodeRuntime.waitingForDebugger event
mmarchini Feb 23, 2024
f845a16
test: split wasi tests
joyeecheung Feb 24, 2024
b502be1
tools: disable automated libuv updates
RafaelGSS Feb 24, 2024
1f6551d
test: fix test-child-process-fork-net
joyeecheung Feb 23, 2024
c0918f0
test: ensure delay in recursive fs watch tests
joyeecheung Feb 23, 2024
c9ada53
build: remove `librt` libs link for Android compatibility
MeowShe Feb 25, 2024
03f926d
tools: fix missing [[fallthrough]] in js2c
zcbenz Feb 25, 2024
6c0a3b9
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Feb 18, 2024
20effe6
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Feb 25, 2024
c708372
deps: update c-ares to 1.27.0
nodejs-github-bot Feb 25, 2024
58b1403
deps: update corepack to 0.25.2
nodejs-github-bot Feb 25, 2024
d47a95f
test: fix test-bootstrap-modules for coverage generation
joyeecheung Feb 20, 2024
2bf03ee
test: fix test-debugger-profile for coverage generation
joyeecheung Feb 20, 2024
496776c
crypto: update root certificates to NSS 3.98
nodejs-github-bot Feb 25, 2024
28c0ffb
deps: update simdjson to 3.7.0
lemire Feb 25, 2024
049e5f5
test: deflake test-http2-large-write-multiple-requests
joyeecheung Feb 23, 2024
eb1089a
lib: do not access process.noDeprecation at build time
joyeecheung Feb 26, 2024
8dc3f91
lib,src: extract sourceMappingURL from module
unbyte Feb 6, 2024
88e08bb
util: add styleText API to text formatting
RafaelGSS Feb 26, 2024
3b29dff
deps: update ngtcp2 to 1.3.0
nodejs-github-bot Feb 26, 2024
a5a17a1
doc: change `ExperimentalWarnings` to `ExperimentalWarning`
akaustav Feb 26, 2024
8f10543
src: stop the profiler and the inspector before snapshot serialization
joyeecheung Feb 20, 2024
5f94912
test_runner: add ref methods to mocked timers
marco-ippolito Feb 26, 2024
ec17fd7
http: fix `close` return value mismatch between doc and implementation
kylo5aby Feb 26, 2024
78f8180
events: no stopPropagation call in cancelBubble
Oct 26, 2023
71a809b
tools: update eslint to 8.57.0
nodejs-github-bot Feb 27, 2024
f130a33
Revert "fs: remove workaround for `esm` package"
jeremymeng Jan 2, 2024
4ebb944
deps: update undici to 6.6.2
targos Feb 15, 2024
5a2d2da
lib: move encodingsMap to internal/util
joyeecheung Dec 4, 2023
78c2262
crypto: implement crypto.hash()
joyeecheung Jan 5, 2024
db30428
doc: update guide link for Event Loop
shrujalshah28 Feb 27, 2024
c6cc3ed
net: fix connect crash when call destroy in lookup handler
theanarkh Feb 27, 2024
2cdfe35
doc: add website team to sharing project news
UlisesGascon Feb 27, 2024
7543e77
src: simplify direct queries of env vars in C++ land
joyeecheung Feb 27, 2024
5b06af7
stream: fix eventNames() to not return not defined events
IlyasShabi Feb 27, 2024
72be232
benchmark: update iterations of benchmark/assert/deepequal-map.js
Feb 28, 2024
7e06c11
benchmark: update iterations of assert/deepequal-typedarrays.js
Feb 28, 2024
5874773
doc: update node-api/node-addon-api team link to sharing project news
UlisesGascon Feb 28, 2024
3fdaeba
doc: remove redundant backquote which breaks sentence
JounQin Feb 28, 2024
84c71fa
meta: move one or more collaborators to emeritus
nodejs-github-bot Feb 28, 2024
e2c5138
test: test surrogate pair filenames on windows
mertcanaltin Feb 18, 2024
cb62186
perf_hooks: performance milestone time origin timestamp improvement
IlyasShabi Feb 28, 2024
e4d4bc6
test_runner: serialize 'expected' and 'actual' in isolation
malthe Feb 29, 2024
4dfc9e0
lib: only build the ESM facade for builtins when they are needed
joyeecheung Feb 5, 2024
014cc53
deps: upgrade npm to 10.5.0
npm-cli-bot Feb 29, 2024
1edbc7d
lib: fix http client socket path
theanarkh Feb 29, 2024
af32d43
lib: account for cwd access from snapshot serialization cb
addaleax Feb 29, 2024
17ab5ae
test: fix unreliable assumption in js-native-api/test_cannot_run_js
joyeecheung Mar 1, 2024
27f8549
tools: fix installing node with shared mode
zcbenz Mar 1, 2024
4a889e8
doc: add stability index to crypto.hash()
joyeecheung Mar 5, 2024
47e6820
2024-03-06, Version 21.7.0 (Current)
marco-ippolito Mar 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@

# Startup

/benchmark/misc/startup.js @nodejs/startup
/benchmark/misc/startup-* @nodejs/startup
/lib/internal/bootstrap/* @nodejs/startup
/src/node_builtins* @nodejs/startup
/src/node_realm* @nodejs/startup @nodejs/realm
Expand Down Expand Up @@ -174,6 +174,7 @@
/.github/workflows/tools.yml @nodejs/security-wg
/.github/workflows/update-openssl.yml @nodejs/security-wg
/.github/workflows/update-v8.yml @nodejs/security-wg @nodejs/v8-update
/deps @nodejs/security-wg
/tools/dep_updaters/* @nodejs/security-wg

# Web Standards
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -57,7 +57,7 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: tarballs
path: tarballs
Expand All @@ -69,13 +69,13 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@f44cd7b40bfd40b6aa1cc1b9b5b7bf03d3c67110 # v4.1.0
uses: actions/download-artifact@6b208ae046db98c579e8a3aa621ab581ff575935 # v4.1.1
with:
name: tarballs
path: tarballs
Expand All @@ -90,8 +90,8 @@ jobs:
- name: Build
run: |
cd $TAR_DIR
make build-ci -j2 V=1
make build-ci -j4 V=1
- name: Test
run: |
cd $TAR_DIR
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9"
make run-ci -j4 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9"
24 changes: 15 additions & 9 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,27 @@ name: Build Windows

on:
pull_request:
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/build-windows.yml'
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- tools/gyp/**
- .github/workflows/build-windows.yml
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- main
- canary
- v[0-9]+.x-staging
- v[0-9]+.x
paths-ignore:
- README.md
- .github/**
- '!.github/workflows/build-windows.yml'
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- tools/gyp/**
- .github/workflows/build-windows.yml

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand All @@ -42,7 +48,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/close-stale-feature-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@1160a2240286f5da8ec72b1c0816ce2481aabf84 # v8.0.0
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 180
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@1160a2240286f5da8ec72b1c0816ce2481aabf84 # v8.0.0
- uses: actions/stale@28ca1036281a5e5922ead5184a1bbf96e5fc984e # v9.0.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-close: 30
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install @node-core/utils
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/coverage-linux-without-intl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,19 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Install gcovr
run: pip install gcovr==4.2
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
- name: Report JS
run: npx c8 report --check-coverage
env:
Expand All @@ -68,6 +68,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
uses: codecov/codecov-action@e0b68c6749509c5f83f984dd99a76a1c1a231044 # v4.0.1
with:
directory: ./coverage
8 changes: 4 additions & 4 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,19 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Install gcovr
run: pip install gcovr==4.2
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j4 V=1 TEST_CI_ARGS="-p dots --node-args='--test-reporter=spec' --measure-flakiness 9" || exit 0
- name: Report JS
run: npx c8 report --check-coverage
env:
Expand All @@ -68,6 +68,6 @@ jobs:
- name: Clean tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
uses: codecov/codecov-action@e0b68c6749509c5f83f984dd99a76a1c1a231044 # v4.0.1
with:
directory: ./coverage
4 changes: 2 additions & 2 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand All @@ -67,6 +67,6 @@ jobs:
- name: Clean tmp
run: npx rimraf ./coverage/tmp
- name: Upload
uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
uses: codecov/codecov-action@e0b68c6749509c5f83f984dd99a76a1c1a231044 # v4.0.1
with:
directory: ./coverage
6 changes: 3 additions & 3 deletions .github/workflows/daily-wpt-fyi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -45,7 +45,7 @@ jobs:
run: echo "NIGHTLY=$(curl -s https://nodejs.org/download/nightly/index.json | jq -r '[.[] | select(.files[] | contains("linux-x64"))][0].version')" >> $GITHUB_ENV
- name: Install Node.js
id: setup-node
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NIGHTLY || matrix.node-version }}
check-latest: true
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
run: cp wptreport.json wptreport-${{ steps.setup-node.outputs.node-version }}.json
- name: Upload GitHub Actions artifact
if: ${{ env.WPT_REPORT != '' }}
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
path: out/wpt/wptreport-*.json
name: WPT Report for ${{ steps.setup-node.outputs.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/doc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ jobs:
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Build
run: NODE=$(command -v node) make doc-only
- uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
- uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: docs
path: out/doc
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/find-inactive-collaborators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
persist-credentials: false

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/find-inactive-tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
repository: nodejs/TSC

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand All @@ -44,7 +44,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -60,11 +60,11 @@ jobs:
fetch-depth: 0
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
with:
persist-credentials: false
- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: ${{ env.NODE_VERSION }}
- name: Environment Information
Expand All @@ -122,7 +122,7 @@ jobs:
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -139,7 +139,7 @@ jobs:
with:
persist-credentials: false
- name: Use Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@65d7f2d534ac1bc67fcd62888c5f4f3d2cb2b236 # v4.7.1
uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

steps:
- name: Harden Runner
uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1
uses: step-security/harden-runner@63c24ba6bd7ba022e95695ff85de572c04a18142 # v2.7.0
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down Expand Up @@ -65,14 +65,14 @@ jobs:
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: Upload artifact
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # v4.0.0
uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
with:
name: SARIF file
path: results.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: Upload to code-scanning
uses: github/codeql-action/upload-sarif@407ffafae6a767df3e0230c3df91b6443ae8df75 # v2.22.8
uses: github/codeql-action/upload-sarif@b7bf0a3ed3ecfa44160715d7c442788f65f0f923 # v3.23.2
with:
sarif_file: results.sarif
Loading
Loading