Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.13.1 proposal #40974

Merged
merged 118 commits into from
Dec 1, 2021
Merged

v16.13.1 proposal #40974

merged 118 commits into from
Dec 1, 2021

Commits on Oct 26, 2021

  1. doc: update CHANGELOG.md for Node.js 16.13.0

    Update missed changes for the main CHANGELOG.md for Node.js 16.13.0.
    
    PR-URL: #40617
    Refs: #40536
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    richardlau committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    3b1499c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. build: update codeowners-validator to 0.6

    PR-URL: #40307
    Reviewed-By: Mary Marchini <[email protected]>
    iam-frankqiu authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    134e8af View commit details
    Browse the repository at this point in the history
  2. tools: update lint-md dependencies

    Update lint-md dependencies and re-create lint-md.mjs.
    
    PR-URL: #40404
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    a999087 View commit details
    Browse the repository at this point in the history
  3. meta: consolidate AUTHORS entries for evantorrie

    Add a .mailmap entry for evantorrie to consolidate their two AUTHORS
    entries into one.
    
    PR-URL: #40430
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Juan José Arboleda <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    e2c9e1c View commit details
    Browse the repository at this point in the history
  4. doc: indicate n-api out params that may be NULL

    This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879
    
    PR-URL: #40371
    Reviewed-By: Chengzhong Wu <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    isaacbrodsky authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4724e07 View commit details
    Browse the repository at this point in the history
  5. meta: add typings to label-pr-config

    PR-URL: #40401
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Mesteery authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    06706e8 View commit details
    Browse the repository at this point in the history
  6. doc: update Collaborator guide to reflect GitHub web UI update

    PR-URL: #40456
    Reviewed-By: Darshan Sen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    aduh95 authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    934dcc8 View commit details
    Browse the repository at this point in the history
  7. meta: consolidate AUTHORS entries for ebickle

    PR-URL: #40447
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    618bbbf View commit details
    Browse the repository at this point in the history
  8. src: ensure V8 initialized before marking milestone

    PR-URL: #40405
    Refs: electron/electron#31349
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Joyee Cheung <[email protected]>
    codebytere authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    ff3b7d2 View commit details
    Browse the repository at this point in the history
  9. build: avoid run find inactive authors on forked repo

    PR-URL: #40465
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    gengjiawen authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    bfdd32f View commit details
    Browse the repository at this point in the history
  10. src: get embedder options on-demand

    Only query embedder options when they are needed so that the bootstrap
    remains as stateless as possible so that the bootstrap snapshot is
    controlled solely by configure options, and subsequent runtime changes
    should be done in pre-execution.
    
    PR-URL: #40357
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Shelley Vohr <[email protected]>
    joyeecheung authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    c15afda View commit details
    Browse the repository at this point in the history
  11. tools: update tools/lint-md dependencies to support GFM footnotes

    PR-URL: #40445
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    04c2cbe View commit details
    Browse the repository at this point in the history
  12. benchmark: increase crypto DSA keygen params

    OpenSSL 3.0 increased the minimum values for these parameters.
    
    PR-URL: #40416
    Fixes: #40410
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    mscdex authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    996bc6e View commit details
    Browse the repository at this point in the history
  13. meta: consolidate AUTHORS entries for emanuelbuholzer

    PR-URL: #40469
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    2a2b549 View commit details
    Browse the repository at this point in the history
  14. meta: update AUTHORS

    PR-URL: #40485
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    b4f5127 View commit details
    Browse the repository at this point in the history
  15. build: fix actions pull request's branch

    PR-URL: #40494
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Qingyu Deng <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Mesteery authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    1743306 View commit details
    Browse the repository at this point in the history
  16. stream: support array of streams in promises pipeline

    Fixes: #40191
    
    PR-URL: #40193
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Mesteery authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    36d3b12 View commit details
    Browse the repository at this point in the history
  17. src: add missing inialization in agent.h

    This missing initialization was reported by the coverity scans
    we are in the process of re-enabling.
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #40379
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    mhdawson authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    143c881 View commit details
    Browse the repository at this point in the history
  18. test: split test-crypto-dh.js

    Split test-crypto-dh.js so that it is less likely to timeout on
    less powerful bots.
    
    PR-URL: #40451
    Refs: nodejs/reliability#86
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    joyeecheung authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    9227f2a View commit details
    Browse the repository at this point in the history
  19. doc: specify that maxFreeSockets is per host

    The `maxFreeSockets` option specifies the maximum number of free
    sockets per host.
    
    PR-URL: #40483
    Fixes: #40446
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    lpinca authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    7b74638 View commit details
    Browse the repository at this point in the history
  20. crypto: avoid double free

    Coverity scan reported a free after use and I think its
    right. Tweak to avoid double free.
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #40380
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    mhdawson authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    de125a5 View commit details
    Browse the repository at this point in the history
  21. test: fix test-datetime-change-notify after daylight change

    Add standard timezone name for Dublin without daylight saving
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    PiotrRybak authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    50c6666 View commit details
    Browse the repository at this point in the history
  22. test,tools: increase timeout for benchmark tests

    test-benchmark-buffer is consistently timing out on a single Windows
    host in CI. Rather than try to figure out if we need to scale the
    timeout up for a certain memory limit or chip speed or something else,
    let's increase the timeout for benchmark tests in general.
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    908f644 View commit details
    Browse the repository at this point in the history
  23. test,tools: increase pummel/benchmark test timeout from 4x to 6x

    The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on
    certain tests in pummel and (previously) benchmark. Increase timeout
    from 4x to 6x.
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    aef809f View commit details
    Browse the repository at this point in the history
  24. test: mark test-policy-integrity flaky on Windows

    Ref: #40694
    
    PR-URL: #40684
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    8226690 View commit details
    Browse the repository at this point in the history
  25. test: adjust CLI flags test to ignore blank lines in doc

    PR-URL: #40403
    Backport-PR-URL: #40530
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    6de88bc View commit details
    Browse the repository at this point in the history
  26. doc: format doc/api/*.md with markdown formatter

    PR-URL: #40403
    Backport-PR-URL: #40530
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    621266a View commit details
    Browse the repository at this point in the history
  27. tools: add support for import assertions in linter

    PR-URL: #39924
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Bradley Farias <[email protected]>
    Reviewed-By: Daijiro Wachi <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    aduh95 authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    abf3b84 View commit details
    Browse the repository at this point in the history
  28. lib,url: correct URL's argument to pass idlharness

    `url.idl` defines URL's constructor as:
    
    ```
    constructor(USVString url, optional USVString base);
    ```
    
    `idlharness.any.js` checks its length as `1`. So we should remove
    constructor's second argument and use `arguments[1]` in constructor's
    logic.
    
    Refs: https://url.spec.whatwg.org/#idl-index
    
    PR-URL: #39848
    Backport-PR-URL: #40383
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    XadillaX authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    0a8c331 View commit details
    Browse the repository at this point in the history
  29. test: pass URL's toascii.window.js WPT

    PR-URL: #39910
    Backport-PR-URL: #40383
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Nitzan Uziely <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Daijiro Wachi <[email protected]>
    XadillaX authored and targos committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    af4e682 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. src: register external references in crypto bindings

    PR-URL: #40239
    Refs: #38905
    Refs: #37476
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    7bb3d43 View commit details
    Browse the repository at this point in the history
  2. src: register external references in os bindings

    PR-URL: #40239
    Refs: #38905
    Refs: #37476
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    7a8a6de View commit details
    Browse the repository at this point in the history
  3. meta: consolidate AUTHORS entries for cxreg

    PR-URL: #40490
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Trott authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    6619206 View commit details
    Browse the repository at this point in the history
  4. test: fix test description

    The request uses chunked transfer encoding and the HTTP response status
    code is not 400 but 200.
    
    PR-URL: #40486
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    lpinca authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    e72c95c View commit details
    Browse the repository at this point in the history
  5. meta: consolidate AUTHORS entries for dguo

    PR-URL: #40517
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d09b823 View commit details
    Browse the repository at this point in the history
  6. meta: add Richard Lau to TSC list in README.md

    Refs: nodejs/TSC#1096
    
    PR-URL: #40523
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    d64cf17 View commit details
    Browse the repository at this point in the history
  7. doc: add updating expected assets to release guide

    Add a section to the Major Releases section of the release guide
    to cover updating the list of expected files for the promotion tool.
    
    PR-URL: #40470
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    richardlau authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    bf88328 View commit details
    Browse the repository at this point in the history
  8. src,fs: remove ToLocalChecked() call from fs::AfterMkdirp()

    This merges the `IsEmpty()` call and the `ToLocalChecked()` call into a
    single `ToLocal()` call.
    
    Signed-off-by: Darshan Sen <[email protected]>
    
    PR-URL: #40386
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    RaisinTen authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    4030eff View commit details
    Browse the repository at this point in the history
  9. src,crypto: remove AllocatedBuffer from crypto_cipher.cc

    Signed-off-by: Darshan Sen <[email protected]>
    
    PR-URL: #40400
    Reviewed-By: Anna Henningsen <[email protected]>
    RaisinTen authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    774bc46 View commit details
    Browse the repository at this point in the history
  10. typings: separate internalBinding typings

    PR-URL: #40409
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Qingyu Deng <[email protected]>
    Mesteery authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    63ab003 View commit details
    Browse the repository at this point in the history
  11. src,stream: remove *Check*() calls from non-Initialize() functions

    There is no need to crash the process if any of these checks fail.
    
    Signed-off-by: Darshan Sen <[email protected]>
    
    PR-URL: #40425
    Reviewed-By: Anna Henningsen <[email protected]>
    RaisinTen authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    3ac99a2 View commit details
    Browse the repository at this point in the history
  12. doc: clarify behavior of napi_extended_error_info

    Fix up example and make it more explicit on how
    you need to use napi_extended_error_info in order to
    help people avoid what might be a common mistake that
    we made in node-addon-api.
    
    Refs: nodejs/node-addon-api#1089
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #40458
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Darshan Sen <[email protected]>
    mhdawson authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    aa47c9f View commit details
    Browse the repository at this point in the history
  13. lib: fix regular expression to detect / and \

    Fixes #40305
    
    PR-URL: #40325
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Guy Bedford <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Zeyu Yang <[email protected]>
    fasttime authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    881dd7b View commit details
    Browse the repository at this point in the history
  14. meta: move one or more collaborators to emeritus

    PR-URL: #40464
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Danielle Adams <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Franziska Hinkelmann <[email protected]>
    Reviewed-By: Yihong Wang <[email protected]>
    nodejs-github-bot authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c021a7f View commit details
    Browse the repository at this point in the history
  15. doc: update link in onboarding doc

    PR-URL: #40539
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    b3a1276 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. deps: patch V8 to 9.4.146.24

    Refs: v8/v8@9.4.146.19...9.4.146.24
    
    PR-URL: #40616
    Refs: v8/v8@9.4.146.19...9.4.146.23
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    targos authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    76d1b5d View commit details
    Browse the repository at this point in the history
  2. Revert "doc: fix typo in stream docs"

    This reverts commit 1db2ffd.
    
    Fixes: #40818
    
    PR-URL: #40819
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Beth Griggs <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    lpinca authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    836fc27 View commit details
    Browse the repository at this point in the history
  3. deps: add riscv64 config into openssl gypi

    PR-URL: #40473
    Reviewed-By: Daniel Bevenius <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    luyahan authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    769336a View commit details
    Browse the repository at this point in the history
  4. doc: document considerations for inclusion in core

    Document the things that are considered when making the determination as
    to whether something should or shouldn't be in core. This does not (yet,
    at least) attempt to address *how* to include modules in core. (Should
    it be in the Node.js code base or vendored in from a separate
    repository?) It is limited to *whether* something should be in core or
    not.
    
    Closes: nodejs/TSC#1041
    
    PR-URL: #40338
    Fixes: nodejs/TSC#1041
    Reviewed-By: Robert Nagy <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    c029d0b View commit details
    Browse the repository at this point in the history
  5. doc: add VoltrexMaster to collaborators

    Fixes: #40323
    
    PR-URL: #40566
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    VoltrexKeyva authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    755c085 View commit details
    Browse the repository at this point in the history
  6. meta: consolidate AUTHORS entries for dfabulich

    PR-URL: #40527
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a5475df View commit details
    Browse the repository at this point in the history
  7. doc: fix entry for Slack channel in onboarding.md

    PR-URL: #40563
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    042f01e View commit details
    Browse the repository at this point in the history
  8. doc: explain backport labels

    PR-URL: #40520
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Qard authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    595117f View commit details
    Browse the repository at this point in the history
  9. doc: fix fs.symlink code example

    Fixes: #40413
    
    PR-URL: #40414
    Reviewed-By: Antoine du Hamel <[email protected]>
    juanarbol authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    dea7010 View commit details
    Browse the repository at this point in the history
  10. doc: use GFM footnotes in maintaining-V8.md (#40476)

    PR-URL: #40476
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    3b6cf09 View commit details
    Browse the repository at this point in the history
  11. deps: V8: cherry-pick 422dc378a1da

    Original commit message:
    
        [deserialization] Remove unnecessarily limit on buffer size
    
        1. Now there is no serializer/deserializer-specific buffer size limit.
        2. Update AUTHORS
    
        Ref: #40059
    
        Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411
        Reviewed-by: Jakob Kummerow <[email protected]>
        Reviewed-by: Clemens Backes <[email protected]>
        Commit-Queue: Jakob Kummerow <[email protected]>
        Cr-Commit-Position: refs/heads/main@{#77084}
    
    Refs: v8/v8@422dc37
    
    PR-URL: #40450
    Fixes: #40059
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    rayw000 authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    91c3cf5 View commit details
    Browse the repository at this point in the history
  12. src: throw error instead of assertion

    PR-URL: #40243
    Fixes: #40059
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    rayw000 authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    789fef1 View commit details
    Browse the repository at this point in the history
  13. doc: describe buffer limit of v8.serialize

    PR-URL: #40243
    Fixes: #40059
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    rayw000 authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    579f01c View commit details
    Browse the repository at this point in the history
  14. tty: support more CI services in getColorDepth

    PR-URL: #40385
    Refs: sindresorhus/yoctocolors#5
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Richienb authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7d550ad View commit details
    Browse the repository at this point in the history
  15. build: disable v8 pointer compression on 32bit archs

    PR-URL: #40418
    Reviewed-By: Jiawen Geng <[email protected]>
    Reviewed-By: Stewart X Addison <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    zcbenz authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    4581997 View commit details
    Browse the repository at this point in the history
  16. tools: udpate doc tools to accommodate GFM footnotes

    PR-URL: #40477
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    59de0f7 View commit details
    Browse the repository at this point in the history
  17. doc: use GFM footnotes in webcrypto.md

    PR-URL: #40477
    Reviewed-By: Antoine du Hamel <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9fcfef0 View commit details
    Browse the repository at this point in the history
  18. deps: upgrade npm to 8.1.1

    PR-URL: #40554
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    npm-robot authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    76e2c37 View commit details
    Browse the repository at this point in the history
  19. meta: update AUTHORS

    PR-URL: #40580
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Nitzan Uziely <[email protected]>
    nodejs-github-bot authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7590bac View commit details
    Browse the repository at this point in the history
  20. doc: improve async_context introduction

    - Rename "Async_context" to "Asynchronous context tracking" in toc.
    - Use named imports to show how `AsyncLocalStorage` and `AsyncResource`
      can be imported.
    
    PR-URL: #40560
    Reviewed-By: Vladimir de Turckheim <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Gerhard Stöbich <[email protected]>
    targos authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    2d4a042 View commit details
    Browse the repository at this point in the history
  21. doc: fix macOS environment variables for ccache

    macOS requires `cc` and `c++` rather than `gcc` and `g++`.
    
    Closes: #40542
    
    PR-URL: #40550
    Fixes: #40542
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    5593dd1 View commit details
    Browse the repository at this point in the history
  22. doc: simplify ccache instructions

    `ccache` has reasonable defaults for `max_size` and `cache_dir` so
    remove instructions to set those things explicitly.
    
    Change fenced code from `console` to `bash` for easier copy/paste.
    
    PR-URL: #40550
    Fixes: #40542
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0a7c4ff View commit details
    Browse the repository at this point in the history
  23. meta: consolidate AUTHORS entries for darai0512

    PR-URL: #40569
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0003cb6 View commit details
    Browse the repository at this point in the history
  24. doc: update onboarding task

    Make starting Jenkins CI optional.
    
    PR-URL: #40570
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Gireesh Punathil <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7c7f879 View commit details
    Browse the repository at this point in the history
  25. build: skip long-running Actions for README-only modifications

    If the only file modified is README.md do not run test-linux or
    build-windows tasks. This will help streamline onboarding sessions but
    may help some other cases too.
    
    PR-URL: #40571
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    2700909 View commit details
    Browse the repository at this point in the history
  26. policy: fix message for invalid manifest specifier

    Add test for invalid manifest specifier and fix the error message
    which is missing a space ("singletrailing" instead of
    "single trailing").
    
    PR-URL: #40574
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Zijian Liu <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Bradley Farias <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Trott authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    dab574e View commit details
    Browse the repository at this point in the history
  27. dgram: fix send with out of bounds offset + length

    fix Socket.prototype.send sending garbage when the message is a string,
    or Buffer and offset+length is out of bounds.
    
    Fixes: #40491
    
    PR-URL: #40568
    Reviewed-By: Benjamin Gruenbaum <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Linkgoron authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    23d11a1 View commit details
    Browse the repository at this point in the history
  28. doc: fix typo in changelogs

    Fix typo in v12.22.7, v14.18.1, and v16.11.1 changelogs.
    
    PR-URL: #40585
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    lpinca authored and BethGriggs committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    d38077b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. meta: consolidate AUTHORS entries for clakech

    PR-URL: #40589
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Nitzan Uziely <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7b1c89f View commit details
    Browse the repository at this point in the history
  2. meta: move Fishrock123 to emeritus

    I've moved on. I do not wish to be responsible for anything here and
    have been inactive for more than a year.
    
    PR-URL: #40596
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Nitzan Uziely <[email protected]>
    Fishrock123 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    97aa8e4 View commit details
    Browse the repository at this point in the history
  3. doc: add info on project's usage of coverity

    Document project's used of coverity and how
    collaborators can get access.
    
    Signed-off-by: Michael Dawson <[email protected]>
    
    PR-URL: #40506
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    mhdawson authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e2114e2 View commit details
    Browse the repository at this point in the history
  4. tools: fix formatting of warning message in update-authors.js

    The email already has `<` and `>` surrounding it so adding it results in
    a misformatted message.
    
    PR-URL: #40600
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    8648e50 View commit details
    Browse the repository at this point in the history
  5. tools: update ESLint to 8.1.0

    PR-URL: #40582
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    lpinca authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    2a53995 View commit details
    Browse the repository at this point in the history
  6. doc: remove unused imports

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    dnalborczyk authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d732ff4 View commit details
    Browse the repository at this point in the history
  7. doc: call cwd function

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    dnalborczyk authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    d72fb7d View commit details
    Browse the repository at this point in the history
  8. doc: add node: url scheme

    PR-URL: #40573
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    dnalborczyk authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7a6e833 View commit details
    Browse the repository at this point in the history
  9. doc: use 'GitHub Actions workflow' instead

    PR-URL: #40586
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Mesteery authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    eea061f View commit details
    Browse the repository at this point in the history
  10. typings: improve internal bindings typings

    PR-URL: #40411
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Mesteery authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    fbe0323 View commit details
    Browse the repository at this point in the history
  11. meta: consolidate AUTHORS entries for Azard

    PR-URL: #40619
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    9e12ed4 View commit details
    Browse the repository at this point in the history
  12. meta: consolidate AUTHORS entries for alexzherdev

    PR-URL: #40620
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    7230b6d View commit details
    Browse the repository at this point in the history
  13. test: use conventional argument order in assertion

    PR-URL: #40591
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Trivikram Kamat <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    b9533c5 View commit details
    Browse the repository at this point in the history
  14. src: fix #endif description in crypto_keygen.h

    PR-URL: #40639
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tniessen authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    59c26a2 View commit details
    Browse the repository at this point in the history
  15. doc: fix markdown syntax and HTML tag misses

    PR-URL: #40608
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    AliasT authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    3cb74d7 View commit details
    Browse the repository at this point in the history
  16. doc: update tracking issues of startup performance

    The issues listed in the doc have been closed, and a new one is
    currently being used to track snapshot integration.
    
    PR-URL: #40629
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Ruben Bridgewater <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    joyeecheung authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    befac5d View commit details
    Browse the repository at this point in the history
  17. meta: consolidate AUTHORS entries for brettkiefer

    PR-URL: #40599
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    ef46cb4 View commit details
    Browse the repository at this point in the history
  18. test: test crypto.setEngine() using an actual engine

    Signed-off-by: Darshan Sen <[email protected]>
    
    PR-URL: #40481
    Reviewed-By: James M Snell <[email protected]>
    RaisinTen authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f778fa2 View commit details
    Browse the repository at this point in the history
  19. src: remove usage of AllocatedBuffer from node_http2

    Signed-off-by: Darshan Sen <[email protected]>
    
    PR-URL: #40584
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    RaisinTen authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    2c8a6ec View commit details
    Browse the repository at this point in the history
  20. tools: avoid fetch extra commits when validating commit messages

    PR-URL: #39128
    Reviewed-By: Mary Marchini <[email protected]>
    aduh95 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    b4a80db View commit details
    Browse the repository at this point in the history
  21. typings: add JSDoc typings for inspector

    Added JSDoc typings for the `inspector` lib module.
    
    PR-URL: #38390
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Adrian Estrada <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    VoltrexKeyva authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    67c7d11 View commit details
    Browse the repository at this point in the history
  22. doc: remove --experimental-modules documentation

    PR-URL: #38974
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    iam-frankqiu authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    de5c5c8 View commit details
    Browse the repository at this point in the history
  23. typings: add more bindings typings

    PR-URL: #40415
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Mesteery authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    cdea5b6 View commit details
    Browse the repository at this point in the history
  24. tools,meta: remove exclusions from AUTHORS

    The update-authors tool omits Chromium team members. This was a decision
    made years ago. The idea was that these folks contributed to V8 not to
    Node.js, as they typically ended up in our code-base via cherry-picked
    commits from V8.
    Ref: #232 (diff)
    
    Now that there are over 3000 contributors identified in AUTHORS, some of
    whom are bots that we run, I think it's time to undo this exception. If
    we used someone else's code in a cherry-pick, congratulations to them,
    they're authors. In particular, this will fix the omission of Yang
    Guo who contributed extensively to Node.js outside of V8 contributions.
    
    PR-URL: #40648
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f45814b View commit details
    Browse the repository at this point in the history
  25. tools: fix commit-lint workflow

    PR-URL: #40673
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    aduh95 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    dd08e53 View commit details
    Browse the repository at this point in the history
  26. tools: abort CQ session when landing several commits

    Most PRs are meant to be squashed in one commit when landing. If the
    collaborator hasn't been using `fixup!` commits, the CQ lands the PR
    as several commits. This change makes the CQ abort by default
    when attempting to land several commits, unless there's another
    label added to the PR to force squashing or landing as several commits.
    
    Fixes: #40436
    Refs: nodejs/node-core-utils#572
    
    PR-URL: #40577
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    aduh95 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c12ce89 View commit details
    Browse the repository at this point in the history
  27. test,doc: correct documentation for runBenchmark()

    The function only takes two arguments.
    
    PR-URL: #40683
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Trott authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c593cff View commit details
    Browse the repository at this point in the history
  28. meta: update AUTHORS

    PR-URL: #40668
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    nodejs-github-bot authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    55ff973 View commit details
    Browse the repository at this point in the history
  29. tools: add script to update c-ares

    Add a script to automate updating of the c-ares dependency and
    accompanying maintenance guide.
    
    PR-URL: #40660
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    richardlau authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    adde2a7 View commit details
    Browse the repository at this point in the history
  30. deps: update c-ares to 1.18.1

    Updated as described in doc/guides/maintaining-c-ares.md.
    
    PR-URL: #40660
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    richardlau authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    a901b6c View commit details
    Browse the repository at this point in the history
  31. deps: upgrade npm to 8.1.2

    PR-URL: #40643
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    npm-robot authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    c14eb23 View commit details
    Browse the repository at this point in the history
  32. doc: update cjs-module-lexer repo link

    PR-URL: #40707
    Reviewed-By: Richard Lau <[email protected]>
    Reviewed-By: Jan Krems <[email protected]>
    Reviewed-By: Derek Lewis <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    guybedford authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    45bdc77 View commit details
    Browse the repository at this point in the history
  33. tools: fix bug in prefer-primordials ESLint rule

    Refs: #40622
    
    PR-URL: #40628
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    aduh95 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    48a785e View commit details
    Browse the repository at this point in the history
  34. test: deflake http2-cancel-while-client-reading

    Add missing `'error'` event handler.
    
    Fixes: #40610
    
    PR-URL: #40659
    Reviewed-By: Matteo Collina <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    lpinca authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    f114e35 View commit details
    Browse the repository at this point in the history
  35. test: add semicolon after chunk size

    The ABNF for chunk extensions as per RFC 7230 is
    
        chunk-ext      = *( ";" chunk-ext-name [ "=" chunk-ext-val ] )
    
        chunk-ext-name = token
        chunk-ext-val  = token / quoted-string
    
    Add a semicolon after the chunk size for clarity.
    
    This does not invalidate the test as it verifies that the HTTP parser
    does not ignore chunk extensions.
    
    PR-URL: #40487
    Refs: https://grenfeldt.dev/2021/10/08/gunicorn-20.1.0-public-disclosure-of-request-smuggling
    Reviewed-By: James M Snell <[email protected]>
    lpinca authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    3d50997 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    18800de View commit details
    Browse the repository at this point in the history
  37. tools: update ESLint to 8.2.0

    PR-URL: #40734
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    lpinca authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    1c8590e View commit details
    Browse the repository at this point in the history
  38. process: refactor execution

    • Removed unreachable code of the `evalModule()` function as an early
    error is thrown when the `print` parameter is a truthy value.
    • Make use of the nullish coalescing operator.
    
    PR-URL: #40664
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Minwoo Jung <[email protected]>
    VoltrexKeyva authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    58de6ce View commit details
    Browse the repository at this point in the history
  39. tools: ensure the PR was not pushed before merging

    When using Squash and Merge feature, it would allow to a malicious
    actor to push unreviewed code to their PR while the CQ is running and
    bypass the usual checks.
    This commit adds a check to refuse to land if the head of the PR
    branch is different from the one validated by ncu.
    
    PR-URL: #40747
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    aduh95 authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    cba8eaf View commit details
    Browse the repository at this point in the history
  40. tools: simplify and fix commit queue

    Use `gh` CLI for CI and commit queue jobs, and use the correct token
    to merge PRs.
    
    PR-URL: #40742
    Reviewed-By: Antoine du Hamel <[email protected]>
    Reviewed-By: Voltrex <[email protected]>
    targos authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    64c6575 View commit details
    Browse the repository at this point in the history
  41. src: make LoadEnvironment with string work with builtin modules path

    Fixes: #40605
    
    PR-URL: #40607
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    targos authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    bc0eb0a View commit details
    Browse the repository at this point in the history
  42. test: skip macos sandbox test with builtin modules path

    Refs: #40605
    
    PR-URL: #40607
    Reviewed-By: Geoffrey Booth <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    targos authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    63b44fc View commit details
    Browse the repository at this point in the history
  43. meta: use form schema for flaky test template

    PR-URL: #40737
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    targos authored and BethGriggs committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    480f0e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. test: deflake child-process-pipe-dataflow

    Fixes: #25988
    
    PR-URL: #40838
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Tobias Nießen <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    lpinca authored and BethGriggs committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    01ffe03 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. 2021-12-01, Version 16.13.1 'Gallium' (LTS)

    Notable changes:
    
    - **deps**: upgrade npm to 8.1.2 (npm team)
      [#40643](#40643)
    - **deps**: update c-ares to 1.18.1 (Richard Lau)
      [#40660](#40660)
    - **doc**: add VoltrexMaster to collaborators (voltrexmaster)
      [#40566](#40566)
    - **lib**: fix regular expression to detect \`/\` and \`\\\`
      (Francesco Trotta) [#40325](#40325)
    
    PR-URL: #40974
    BethGriggs committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    12029ce View commit details
    Browse the repository at this point in the history