Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: ensure V8 initialized before marking milestone #40405

Closed
wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Refs:

When Node.js is started within Electron's environment it doesn't initialize V8, so V8's start time is never set. As a result, Electron logs V8's start time as 0 and it breaks timestamps in the trace log.

This change fixes the issue by adding logic to log V8's start time only when V8 is initialized by Node.js.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 11, 2021
@Mesteery Mesteery added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Oct 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2021
@nodejs-github-bot
Copy link
Collaborator

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2021

if (per_process::v8_initialized) {
performance_state_->Mark(performance::NODE_PERFORMANCE_MILESTONE_V8_START,
performance::performance_v8_start);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
performance::performance_v8_start);
performance::performance_v8_start);

nit: we can align these vertically

@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

Landed in ad4e70c

@codebytere codebytere closed this Oct 15, 2021
codebytere added a commit that referenced this pull request Oct 15, 2021
PR-URL: #40405
Refs: electron/electron#31349
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@codebytere codebytere deleted the add-v8-init-check branch October 15, 2021 14:49
targos pushed a commit that referenced this pull request Nov 4, 2021
PR-URL: #40405
Refs: electron/electron#31349
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants