update link in onboarding doc #40539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
|
s/onbaording/onboarding/ in commit message |
J-Human
approved these changes
Oct 21, 2021
benjamingr
approved these changes
Oct 21, 2021
richardlau
approved these changes
Oct 21, 2021
richardlau
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40539 ✔ Done loading data for nodejs/node/pull/40539 ----------------------------------- PR info ------------------------------------ Title update link in onboarding doc (#40539) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:master Labels doc, fast-track Commits 1 - doc: update link in onboarding doc Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40539 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40539 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Richard Lau -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Oct 2021 02:01:29 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1367452046 |
cjihrig
approved these changes
Oct 21, 2021
tniessen
approved these changes
Oct 21, 2021
Mesteery
added
the
author ready
lpinca
approved these changes
Oct 21, 2021
Trott
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40539 ✔ Done loading data for nodejs/node/pull/40539 ----------------------------------- PR info ------------------------------------ Title update link in onboarding doc (#40539) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:master Labels doc, fast-track, author ready Commits 1 - doc: update link in onboarding doc Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40539 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40539 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Oct 2021 02:01:29 GMT ✔ Approvals: 5 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785826483 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785858072 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40539#pullrequestreview-786091650 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1369553323 |
PR-URL: #40539 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Trott
force-pushed
the
Trott-patch-1
branch
2 times, most recently
from
7853180
to
0d59d0d
Compare
|
Landed in 0d59d0d |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
PR-URL: #40539 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 23, 2021
PR-URL: #40539 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.