lib,url: correct URL's argument to pass idlharness #39848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
I'd prefer to use a default value: |
XadillaX
force-pushed
the
url-idlharness
branch
from
229377b
to
b0bf274
Compare
targos
reviewed
Aug 23, 2021
bricss
reviewed
Aug 23, 2021
tniessen
approved these changes
Aug 23, 2021
XadillaX
force-pushed
the
url-idlharness
branch
from
b0bf274
to
66def25
Compare
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index
XadillaX
force-pushed
the
url-idlharness
branch
from
66def25
to
482fc50
Compare
jasnell
approved these changes
Aug 24, 2021
XadillaX
added a commit
that referenced
this pull request
Aug 26, 2021
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: #39848 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 48655e1 |
|
This depends on the semver-major #39176. Would you like to backport? |
targos
pushed a commit
to targos/node
that referenced
this pull request
Oct 9, 2021
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: nodejs#39848 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
2 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: #39848 Backport-PR-URL: #40383 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.idldefines URL's constructor as:idlharness.any.jschecks its length as1. So we should removeconstructor's second argument and use
arguments[1]in constructor'slogic.
Refs: https://url.spec.whatwg.org/#idl-index