Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more collaborators to emeritus #40464

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Oct 15, 2021
@Trott
Copy link
Member

Trott commented Oct 15, 2021

Our governance process is such that someone needs to either agree to be moved to emeritus or else the TSC has to act to move them to emeritus.

@yhwang Are you OK being moved to emeritus at this time?

@Trott Trott added blocked PRs that are blocked by other issues or PRs. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Oct 15, 2021
@Trott
Copy link
Member

Trott commented Oct 15, 2021

Adding blocked and tsc-agenda labels. They can both be removed if yhwang approves the change.

@tniessen
Copy link
Member

How did the second commit get here? GitHub marks it as "first-time contributor" and wants approval to run workflows. And then there is #40498 which appears to be a duplicate of this PR.

@targos
Copy link
Member

targos commented Oct 18, 2021

The second commit is here because we have two different workflows that use the same branch name. See #40494
#40498 looks like spam or a mistake made by a new user.

@Trott
Copy link
Member

Trott commented Oct 19, 2021

I approve both commits. :-D

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for openssl seems to just remove all of the licencing details. That seems wrong.

@Trott
Copy link
Member

Trott commented Oct 20, 2021

The change for openssl seems to just remove all of the licencing details. That seems wrong.

Ah, license-builder.sh needs an update. Coming in a few minutes, I think....

@Trott Trott force-pushed the create-or-update-pull-request-action branch from 21775af to b886343 Compare October 20, 2021 16:28
@Trott
Copy link
Member

Trott commented Oct 20, 2021

@mhdawson License update corrected. PTAL.

@Trott Trott force-pushed the create-or-update-pull-request-action branch from b886343 to 69064fd Compare October 20, 2021 16:31
@Trott
Copy link
Member

Trott commented Oct 20, 2021

@yhwang Are you OK being moved to emeritus at this time?

@nodejs/tsc We've gotten no response so it looks like we're going to need TSC approval to remove @yhwang as a collaborator. Please approve (or block) this PR. Thanks!

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README changes LGTM.

@richardlau
Copy link
Member

I think the openssl license updates should be separated -- they would make the PR need dont-land-on labels to prevent landing on the release lines that still contain openssl 1.1.1.

@mhdawson
Copy link
Member

The README changes LGTM, but agree the change to the licence should be broken out into its own PR.

@Trott
Copy link
Member

Trott commented Oct 21, 2021

Fine, be all reasonable. I'll move the license change to a separate PR and then remove it from here.

@Trott Trott force-pushed the create-or-update-pull-request-action branch from 69064fd to a993e99 Compare October 21, 2021 04:23
@Trott
Copy link
Member

Trott commented Oct 21, 2021

License stuff moved to #40540. This PR is now just the automated collaborator change.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhwang
Copy link
Member

yhwang commented Oct 22, 2021

sorry for the late response, I'm good with the move.

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Oct 22, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40464
✔  Done loading data for nodejs/node/pull/40464
----------------------------------- PR info ------------------------------------
Title      meta: move one or more collaborators to emeritus (#40464)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:create-or-update-pull-request-action -> nodejs:master
Labels     doc, meta, tsc-agenda
Commits    1
 - meta: move one or more collaborators to emeritus
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40464
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Danielle Adams 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Beth Griggs 
Reviewed-By: Myles Borins 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Yihong Wang 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40464
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Danielle Adams 
Reviewed-By: Richard Lau 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Beth Griggs 
Reviewed-By: Myles Borins 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Yihong Wang 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Oct 2021 04:12:13 GMT
   ✔  Approvals: 12
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780811991
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-780820059
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-785699421
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784747905
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-784875981
   ✔  - Danielle Adams (@danielleadams) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199342
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786199444
   ✔  - Сковорода Никита Андреевич (@ChALkeR) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206079
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786206332
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786210296
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/40464#pullrequestreview-786320852
   ✔  - Yihong Wang (@yhwang): https://github.com/nodejs/node/pull/40464#pullrequestreview-786347207
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1370508576

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2021
PR-URL: #40464
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yihong Wang <[email protected]>
@Trott Trott force-pushed the create-or-update-pull-request-action branch from a993e99 to 32e2a6f Compare October 22, 2021 05:05
@Trott
Copy link
Member

Trott commented Oct 22, 2021

Landed in 32e2a6f

@Trott Trott merged commit 32e2a6f into master Oct 22, 2021
@Trott Trott deleted the create-or-update-pull-request-action branch October 22, 2021 05:06
targos pushed a commit that referenced this pull request Oct 23, 2021
PR-URL: #40464
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yihong Wang <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
PR-URL: #40464
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yihong Wang <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tsc-agenda Issues and PRs to discuss during the meetings of the TSC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.