-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream.promises.pipeline doesn't support arrays of streams since node 16.10 #40191
Labels
Comments
Mesteery
added a commit
to Mesteery/node
that referenced
this issue
Sep 23, 2021
targos
pushed a commit
that referenced
this issue
Oct 20, 2021
Fixes: #40191 PR-URL: #40193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
kirillgroshkov
added a commit
to NaturalCycles/nodejs-lib
that referenced
this issue
Oct 26, 2021
targos
pushed a commit
that referenced
this issue
Nov 4, 2021
Fixes: #40191 PR-URL: #40193 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 21, 2022
JustinGrote
added a commit
to pester/vscode-adapter
that referenced
this issue
Jul 5, 2023
nodejs/node#40191 was resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
v16.10.0
Platform
5.8.0-63-generic #71-Ubuntu SMP Tue Jul 13 15:59:12 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Subsystem
stream/promises
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
Always in 16.10, never in 16.9
What is the expected behavior?
It should output:
What do you see instead?
Additional information
Starting with node 16.10, the promise version of
pipeline
doesn't handle this signature:pipeline(streams)
, wherestreams
is<Stream[]> | <Iterable[]> | <AsyncIterable[]> | <Function[]>
according to the documentation.I think the problem is related with the introduction of the
signal
parameter, possibly with this change: 97f3072ceb#diff-241fa22640048b6a147dec92f1ebf253043a1c4c342c7e52402112eb3c58f8fbL35The callback version of
stream.pipeline
is not affected.Related PR :
The text was updated successfully, but these errors were encountered: