Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v11.1.0 #23922

Merged
merged 84 commits into from
Nov 2, 2018
Merged

Release proposal: v11.1.0 #23922

merged 84 commits into from
Nov 2, 2018

Conversation

targos
Copy link
Member

@targos targos commented Oct 27, 2018

2018-11-02, Version 11.1.0 (Current), @targos

Notable changes

  • deps
  • repl
    • Top-level for-await-of is now supported in the REPL. #23841
  • timers
    • Fixed an issue that could cause timers to enter an infinite loop. #23870

Commits

  • [2c2e2b53ab] - benchmark: fix bench-mkdirp to use recursive option (Klaus Meinhardt) #23699
  • [787e13b41c] - build: expose more openssl categories for addons (Jonathan Cardoso Machado) #23344
  • [b8f3bb107e] - build: add lint-py which uses flake8 (cclauss) #21952
  • [35c3c4ba68] - build: allow for overwriting of use_openssl_def (Shelley Vohr) #23763
  • [5c35d0db47] - build,meta: switch to gcc-4.9 on travis (Refael Ackermann) #23778
  • [141aec9564] - crypto: add SET_INTEGER_CONSANT macro (Daniel Bevenius) #23687
  • [4112a10abe] - crypto: strip unwanted space from openssl version (Sam Roberts) #23678
  • [2cc4f5c923] - deps: patch V8 to 7.0.276.32 (Michaël Zasso) #23851
  • [0312d8b2cd] - deps: fix shim for v8::Value::IntegerValue() (Anna Henningsen) #23898
  • [9011db426e] - (SEMVER-MINOR) deps: move more deprecations to V8_DEPRECATED (Anna Henningsen) #23414
  • [e5b51cc496] - (SEMVER-MINOR) deps: icu 63.1 bump (CLDR 34) (Steven R. Loomis) #23715
  • [ab58439916] - deps: icu: apply workaround patch (Steven R. Loomis) #23764
  • [3b66a8d893] - deps: fix wrong default for v8 handle zapping (Refael Ackermann) #23801
  • [26510fbd8e] - doc: add branding to style guide (Rich Trott) #23967
  • [33053ec8d7] - doc: use Node.js instead of Node (Rich Trott) #23967
  • [ec009f620c] - doc: revise BUILDING.md (Rich Trott) #23966
  • [da494ef889] - doc: clarify fd behaviour with {read,write}File (Sakthipriyan Vairamani (thefourtheye)) #23706
  • [539e1233b0] - doc: moved test instructions to BUILDING.md (Kamat, Trivikram) #23949
  • [cc65fee1d3] - doc: fix typographical issues (Denis McDonald) #23970
  • [ee6b0395f5] - doc: sort markdown refs in errors (Sam Roberts) #23972
  • [ee299c7ef1] - doc: remove "idiomatic choice" from queueMicrotask (Rod Vagg) #23885
  • [147e5d5792] - doc: document HPE_HEADER_OVERFLOW error (Sam Roberts) #23963
  • [24c6a02930] - doc: add documentation for http.IncomingMessage$complete (James M Snell) #23914
  • [82ee6c3e47] - doc: remove mailing list (Rich Trott) #23932
  • [99fffff6e0] - doc: remove notice of dashes in V8 options (Denys Otrishko) #23903
  • [8b5339da14] - doc: rename README section for Release Keys (Rich Trott) #23927
  • [676875195b] - doc: add note about ABI compatibility (Myles Borins) #22237
  • [f01a806276] - doc: add optional callback to socket.end() (Ajido) #23937
  • [64c205d9bc] - doc: make example more clarified in cluster.md (ZYSzys) #23931
  • [748dbf9778] - doc: simplify valid security issue descriptions (Rich Trott) #23881
  • [e241398ef6] - doc: simplify path.basename() on POSIX and Windows (ZYSzys) #23864
  • [49b32af5ab] - doc: document nullptr comparisons in style guide (Anna Henningsen) #23805
  • [0ba49fec12] - doc: remove problematic example from README (Rich Trott) #23817
  • [d808d27120] - doc: use Cookie in request.setHeader() examples (Luigi Pinca) #23707
  • [1baba9b061] - doc: NODE_EXTRA_CA_CERTS is ignored if setuid root (Ben Noordhuis) #23770
  • [dd5afbe05f] - doc: add review suggestions to require() (erickwendel) #23605
  • [db113a24e0] - doc: document and warn if the ICU version is too old (Steven R. Loomis) #23766
  • [c30de85ca5] - doc: move @phillipj to emeriti (Phillip Johnsen) #23790
  • [84fdb1cc0e] - doc: add note about removeListener order (James M Snell) #23762
  • [f4c4b2b41b] - doc: document ACL limitation for fs.access on Windows (James M Snell) #23772
  • [83b776c864] - doc: document that addMembership must be called once in a cluster (James M Snell) #23746
  • [1851cf4f83] - doc, test: document and test vm timeout escapes (James M Snell) #23743
  • [b4b101fed6] - (SEMVER-MINOR) fs: default open/openSync flags argument to 'r' (Ben Noordhuis) #23767
  • [1c5ffb3ec5] - (SEMVER-MINOR) lib: add escapeCodeTimeout as an option to createInterface (Raoof) #19780
  • [1cda41b7da] - lib: migrate from process.binding('config') to getOptions() (Vladimir Ilic) #23588
  • [22cd53791a] - lib: trigger uncaught exception handler for microtasks (Gus Caplan) #23794
  • [97496f0fd9] - n-api: make per-Context-ness of napi\_env explicit (Anna Henningsen) #23689
  • [3e512f1897] - os: fix memory leak in userInfo() (Anna Henningsen) #23893
  • [02f13abde3] - repl: support top-level for-await-of (Shelley Vohr) #23841
  • [86cf01404c] - repl: migrate from process.binding('config') to getOptions() (Jose Bucio) #23684
  • [4a79b2568f] - src: improve StreamBase write throughput (Anna Henningsen) #23843
  • [dcaf72311b] - src: minor refactor to node_errors.h (Anna Henningsen) #23879
  • [fef17b716d] - src: avoid extra Persistent in DefaultTriggerAsyncIdScope (Anna Henningsen) #23844
  • [ce106df728] - src: use maybe version v8::Function::Call (Ouyang Yadong) #23826
  • [1bdbf8765d] - src: reduce duplication in tcp_wrap Connect (Daniel Bevenius) #23753
  • [9fbe91a061] - src: refactor deprecated v8::String::NewFromTwoByte call (Romain Lanz) #23803
  • [48ed81fad2] - src: improve StreamBase read throughput (Anna Henningsen) #23797
  • [a6fe2caaae] - src: simplify TimerFunctionCall() in node\_perf.cc (Anna Henningsen) #23782
  • [30be5cbdb0] - src: memory management using smart pointer (Uttam Pawar) #23628
  • [df05ddfd72] - src: refactor deprecated v8::Function::Call call (Romain Lanz) #23804
  • [7bbc072529] - stream: do not error async iterators on destroy(null) (Matteo Collina) #23901
  • [5ce3b6d7a4] - stream: ended streams should resolve the async iteration (Matteo Collina) #23901
  • [aaddf97d9b] - stream: async iteration should work with destroyed stream (Matteo Collina) #23785
  • [871e32789a] - test: fixed error message in test-buffer-read (Arvind Pandey) #23957
  • [ed10a91e83] - test: add test-benchmark-http2 (Rich Trott) #23863
  • [22bbece323] - test: fix regression when compiled with FIPS (Adam Majer) #23871
  • [22caa26c69] - test: fix strictEqual() argument order (Loic) #23829
  • [572ea60378] - test: verify performance.timerify() works w/ non-Node Contexts (Anna Henningsen) #23784
  • [0f00ac9c7a] - test: mark test-vm-timeout-* known issue tests flaky (James M Snell) #23743
  • [a80452a1ab] - test: add test-benchmark-napi (Emily Marigold Klassen) #23585
  • [086ee5e57f] - test: increase coverage of internal/stream/end-of-stream (Tyler Vann-Campbell) #23751
  • [ee8fa528e2] - test: fix strictEqual() arguments order (Nolan Rigo) #23800
  • [83ddd3e7d0] - test: fix flaky test (cjihrig) #23811
  • [1521d8991d] - test: fix invalid modulesLength for DSA keygen (Adam Majer) #23732
  • [dfecf85ded] - test: fix test-require-symlink on Windows (Bartosz Sosnowski) #23691
  • [ddd9ccf1d8] - test: fix strictEqual() argument order (Romain Lanz) #23768
  • [a666d3ea24] - test: fix strictEqual() arguments order (Thomas GENTILHOMME) #23771
  • [fa1373fc74] - test: fix assertion arguments order (Elian Gutierrez) #23787
  • [167e99b9a1] - timers: fix priority queue removeAt fn (Anatoli Papirovski) #23870
  • [09f25af16f] - tls: throw if protocol too long (Andre Jodat-Danbrani) #23606
  • [45a20a8d78] - tools: update ESLint to 5.8.0 (cjihrig) #23904
  • [c20eb4f2bd] - (SEMVER-MINOR) tools, icu: actually failover if there are multiple URLs (Steven R. Loomis) #23715
  • [b07cb4810c] - zlib: do not leak on destroy (Mathias Buus) #23734

Aiden01 and others added 30 commits October 24, 2018 16:10
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #23684
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Remove trailing " \n" from `process.versions.openssl`.

d3d6cd3 was incorrectly printing this trailer, but because the
target buffer size was claimed to be the length of the version string,
the trailer was truncated off.

9ed4646 corrected the target buffer size, but then the trailer
started to appear in process.versions.

Added a test to check for regressions.

PR-URL: #23678
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
PR-URL: #23771
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #23768
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #23801
Fixes: #23796
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Creating directory symlinks on Windows require 'dir' parameter to be
provided.

Fixes: #23596

PR-URL: #23691
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #23734
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #23794
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Fixes: #19192

PR-URL: #23772
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Bartosz Sosnowski <[email protected]>
Fixes: #21635

PR-URL: #23762
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
ICU 62.1 had a bug where certain orders of operations would not
work with the minimum significant digit setting. Fixed in
ICU 63.1. Applied the following patch from v8.

https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1128503

ICU Bug:
https://unicode-org.atlassian.net/browse/ICU-20063

Fixes: #22156

PR-URL: #23764
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Introduced use of smart pointers instead of MallocedBuffer to manage
memory allocated in the cares library.

PR-URL: #23628
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Picking a path according to a boolean is essentially free,
compared to the cost of a function call. Also, remove an
unnecessary `TryCatch`.

PR-URL: #23782
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
During key generation, the default dsa_builtin_paramgen will reset
modulusLength to 512. But in dsa_builtin_paramgen2 this does not
happen, leading to lockup in FIPS mode.

PR-URL: #23732
Refs: #23430
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
This commit introduces a SET_INTEGER_CONSANT macro to reduce some code
duplication in SecureContext::Initialize.

PR-URL: #23687
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This commit fixes test-tls-set-secure-context.js. The test was
making one long lasting HTTP connection, followed by a number of
shorter lived connections. However, it was possible that the
connections were not received in the desired order. This commit
ensures that the long lasting connection is established before
making any other connections.

PR-URL: #23811
Fixes: #23807
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #23605
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
The convertProtocols() function now throws a range error when the byte
length of a protocol is too long to fit in a Buffer.

Also added a test case in test/parallel/test-tls-basic-validations.js
to cover this.

PR-URL: #23606
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
PR-URL: #23588
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Improve performance by providing JS with the raw ingridients
for the read data, i.e. an `ArrayBuffer` + offset + length
fields, instead of creating `Buffer` instances in C++ land.

PR-URL: #23797
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #23803
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #23800
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Fixes: #22081

PR-URL: #23770
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
This change adds test cases to call the function returned by
end-of-stream and asserts that callbacks are not called when
the stream is ended, or prematurely closed.

PR-URL: #23751
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
`Set-Cookie` is a response header, replace it with `Cookie`.

PR-URL: #23707
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins and others added 17 commits November 1, 2018 21:51
Building node against versions of the dependencies that differ from the
ones we vendor will result in a non ABI compatible version of Node.js

This patch adds a note to make it explicit that if individuals build
node against different versions of a dependency they should make a
custom NODE_MODULE_VERSION.

PR-URL: #22237
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
The section of the README currently labeled "Release Team" isn't about
the team much and is very much about the keys. Rename it "Release Keys"
so that it's purpose matches it's name.

PR-URL: #23927
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Previously only V8 options supported both dashes in them (making them
equivalent), but now Node.js also supports both styles so the note can
be removed.

PR-URL: #23903
Refs: #18592
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: George Adams <[email protected]>
We removed the mailing list from the README and other places quite some
time ago. Core devs don't monitor it much. However, it is still linked
in a couple places in the docs directory. Remove those links.

PR-URL: #23932
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #8102

PR-URL: #23914
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #23963
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
It can't be idiomatic if it's not in general use and therefore hasn't
been picked up by users. It's not even in browsers yet.

"Idiomatic" use is an emergent property that comes from observed use
and this feature is so new (to browsers and Node) that it can't
possibly be. In general I don't think it's the place of the Node API
docs to observe what emerges as idiomatic Node.js.

It also can't be a recommended feature (if that was the intent of the
language) because it's marked experimental. For now, it's just a
feature, nothing more. Recommendations and/or observations about it
being 'idiomatic' can come later.

PR-URL: #23885
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #23972
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #23970
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This previously leaked memory in the ‘success’ case.

PR-URL: #23893
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fixes: #23491

Duplicate test instructions were present in pull-requests.md
Merged the instructions in BUILDING.md and provided a link from
pull-requests.md

PR-URL: #23949
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
PR-URL: #23706
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #23957
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Copy-edit for clarity and brevity.

PR-URL: #23966
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Per branding guidelines from the Foundation, use Node.js and not Node.

PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #23967
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
@targos
Copy link
Member Author

targos commented Nov 1, 2018

OK, thank you @richardlau and @refack. I removed the commits that were from those PRs. I also cherry-picked a few more doc and test fixes from master.

I can't run CI because it's shutting down.

Here is a test release build: https://ci-release.nodejs.org/job/iojs+release/3889/

@refack
Copy link
Contributor

refack commented Nov 1, 2018

@refack
Copy link
Contributor

refack commented Nov 1, 2018

ci-release on arm7 is ✔️

@refack refack removed the blocked PRs that are blocked by other issues or PRs. label Nov 1, 2018
@targos
Copy link
Member Author

targos commented Nov 2, 2018

@targos targos merged commit af6d262 into v11.x Nov 2, 2018
targos added a commit that referenced this pull request Nov 2, 2018
targos added a commit that referenced this pull request Nov 2, 2018
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922
targos added a commit to nodejs/nodejs.org that referenced this pull request Nov 2, 2018
targos added a commit to nodejs/nodejs.org that referenced this pull request Nov 2, 2018
@targos targos deleted the v11.1.0-proposal branch November 2, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.