Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assertion arguments order #23787

Closed
wants to merge 1 commit into from
Closed

test: fix assertion arguments order #23787

wants to merge 1 commit into from

Conversation

Aiden01
Copy link
Contributor

@Aiden01 Aiden01 commented Oct 20, 2018

Fixed assertion arguments order on strictEqual() and deepStrictEqual().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 20, 2018
@lundibundi
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18011/

@Trott
Copy link
Member

Trott commented Oct 22, 2018

Landed in 89aa33a

@Trott Trott closed this Oct 22, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 22, 2018
@Aiden01 @Trott
test: fix assertion arguments order
89aa33a 
PR-URL: nodejs#23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Aiden01 Aiden01 deleted the webd-fix branch October 22, 2018 22:35
targos pushed a commit that referenced this pull request Oct 24, 2018
@Aiden01 @targos
test: fix assertion arguments order
fa1373f 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@Aiden01 @MylesBorins
test: fix assertion arguments order
4116788 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@Aiden01 @MylesBorins
test: fix assertion arguments order
c499e09 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Aiden01 @rvagg
test: fix assertion arguments order
544e64d 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Aiden01 @rvagg
test: fix assertion arguments order
d9cb7dd 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Aiden01 @MylesBorins
test: fix assertion arguments order
cc040f6 
PR-URL: #23787
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
This was referenced Dec 18, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundibundi lundibundi lundibundi approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Aiden01 @lundibundi @Trott @lpinca @targos @cjihrig @MylesBorins @nodejs-github-bot