Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document and warn if the ICU version is too old #23766

Merged
merged 0 commits into from
Oct 23, 2018
Merged

doc: document and warn if the ICU version is too old #23766

merged 0 commits into from
Oct 23, 2018

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 19, 2018 •
edited
Loading

Fixes: #19657

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Example:

$ ./configure --with-intl=small-icu --with-icu-source=https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download
Deleting old ICU source: deps/icu
 <https://sourceforge.net/projects/icu/files/ICU4C/4.6.1/icu4c-4_6_1-src.tgz/download>
 Fetch: . 15.2MB total, 15.2MB downloaded
 Extracting tarfile: deps/icu-tmp/download
WARNING: icu4c v46.x may be too old, v57.x or later is recommended.
WARNING: warnings were emitted in the configure phase

@nodejs-github-bot
Copy link
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1303/pipeline

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 19, 2018
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Oct 19, 2018
@srl295 srl295 self-assigned this Oct 19, 2018
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17999/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2018
refack
refack reviewed Oct 20, 2018
View reviewed changes
configure.py Outdated
@@ -1452,6 +1455,8 @@ def write_config(data, name):
icu_ver_major = m.group(1)
if not icu_ver_major:
error('Could not read U_ICU_VERSION_SHORT version from %s' % uvernum_h)
elif int(icu_ver_major) < minimum_icu:
warn('icu4c v%d.x may be too old, v%d.x or later is recommended.' % (int(icu_ver_major), minimum_icu))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may? what can happen if it is? why not go all out and error?
(escape hatch is to manually edit config.gypi)

Copy link
Member Author

@srl295 srl295 Oct 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a compile error. which they will see soon enough… ±0 on making it an error, either way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

refack
refack suggested changes Oct 20, 2018
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good concept. Left two comments.

configure.py Outdated
@@ -51,6 +51,7 @@
valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
valid_mips_float_abi = ('soft', 'hard')
valid_intl_modes = ('none', 'small-icu', 'full-icu', 'system-icu')
minimum_icu = 57
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you read this with:
https://github.com/nodejs/node/blob/bce91be01e333aa67874c89eeea419eb68dcc33a/configure.py#L1266-L1267

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack hm. Doesn't make sense with the format of current_ver.dep … the minimum ICU is global, doesn't need to be repeated multiple times.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refack I split the minimum version to a separate file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change the format of tools/icu/current_ver.dep to be:

{
  "current_minimum": 57,
  "packages": [ ... current content ... ]
}

@refack
Copy link
Contributor

refack commented Oct 23, 2018

CI (just in case you don't wanna patch this any more): https://ci.nodejs.org/job/node-test-pull-request/18060/

@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2018
@srl295
Copy link
Member Author

srl295 commented Oct 23, 2018

@refack how about moving the contents to the new .json file in a future PR once these land? (this and the 2 other PRs)

@srl295 srl295 closed this Oct 23, 2018
@srl295 srl295 merged commit d8b6a1d into nodejs:master Oct 23, 2018
targos pushed a commit that referenced this pull request Oct 24, 2018
@srl295 @targos
doc: document and warn if the ICU version is too old
db113a2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@srl295 srl295 mentioned this pull request Oct 24, 2018
Merged
@targos targos mentioned this pull request Oct 27, 2018
Merged
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@srl295 @MylesBorins
doc: document and warn if the ICU version is too old
f1c2fb3 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@MylesBorins
Copy link
Contributor

This lands cleanly on 10.x, should we backport to 8.x?

@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@srl295 @rvagg
doc: document and warn if the ICU version is too old
feacd47 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@srl295 @MylesBorins
doc: document and warn if the ICU version is too old
e87e9f2 
Fixes: #19657

PR-URL: #23766
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

@devsnek devsnek Awaiting requested review from devsnek

Assignees

@srl295 srl295

Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@srl295 @nodejs-github-bot @addaleax @refack @MylesBorins @jasnell @richardlau @ryzokuken