build,meta: bump gcc on travis #23778

refack · 2018-10-20T02:33:39Z

The version of clang provided in the Travis linux image uses
libstdc++4.8 whice is below our minimal supported version.

Switching to make test -j1 is to avoid races during the test cycle
causes by the main target being "unstable", that is it always builds
some files, and relinks the binary, which is used by the test procedure.

../src/node_crypto.cc:3641:29: error: no matching function for call to 'get'
    return sign->CheckThrow(std::get<Error>(ret));
                            ^~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:142:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(std::pair<_Tp1, _Tp2>& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:147:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(std::pair<_Tp1, _Tp2>&& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/utility:152:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(const std::pair<_Tp1, _Tp2>& __in) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:268:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'
    get(array<_Tp, _Nm>& __arr) noexcept
    ^
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/array:277:5: note: candidate template ignored: invalid explicitly-specified argument for template parameter '_Int'

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2018-10-20T02:33:40Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1309/pipeline

refack · 2018-10-20T02:34:46Z

/CC @nodejs/build-files @nodejs/testing

refack · 2018-10-20T02:36:08Z

.travis.yml

      script:
-        - make -j2 test
+        - make test


Refs: #23733

I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.

It makes the tests consistent with JEnkins, but I'll do it in another PR

addaleax · 2018-10-20T02:39:53Z

.travis.yml

      script:
-        - make -j2 test
+        - make test


I’d prefer to undo this unless it’s actually causing trouble on Travis – I don’t think we’ve seen this so far.

addaleax · 2018-10-20T02:42:26Z

.travis.yml

-        - ./configure
-        - make -j2 V=
+        - CC='ccache gcc-4.9' && CXX='ccache g++-4.9' python configure.py --verbose
+        - CC='ccache gcc-4.9' && CXX='ccache g++-4.9' make -j2 V=


Maybe set these using export CC='ccache gcc-4.9' && CXX='ccache g++-4.9' on the first line of install:, and then leave these lines as they are?

Also, I’d prefer to keep ./configure – firstly, the .travis.yml of a project is sometimes used by devs to figure out how to build it, because it’s usually much more to-the-point than build instructions, and secondly that way we simply test more code than without it (namely the contents of configure).

I'm suspicious it's not behaving as we expect (hence it's using GCC over clang), so I'd rather has it explicit (like in Jenkins).

Ack on the ./configure

Testing export in install

addaleax · 2018-10-20T03:05:03Z

I'm suspicious it's not behaving as we expect (hence it's using GCC over clang), so I'd rather has it explicit (like in Jenkins).

From a quick google search, it seems like the error message is a clang one.

refack · 2018-10-20T03:09:11Z

From a quick google search, it seems like the error message is a clang one.

So it might be just an stdlibc++ issue?

addaleax · 2018-10-20T03:11:09Z

@refack My guess is that it might be the gcc-provided libstdc++ 4.8 not playing along well with clang? Could be totally wrong on that one, though.

(I also don’t remember the reason for picking clang in the first place, tbh.)

refack · 2018-10-20T03:14:45Z

I also changed the output generator from

make -j2 V=
make -C out BUILDTYPE=Release V=
make[1]: Entering directory `/home/travis/build/nodejs/node/out'
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/bits.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/cpu.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/division-by-constant.o
  CXX(host) /home/travis/build/nodejs/node/out/Release/obj.host/v8_libbase/deps/v8/src/base/file-utils.o

to

$ make -j2 V=1 | sed -e "s/'.*\$//" -e "s|$PWD||g"
make -C out BUILDTYPE=Release V=1
make[1]: Entering directory `/out
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/bits.o ../deps/v8/src/base/bits.cc 
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/cpu.o ../deps/v8/src/base/cpu.cc 
  ccache g++-4.9 -o /out/Release/obj.host/v8_libbase/deps/v8/src/base/debug/stack_trace.o ../deps/v8/src/base/debug/stack_trace.cc

(this is planned to change in Jenkins as well nodejs/build#1517)

addaleax · 2018-10-20T03:31:10Z

@refack One thing I’m noticing here is that the extra apt install took about a minute in https://travis-ci.com/nodejs/node/jobs/153110829 … not the end of the world, but something we might want to consider?

lpinca · 2018-10-20T05:48:03Z

.travis.yml

        - ./configure
-        - make -j2 V=
+        - make -j2 V=1 | sed -e "s/'.*\$//" -e "s|$PWD||g"


It seems nodejs/build#1517 is still being discussed. I'm not a fan of this change, can we revert it?

refack · 2018-10-22T23:58:13Z

One thing I’m noticing here is that the extra apt install took about a minute in travis-ci.com/nodejs/node/jobs/153110829

But for some reason total was 13m
and other job took 14m

While currently the jobs (using clang) take 15m+

.travis.yml

refack · 2018-10-24T17:45:20Z

It's back:

In file included from ../src/bootstrapper.cc:2:
In file included from ../src/env-inl.h:27:
../src/aliased_buffer.h:27:27: error: no template named 'enable_if_t' in namespace 'std'; did you mean 'enable_if'?
          typename = std::enable_if_t<std::is_scalar<NativeT>::value>>
                     ~~~~~^~~~~~~~~~~
                          enable_if
/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/type_traits:1766:12: note: 'enable_if' declared here
    struct enable_if
           ^
1 error generated.

refack · 2018-10-24T21:24:32Z

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1361/

The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: nodejs#23778 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

The version of `clang` provided in the Travis linux image uses libstdc++4.8 whice is below our minimal supported version. Switching to `make test -j1` is to avoid races during the test cycle causes by the main target being "unstable", that is it always builds some files, and relinks the binary, which is used by the test procedure. PR-URL: #23778 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

refack added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. regression Issues related to regressions. fast-track PRs that do not need to wait for 48 hours to land. labels Oct 20, 2018

refack mentioned this pull request Oct 20, 2018

crypto: simplify internal state handling #23648

Closed

2 tasks

refack requested review from addaleax and lpinca October 20, 2018 02:34

refack commented Oct 20, 2018

View reviewed changes

addaleax reviewed Oct 20, 2018

View reviewed changes

addaleax mentioned this pull request Oct 20, 2018

src: use more explicit return type in Sign::SignFinal() #23779

Closed

2 tasks

lpinca reviewed Oct 20, 2018

View reviewed changes

refack force-pushed the bump-gcc-on-tavis branch from 5310a62 to aeae42a Compare October 20, 2018 13:33

lpinca approved these changes Oct 20, 2018

View reviewed changes

richardlau mentioned this pull request Oct 21, 2018

build: use libc++ with clang on Travis #23791

Closed

1 task

refack force-pushed the bump-gcc-on-tavis branch from aeae42a to 9e1081f Compare October 23, 2018 00:09

richardlau reviewed Oct 23, 2018

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

refack force-pushed the bump-gcc-on-tavis branch from 9e1081f to 3c9fecb Compare October 23, 2018 02:44

addaleax removed fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. labels Oct 24, 2018

addaleax reviewed Oct 24, 2018

View reviewed changes

.travis.yml Show resolved Hide resolved

refack self-assigned this Oct 24, 2018

richardlau approved these changes Oct 24, 2018

View reviewed changes

refack force-pushed the bump-gcc-on-tavis branch from a19546f to a2328da Compare October 24, 2018 21:34

refack merged commit a2328da into nodejs:master Oct 24, 2018

refack removed their assignment Oct 24, 2018

refack deleted the bump-gcc-on-tavis branch October 24, 2018 21:38

targos mentioned this pull request Oct 27, 2018

Release proposal: v11.1.0 #23922

Merged

MylesBorins added land-on-v8.x labels Nov 26, 2018

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

BethGriggs mentioned this pull request Dec 4, 2018

v8.14.1 proposal #24832

Merged

richardlau mentioned this pull request Mar 30, 2019

Fix Travis builds #27002

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build,meta: bump gcc on travis #23778

build,meta: bump gcc on travis #23778

refack commented Oct 20, 2018 •

edited

Loading

nodejs-github-bot commented Oct 20, 2018

refack commented Oct 20, 2018

refack Oct 20, 2018

addaleax Oct 20, 2018

refack Oct 20, 2018 •

edited

Loading

addaleax Oct 20, 2018

addaleax Oct 20, 2018

refack Oct 20, 2018

refack Oct 20, 2018

addaleax commented Oct 20, 2018

refack commented Oct 20, 2018

addaleax commented Oct 20, 2018

refack commented Oct 20, 2018

addaleax commented Oct 20, 2018

lpinca Oct 20, 2018

refack Oct 20, 2018

refack commented Oct 22, 2018

refack commented Oct 24, 2018

refack commented Oct 24, 2018

build,meta: bump gcc on travis #23778

build,meta: bump gcc on travis #23778

Conversation

refack commented Oct 20, 2018 • edited Loading

nodejs-github-bot commented Oct 20, 2018

refack commented Oct 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refack Oct 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

addaleax commented Oct 20, 2018

refack commented Oct 20, 2018

addaleax commented Oct 20, 2018

refack commented Oct 20, 2018

addaleax commented Oct 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refack commented Oct 22, 2018

refack commented Oct 24, 2018

refack commented Oct 24, 2018

refack commented Oct 20, 2018 •

edited

Loading

refack Oct 20, 2018 •

edited

Loading