Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move @phillipj to emeriti #23790

Closed
wants to merge 1 commit into from
Closed

doc: move @phillipj to emeriti #23790

wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

Moving myself to emeriti as I have not been an active collaborator for a long time, and will not have the opportunity to do so in the near future because of life outside of GitHub.

Will always be grateful for how incredibly inclusive the Node.js project / community is, much appreciated ❤️

Checklist

@phillipj
doc: move @phillipj to emeriti
bf159fa 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.
@nodejs-github-bot
Copy link
Collaborator

@phillipj build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1319/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 20, 2018
@refack refack added the meta Issues and PRs related to the general management of the project. label Oct 21, 2018
@phillipj
Copy link
Member Author

Could someone in @nodejs/tsc be so kind and remove me from the collaborators team?

mcollina
mcollina approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipj
Copy link
Member Author

Could someone from @nodejs/tsc be kind enough to remove me from the collaborators team?

@ChALkeR
Copy link
Member

ChALkeR commented Oct 22, 2018 •
edited
Loading

@phillipj Sorry for all the review duplicates — GitHub was splitting out server errors and it wasn't visible that the data was actualy saved before the issue with data inconsistency was fixed on GitHub side. I did not do that on a purpose.

@phillipj
Copy link
Member Author

No worries @ChALkeR, I also had trouble commenting on this PR earlier today. Resulted in error multiple times, but looks like at least one of them came through anyways.

@targos
Copy link
Member

targos commented Oct 22, 2018

Could someone from @nodejs/tsc be kind enough to remove me from the collaborators team?

Done

mhdawson
mhdawson approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Oct 23, 2018

Landed in d36abb5.

@Trott Trott closed this Oct 23, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 23, 2018
@phillipj @Trott
doc: move @phillipj to emeriti
d36abb5 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: nodejs#23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Oct 24, 2018
@phillipj @targos
doc: move @phillipj to emeriti
c30de85 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 2, 2018
Closed
This was referenced Nov 2, 2018
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@phillipj @MylesBorins
doc: move @phillipj to emeriti
c77d127 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@phillipj @MylesBorins
doc: move @phillipj to emeriti
4d99c2f 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@phillipj @rvagg
doc: move @phillipj to emeriti
f037942 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@phillipj @rvagg
doc: move @phillipj to emeriti
d3dec1c 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@phillipj @MylesBorins
doc: move @phillipj to emeriti
070d87a 
Moving @phillipj to emeriti as he has not been an active collaborator
for a long time, and will not have the opportunity to do so in the
near future.

PR-URL: #23790
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lundibundi lundibundi lundibundi approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@refack refack refack approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.