V8 gyp file refactor performance regression #23796
Labels
build
Issues and PRs related to build files or the CI.
performance
Issues and PRs related to the performance of Node.js.
regression
Issues related to regressions.
v8 engine
Issues and PRs related to the V8 dependency.
Comments
addaleax
added
build
3 tasks
|
Fix in #23801 |
refack
added a commit
to refack/node
that referenced
this issue
Oct 23, 2018
PR-URL: nodejs#23801 Fixes: nodejs#23796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
targos
pushed a commit
that referenced
this issue
Oct 24, 2018
PR-URL: #23801 Fixes: #23796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Oct 25, 2018
PR-URL: #23801 Fixes: #23796 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since #23182, we build V8 in Release mode with
-DENABLE_HANDLE_ZAPPING. This should only be enabled in debug mode.I’ve only noticed this because it’s started to show up as 2 % runtime overhead in benchmarks – I’m not familiar enough with GYP to address this myself.
@refack @nodejs/build-files
The text was updated successfully, but these errors were encountered: