Node.js 8.6.0 Release Proposal #15509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error code originally landed in a semver-major commit and is used by the ESM implementation. This backport includes the error message and the documentation for the error. I did attempt to write a test for this, but it did not seem possible to catch an exception during import, I was also unable to execute `node --experimental-modules` properly inside of a child_process. I'll dig more into getting a test together, but we should backport this fix in the mean time. Refs: #14423 Fixes: #15374 PR-URL: #15388 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]>
The original changelog included incorrect information regarding the new perf_hooks api. refs: #15308 (comment) PR-URL: #15384 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #15235 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Adds the `'timeout'` event to the `http.ClientRequest` documentation. PR-URL: #15443 Fixes: #14856 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available. PR-URL: #15298 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Setting writable = false in IncomingMessage.end made some errors being swallowed in some very popular OSS libraries that we must support. This commit add some of those use cases to the tests, so we avoid further regressions. We should reevaluate how to set writable = false in IncomingMessage in a way that does not break the ecosystem. See: #14024 Fixes: #15029 PR-URL: #15404 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Add access-control-*, dnt, forwarded, trailer, tk, upgrade-insecure-requests, warning, x-content-type-options and x-frame-options to known list of headers for HTTP2. Expand tests to account for these headers. Fixes: #15337 Refs: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers Refs: https://www.w3.org/TR/cors/#syntax Refs: https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#dnt-header-field Refs: https://tools.ietf.org/html/rfc7239#section-4 Refs: https://tools.ietf.org/html/rfc7230#section-4.4 Refs: https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#response-header-field Refs: https://www.w3.org/TR/upgrade-insecure-requests/#preference Refs: https://tools.ietf.org/html/rfc7234#section-5.5 Refs: https://fetch.spec.whatwg.org/#x-content-type-options-header Refs: https://tools.ietf.org/html/rfc7034 PR-URL: #15434 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Using SSL_CTX_set1_curves_list() (OpenSSL 1.0.2+), this allows to set colon separated ECDH curve names in SecureContext's ecdhCurve option. The option can also be set to "auto" to select the curve automatically from list built in OpenSSL by enabling SSL_CTX_set_ecdh_auto() (OpenSSL 1.0.2+). PR-URL: #15206 Ref: #15054 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #11018 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Lance Ball <[email protected]>
PR-URL: #15111 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
test-require-symlink modifies the fixture directory by adding a symlink. Copy the fixture to the test tmpdir instead of modifying the fixture directory. This also uses a more empirical test for checking for the ability to make symlinks on Windows. PR-URL: #15067 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #14002 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
TODO comment from node_crypto is no longer relevant. Unification of commented code and string_bytes code would bloat the latter. Methods for hex encoding produce different output in both files (crypto adds colon and uses uppercase letters.) Common path between those two is very limited now. PR-URL: #15104 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #15406 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #15408 Fixes: #14960 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Adds support for link-module option to vcbuild.bat. PR-URL: #15410 Fixes: #15377 Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: #15420 Fixes: #15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Fix Http2ServerRequest and Http2ServerResponse to emit close event if the request is aborted before response.end can be called. Fixes: #15385 PR-URL: #15415 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Increase server timeout, reduce frequency of calls and unbind timeout after runs are done in order to avoid race conditions. Temporarily moved to sequential. Fixes: #15326 PR-URL: #15338 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
fix documentation for methods getHeader, setHeader and removeHeader for http.ClientRequest class. The documentation said these functions can be called but they're wasn't describe into the API description yet. add parameters and general description for each methods. PR-URL: #15163 Fixes: #15048 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
The benchmarks for `assert` all take a `method` configuration option, but the allowable values are different across the files. For each benchmark, provide an arbitrary default if `method` is set to an empty string. This allows all the `assert` benchmarks to be run with a single command but only on a single method. This is primarily useful for testing that the assert benchmark files don't contain egregious errors. (In other words, it's useful for testing.) PR-URL: #15174 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
`deepequal-typedarrays.js` throws if `len` is set to 100 or less due to a hardcoded index. Calculate the index based on `len` so benchmark can be run with small `len` values if desired. PR-URL: #15174 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #15275 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #15374 PR-URL: #15389 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #15399 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Update docs and type checking for AsyncResource type PR-URL: #15103 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Andreas Madsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: #15373 Fixes: #15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove napi_is_construct_call and introduce napi_get_new_target. PR-URL: #14698 Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
As per discussion in abi-stable-node: nodejs/abi-stable-node#256, take a refactor to napi_addon_register_func such that the result from the register function is assigned to the module exports property. By making this change, native module can be agnostic about which type of module the environment supports. PR-URL: #15088 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
PR-URL: #14697 Reviewed-By: Trevor Norris <[email protected]>
PR-URL: #15621 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
jasnell
force-pushed
the
v8.6.0-proposal
branch
2 times, most recently
from
48d7f58
to
1732dac
Compare
|
@nodejs/collaborators @nodejs/tsc ... please take a final look. This will be going out today. |
|
Were the N-API changes that were wanted to be made before it was unflagged ever done? Certainly seems fine otherwise. |
No. The LTS release will come later. |
As far as I understand. |
code samples of napi_create_object and napi_property_descriptor were not updated to latest API. PR-URL: #15581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell
force-pushed
the
v8.6.0-proposal
branch
from
1732dac
to
d55e3aa
Compare
|
@lpinca ... done |
Fixes: nodejs-private/security#147 PR-URL: nodejs-private/node-private#94 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Doug Wilson <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
jasnell
force-pushed
the
v8.6.0-proposal
branch
from
d55e3aa
to
d31138f
Compare
|
Release build started: https://ci-release.nodejs.org/job/iojs+release/2048/ |
|
Unable to proceed with the build due to an issue with the ci-release infrastructure. No response yet from @nodejs/build team members . |
* **crypto** * Support for multiple ECDH curves. [#15206](#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](#7855) * Custom lookup functions are now supported. [#14560](#14560) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)
PR-URL: #15509
jasnell
force-pushed
the
v8.6.0-proposal
branch
from
d31138f
to
69a2405
Compare
|
New Release CI: https://ci-release.nodejs.org/job/iojs+release/2054/ |
Did you just ping on IRC? Didn't see anything in nodejs/build or nodejs/node. |
|
It's up and going now. I pinged in the node-dev channel, pinged several individually via irc, pinged michael via hangouts and twitter dm... didn't want to spam the entire team tho :-) |
jasnell
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 26, 2017
jasnell
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Release Date: 2017-09-26
Notable Changes
setMulticastInterface()API. #7855parseCertString(). #14245Commits
7fa175f6d3] - assert: fix deepEqual inconsistencies (Ruben Bridgewater) #1449181723a9172] - (SEMVER-MINOR) async_hooks,doc: some async_hooks improvements (James M Snell) #151033bf718c3fe] - benchmark: enable assert benchmark with short len (Rich Trott) #15174d30a5836b6] - benchmark: provide default methods for assert (Rich Trott) #15174142d2ed057] - benchmark: use smaller n value in some http tests (Peter Marshall) #140025e4f87ae65] - buffer: improve Buffer.from performance (Anatoli Papirovski) #15178354f32040d] - build: remove unused configuration variable (Ben Noordhuis) #152665d217ad5d7] - build: add support for link-module to vcbuild (Bartosz Sosnowski) #15410607832d3c3] - child_process: set shell to false in fork() (Alex Gresnel) #15352c26e93b309] - crypto: fix Node_SignFinal (David Benjamin) #15024bd07574718] - (SEMVER-MINOR) crypto: support multiple ECDH curves and auto (Roga Pria Sembada) #15206b24ee68133] - (SEMVER-MINOR) dgram: added setMulticastInterface() (Will Young) #7855fcbee7b4bb] - doc: fix some links in http2.md (Vse Mozhet Byt) #154819d6b0e6f6f] - doc: fix external links with 404 status (Vse Mozhet Byt) #1546329fd88c3e5] - doc: fix new nits in links (Vse Mozhet Byt) #154494efc6fec6b] - doc: fix some internal links (Vse Mozhet Byt) #152935ea4b88a29] - doc: adding sebdeckers to collaborators (Sebastiaan Deckers) #15354d5d498b6dc] - doc: update AUTHORS list (Michaël Zasso) #15181950f7f5fe1] - doc: update README with SHASUMS256.txt.sig info (Jon Moss) #1510738422d5963] - doc: fix nits in esm.md (Vse Mozhet Byt) #15315b0f5b2a38c] - doc: fix "added in" for Buffer.allocUnsafeSlow() (Tuan Anh Tran) #153308112f496dc] - doc: add missing heading for error (Jon Moss) #1532529707afd82] - doc: add missing doc for readable._destroy (Michaël Zasso) #153169f4480ce90] - doc: use consistent terminology in process doc (Rich Trott) #15321a53a0d8b38] - doc: fix emitKeypressEvents stream type (Oblosys) #15399b5c1a82560] - doc: fix http.ClientRequest method descriptions (Antoine AMARA) #15163f0e411d1b2] - doc: prevent displaying empty version picker (Chris Young) #15420acb0d012b3] - doc: make mkdtemp example work on Windows (Bartosz Sosnowski) #15408bdfed1ad25] - doc: fix entryTypes type and missing link (Mani Maghsoudlou) #154067fa2bee5e7] - doc: add documentation for the 'timeout' event (Luigi Pinca) #15443b09eeb4a3d] - (SEMVER-MINOR) doc, tls: mark parseCertString() as deprecated (XadillaX) #14245a792ea7709] - docs: update 8.5.0 changelog (Myles Borins) #15384b58a2aae1b] - errors: fix ERR_MODULE_RESOLUTION_LEGACY message (Tobias Nießen) #15290da3265ad82] - errors: backport ERR_INVALID_PROTOCOL to v8.x (Myles Borins) #15388771c2ac7c2] - http: revert http: OutgoingMessage change writable after end #14024 writable is never set to false (Matteo Collina) #1540466a5f99828] - http2: improved coverage of Http2Stream destroy (Simon Brewster) #15461ba9012d4bc] - http2: add tests for push stream error handling (Anatoli Papirovski) #15281b61220ed84] - http2: fix subsequent end calls to not throw (Anatoli Papirovski) #154142e421ff5c9] - http2: correct behaviour for enablePush unpack (Anatoli Papirovski) #151679490be353e] - http2: cleanup of h2 compat layer, add tests (Anatoli Papirovski) #15254aa0917cd0a] - http2: improve http2 coverage (James M Snell) #15210a6879bfab6] - http2: custom promisify for http2.connect (James M Snell) #152072ea2725ce0] - http2: emit close event if request aborted (Anatoli Papirovski) #15415b9a9290e8d] - http2: expand list of known headers (Anatoli Papirovski) #15434a32c8a566e] - http2,async-wrap: introduce AliasedBuffer class (Mike Kaufman) #1507725692a985c] - inspector: break in eval script (Eugene Ostroukhov) #145818ce0e9a619] - lib: refactor console startup (Ruben Bridgewater) #1511191e96d8f08] - lib,src: fix consistent spacing inside braces (James M Snell) #14162ede09f29d0] - meta: allow vague objections to be dismissed (James M Snell) #15233727d7b5078] - meta: improve contributors guide (James M Snell) #15123c005713d05] - module: check file url passed to top-level import (guybedford) #15389939c8ed084] - module: coverity fixes for ESM C++ (Bradley Farias) #15275cd3a8e8832] - n-api: remove n-api module loading flag (Gabriel Schulhof) #14902526e78f5cd] - n-api: add optional string length parameters (Sampson Gao) #1534387a3162f85] - n-api: Context for custom async operations (Jason Ginchereau) #151897b7c030adc] - (SEMVER-MINOR) n-api: change async resource name to napi_value (Jason Ginchereau) #14697d5b3002572] - n-api: stop creating references to primitives (Gabriel Schulhof) #15289a47fe692b1] - (SEMVER-MINOR) n-api: use AsyncResource for Work tracking (Anna Henningsen) #146978f12b9dce4] - n-api: refactor napi_addon_register_func (Taylor Woll) #15088a2d340fb00] - n-api: napi_is_construct_call->napi_get_new_target (Sampson Gao) #14698774e42b575] - (SEMVER-MINOR) src: refactor#includehandling (Anna Henningsen) #1469729e38ab2a2] - src: remove unused perf_hooks uv handles (James M Snell) #15368606da2ba43] - (SEMVER-MINOR) src: make in_makecallback() getter const (Anna Henningsen) #1469798967c988f] - (SEMVER-MINOR) src: refactor async callback handling (Anna Henningsen) #14697f60a2aa982] - (SEMVER-MINOR) src: remove virtually unused ExecScope (Anna Henningsen) #146976c520af6d5] - (SEMVER-MINOR) src: move DomainEnter,DomainExit to node.cc (Anna Henningsen) #146978c480f9d8c] - src: remove outdated todo from node_crypto.cc (Bartek Szczepański) #1510459f183640b] - test: refactor test for readability (Refael Ackermann) #13003757c34276b] - test: fix actual and expected order (Ruben Bridgewater) #148815125c08c50] - test: remove obsolete debugger tests (Rich Trott) #151397dfd570cad] - test: add test-benchmark-assert (Rich Trott) #15174a9066459ad] - test: convert buffer benchmark to runBenchmark (Jon Moss) #1534945cdbcfee6] - test: create shared runBenchmark function (Jon Moss) #15004ba96c8f23e] - test: don't skip when common.mustCall() is pending (cjihrig) #1542150b6203a33] - (SEMVER-MINOR) test: add regression test for 5691 (Anna Henningsen) #14697f0a741d178] - test: kill subprocess only after last ACK (Refael Ackermann) #151864d68064493] - test: move common.PORT tests to sequential (Jon Moss) #15151a92f3dfd8c] - test: make test-http-agent-maxsockets robust (Rich Trott) #15192edece30930] - test: remove random timer in test-tls-fast-writing (Rich Trott) #15138b1a0bdcdaf] - test: remove faulty test case (Ruben Bridgewater) #15110cd238e2c0e] - test: check inspect array with empty string key (Rahul Mishra) #152583ce501c8ff] - test: improve process warning coverage (James M Snell) #15212a2c335b973] - test: fix sequential/test-async-wrap-getasyncid (Anna Henningsen) #1531994e2b5c371] - test: refactor test-debug-prompt (Rich Trott) #151415881033138] - test: remove invalid test (Rich Trott) #15320a1abf62cc3] - test: allow adding known-globals through ENV (Refael Ackermann) #15187427bf80194] - test: add test for fork() + shell (cjihrig) #153524d26c68b6b] - test: move test-benchmark-buffer to sequential (Rich Trott) #153731fbdf47742] - test: fix flaky test-http2-session-timeout (Anatoli Papirovski) #15338f20fb4ce40] - test: do not write fixture in test-require-symlink (Rich Trott) #15067389c8c33d7] - test: expand http2 frameError test case (Anatoli Papirovski) #15298d82ae0cb6e] - test: backward compatible api for tty (Gergely Nemeth) #152356a94c1aa3b] - timers: clarify lib/timer.js comment (Daniel Bevenius) #110189049f09e0f] - tools: enforce consistent spacing inside braces (Sebastiaan Deckers) #14162539445890b] - util: add fast internal array join method (Ruben Bridgewater) #148817d95dc385c] - vm: support parsing a script in a specific context (Timothy Gu) #14888