test: fix sequential/test-async-wrap-getasyncid #15319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
approved these changes
Sep 10, 2017
lpinca
approved these changes
Sep 11, 2017
tniessen
approved these changes
Sep 11, 2017
addaleax
changed the title
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately.
addaleax
force-pushed
the
test-getasyncid
branch
from
d373132
to
866da32
Compare
jasnell
approved these changes
Sep 12, 2017
BridgeAR
approved these changes
Sep 13, 2017
|
Landed in 5ee2d3e |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 13, 2017
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately. PR-URL: #15319 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
added a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately. PR-URL: nodejs/node#15319 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately. PR-URL: #15319 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Previously, this test would contain a DNS query that timed out after 60 seconds, thus occupying one of the parallel test slots for that period. Fix that by creating a new channel for that request, and cancelling it immediately. PR-URL: nodejs/node#15319 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this test would contain a DNS query that timed out
after 60 seconds, thus occupying one of the parallel test slots
for that period.
Fix that by creating a new channel for that request, and cancelling
it immediately.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test