Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check util.inspect for array having empty string as key #15258

Closed
wants to merge 1 commit into from
Closed

test: check util.inspect for array having empty string as key #15258

wants to merge 1 commit into from

Conversation

mrahul17
Copy link
Contributor

@mrahul17 mrahul17 commented Sep 8, 2017 •
edited
Loading

Refs: #15159

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 8, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Sep 8, 2017
@BridgeAR
Copy link
Member

Landed in 21a3ae3

@light94 thanks a lot for your contribution and congratulations on your first commit to Node.js! 🎉

@BridgeAR BridgeAR closed this Sep 11, 2017
BridgeAR pushed a commit that referenced this pull request Sep 11, 2017
@mrahul17 @BridgeAR
test: check inspect array with empty string key
21a3ae3 
PR-URL: #15258
Refs: #15159
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@mrahul17
Copy link
Contributor Author

Thanks @BridgeAR. I am willing to take more easy tasks to begin with, but most issues have been partially solved from contributors in the past and have not been active for quite some time. Is it okay to take these?

@refack
Copy link
Contributor

refack commented Sep 11, 2017

@light94 if you have a specific issue in mind ping the OP and a Collaborator (like me or @BridgeAR) and a specific decision can be made.

addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@mrahul17 @addaleax
test: check inspect array with empty string key
5b513b7 
PR-URL: nodejs#15258
Refs: nodejs#15159
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@mrahul17 @jasnell
test: check inspect array with empty string key
cd238e2 
PR-URL: #15258
Refs: #15159
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@mrahul17 @MylesBorins
test: check inspect array with empty string key
d29d846 
PR-URL: #15258
Refs: #15159
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@mrahul17 @MylesBorins
test: check inspect array with empty string key
9cebe82 
PR-URL: #15258
Refs: #15159
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mrahul17 @BridgeAR @refack @lpinca @cjihrig @tniessen @mscdex @MylesBorins @nodejs-github-bot