Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: convert buffer benchmark to runBenchmark #15349

Closed
wants to merge 1 commit into from
Closed

test: convert buffer benchmark to runBenchmark #15349

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

This landed in master while #15004 was being reviewed, so this needs updating :)

cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 11, 2017
Trott
Trott approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Sep 12, 2017
@lpinca
Copy link
Member

lpinca commented Sep 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10047/

@refack
Copy link
Contributor

refack commented Sep 12, 2017

This will conflict with #15373
Just a heads up.

jasnell pushed a commit that referenced this pull request Sep 14, 2017
@maclover7 @jasnell
test: convert buffer benchmark to runBenchmark
7456db9 
PR-URL: #15349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 14, 2017

Landed in 7456db9

@jasnell jasnell closed this Sep 14, 2017
@maclover7 maclover7 deleted the jm-benchmark-buffer branch September 14, 2017 23:37
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@maclover7 @addaleax
test: convert buffer benchmark to runBenchmark
a9e0031 
PR-URL: nodejs/node#15349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@maclover7 @jasnell
test: convert buffer benchmark to runBenchmark
a906645 
PR-URL: #15349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@maclover7
test: convert buffer benchmark to runBenchmark
1a1261d 
PR-URL: nodejs/node#15349
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maclover7 @lpinca @refack @jasnell @MylesBorins @Trott @hiroppy @mscdex @nodejs-github-bot