-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: empty version picker on some pages #15396
Comments
@chris--young what's you idea for solution? Intuitively I'd go with a "available in current version only" (or something similar) placeholder instead of the drop down. P.S. How much work would it be to add minor versions as well (maybe only relevant minor when new feature were added based on the Lines 3400 to 3408 in cb94905
|
@refack the change i have now just doesnt display the drop down at all if there arent multiple version to pick from. including minor version should be doable but it will probably take a bit more work. i think itd be best to do that in a separate pr so it doesnt block fixing this bug |
Agreed. |
PR-URL: #15420 Fixes: #15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs/node#15420 Fixes: nodejs/node#15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#15420 Fixes: nodejs#15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #15670 PR-URL: #15420 Fixes: #15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs/node#15420 Fixes: nodejs/node#15396 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
The version picker I added to the docs recently does not properly account for pages without the
<-- introduced_in -->
tag, or pages with the tag but without multiple version of the doc. The n-api docs are a good example of this. The version drop down is there, but has no options when you click on it.Affected pages: async_hooks, n-api, deprecations, esm, http2, inspector, intl, perf_hooks, tracing
I already started working on a fix for this and will open a pr later tonight.
The text was updated successfully, but these errors were encountered: