http2: connect promisify customization, other improvements #15207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
mscdex
reviewed
Sep 5, 2017
src/node_http2_core-inl.h
Outdated
| int32_t id = (frame->hd.type == NGHTTP2_PUSH_PROMISE) ? | ||
| frame->push_promise.promised_stream_id : | ||
| frame->hd.stream_id; | ||
| frame->push_promise.promised_stream_id : |
There was a problem hiding this comment.
These two lines are only indented two spaces vs. the four spaces for the ternary changes up above. I don't have a preference as to how many spaces it should be, but it should be consistent.
jasnell
force-pushed
the
http2-improvements
branch
from
cce73a8
to
3b93d7b
Compare
jasnell
force-pushed
the
http2-improvements
branch
from
3b93d7b
to
ea2ab2d
Compare
jasnell
added a commit
that referenced
this pull request
Sep 13, 2017
... and some other cleanups PR-URL: #15207 Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 9d9552f |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
... and some other cleanups PR-URL: nodejs/node#15207 Reviewed-By: Matteo Collina <[email protected]>
jasnell
added a commit
that referenced
this pull request
Sep 20, 2017
... and some other cleanups PR-URL: #15207 Reviewed-By: Matteo Collina <[email protected]>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
... and some other cleanups PR-URL: nodejs/node#15207 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom promisify for
http2.connect()and other miscellaneous improvements .Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2