Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

merged 2 commits into from
Oct 31, 2017

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 1, 2017

Commits

Semver-Major

  • [de4a749788] - (SEMVER-MAJOR) internal/util: use internal/errors.js (Sebastian Van Sande) #11301
  • [db2e093e05] - (SEMVER-MAJOR) assert: handle enumerable symbol keys (Ruben Bridgewater) #15169
  • [b0d3bec95c] - (SEMVER-MAJOR) assert: use Same-value equality in deepStrictEqual (Ruben Bridgewater) #15398
  • [e13d1df89b] - (SEMVER-MAJOR) assert: support custom errors (geek) #15304
  • [ea2e6363f2] - (SEMVER-MAJOR) assert: use SameValueZero in deepStrictEqual (Ruben Bridgewater) #15036
  • [c53db1e8e9] - (SEMVER-MAJOR) assert: show thrown message in doesNotThrow() (Ruslan Bekenev) #12167
  • [fc463639fa] - (SEMVER-MAJOR) assert: fix assert.fail with zero arguments (Ruben Bridgewater) #13974
  • [d731369b1d] - (SEMVER-MAJOR) async_hooks: remove deprecated APIs (Anna Henningsen) #14414
  • [97c43940c8] - (SEMVER-MAJOR) benchmark: cover more nextTick() code (Rich Trott) #14645
  • [e79a61cf80] - (SEMVER-MAJOR) buffer: buffer.transcode to use internal/errors (Weijia Wang) #16352
  • [9e0f771224] - (SEMVER-MAJOR) buffer: improve error messages (Weijia Wang) #14975
  • [70832bc353] - (SEMVER-MAJOR) build: add V8 embedder version string (Michaël Zasso) #15785
  • [c5eb5bfc2e] - (SEMVER-MAJOR) build: enable runtime linking (jBarz) #15286
  • [2062a69879] - (SEMVER-MAJOR) build: stop support building addons with VS 2013 (Michaël Zasso) #14764
  • [f2b01cba7b] - (SEMVER-MAJOR) child_process: defer error to next tick (Tristian Flanagan) #4670
  • [fe730d34ce] - (SEMVER-MAJOR) child_process: use internal/errors (Tobias Nießen) #14009
  • [448c4c62d2] - (SEMVER-MAJOR) child_process: do not extend result for *Sync() (Brian White) #13601
  • [1fcb76e8f2] - (SEMVER-MAJOR) cluster: remove deprecated property (James M Snell) #13702
  • [4da8b99a74] - (SEMVER-MAJOR) console: coerce label to string in console.time() (James M Snell) #14643
  • [ee76f3153b] - (SEMVER-MAJOR) crypto: migrate setFipsCrypto to internal/errors (James M Snell) #16428
  • [df8c6c3651] - (SEMVER-MAJOR) crypto: use CHECK instead in getSSLCiphers (James M Snell) #16453
  • [0a03e350fb] - (SEMVER-MAJOR) crypto: migrate crypto.randomBytes to internal/errors (James M Snell) #16454
  • [eeada6ca63] - (SEMVER-MAJOR) crypto: migrate timingSafeEqual to internal/errors (James M Snell) #16448
  • [a78327f48b] - (SEMVER-MAJOR) crypto: migrate setEngine to internal/errors (James M Snell) #16429
  • [b8bc652869] - (SEMVER-MAJOR) crypto: migrate crypto sign to internal/errors (James M Snell) #15757
  • [7124b466d9] - (SEMVER-MAJOR) crypto: refactor argument validation for pbkdf2 (James M Snell) #15746
  • [3ddc88b5c2] - (SEMVER-MAJOR) crypto: migrate Certificate to internal/errors (James M Snell) #15756
  • [c75f87cc4c] - (SEMVER-MAJOR) crypto: refactor the crypto module (James M Snell) #15231
  • [484bfa2e37] - (SEMVER-MAJOR) crypto: accept decimal Number in randomBytes (Benjamin Gruenbaum) #15130
  • [c39caa997c] - (SEMVER-MAJOR) deps: backport 0f1dfae from V8 upstream (Tobias Tebbi) #15362
  • [2780f01392] - (SEMVER-MAJOR) deps: backport b096c44 from upstream V8 (Michaël Zasso) #15785
  • [3d1b3df948] - (SEMVER-MAJOR) deps: update V8 to 6.2.414.32 (Michaël Zasso) #15362
  • [acb9b8f73c] - (SEMVER-MAJOR) deps: backport b096c44 from upstream V8 (Michaël Zasso) #15785
  • [d82e1075db] - (SEMVER-MAJOR) deps: update V8 to 6.1.534.36 (Michaël Zasso) #14730
  • [0a66b223e1] - (SEMVER-MAJOR) deps: update V8 to 6.0.286.52 (Myles Borins) #14004
  • [2db2857c72] - (SEMVER-MAJOR) deps: cherry-pick 6d38f89 from upstream V8 (Michaël Zasso) #13263
  • [bc8e4878c0] - (SEMVER-MAJOR) deps: add missing include to V8 i18n.cc (Michaël Zasso) #13263
  • [9b4a891ca2] - (SEMVER-MAJOR) deps: run memory hungry V8 test in exclusive mode (Michaël Zasso) #13263
  • [3dc8c3bed4] - (SEMVER-MAJOR) deps: update V8 to 5.9.211.32 (Michaël Zasso) #13263
  • [1a452f1928] - (SEMVER-MAJOR) dgram,process,util: refactor Error to TypeError (Ruben Bridgewater) #13857
  • [758a17f1d5] - (SEMVER-MAJOR) dns: return TypeError on invalid resolve() input (Rich Trott) #13090
  • [1789dcfc87] - (SEMVER-MAJOR) doc: add missing changelogs to assert docs (Ruben Bridgewater) #15036
  • [8ca9338655] - (SEMVER-MAJOR) doc: document missing error types (Ruben Bridgewater) #13857
  • [3fab9f2cd7] - (SEMVER-MAJOR) doc: EOL deprecated API and update notes (James M Snell) #13702
  • [602fd36d95] - (SEMVER-MAJOR) domain: remove .dispose() (Anna Henningsen) #15412
  • [219932a9f7] - (SEMVER-MAJOR) errors: convert 'fs' (matzavinos) #15043
  • [11a2ca29ba] - (SEMVER-MAJOR) errors: migrate _http_outgoing (Weijia Wang) #14735
  • [9cb390d899] - (SEMVER-MAJOR) errors: migrate dns to use internal/errors (Weijia Wang) #14212
  • [a03d8cee1f] - (SEMVER-MAJOR) errors: migrate socket_list to internal/errors (Bougarfaoui El houcine) #11356
  • [f67aa566a6] - (SEMVER-MAJOR) errors: migrate tls_wrap to use internal/errors (Bidisha Pyne) #13476
  • [b61cab2234] - (SEMVER-MAJOR) errors: port internal/fs errors to internal/errors (Gunar C. Gessner) #11317
  • [1698c8e165] - (SEMVER-MAJOR) errors: fix and improve error types (Ruben Bridgewater) #13857
  • [3e178848a5] - (SEMVER-MAJOR) errors: improve ERR_INVALID_ARG_TYPE (Ruben Bridgewater) #13730
  • [0ecdf29340] - (SEMVER-MAJOR) errors: migrate lib/console (mskec) #11340
  • [7f3f72c19b] - (SEMVER-MAJOR) errors, readline: migrate to use internal/errors.js (Scott McKenzie) #11390
  • [aff8d358fa] - (SEMVER-MAJOR) errors, repl: migrate to use internal/errors.js (Dan Homola) #11347
  • [dbfe8c4ea2] - (SEMVER-MAJOR) errors,buffer: port errors to internal/errors (starkwang) #13976
  • [a9f798ebcc] - (SEMVER-MAJOR) errors,http_server: migrate to use internal/errors.js (Bidisha Pyne) #13301
  • [a0f7284346] - (SEMVER-MAJOR) errors,process: fix error message of hrtime() (Tobias Nießen) #13739
  • [062071a9c3] - (SEMVER-MAJOR) errors,process: migrate to use internal/errors.js (sreepurnajasti) #13285
  • [28227963fa] - (SEMVER-MAJOR) errors,repl: migrate to use internal/errors.js (sreepurnajasti) #13299
  • [d50a802feb] - (SEMVER-MAJOR) errors,stream-transform: migrate to use internal/errors.js (sreepurnajasti) #13310
  • [d2913384aa] - (SEMVER-MAJOR) errors,stream_wrap: use internal/errors.js (LAKSHMI SWETHA GOPIREDDY) #13291
  • [473f0eff29] - (SEMVER-MAJOR) errors,url: port url errors to internal/errors (starkwang) #13963
  • [1609899142] - (SEMVER-MAJOR) errors,util: migrate to use internal/errors.js (Bidisha Pyne) #13293
  • [e5ad5456a2] - (SEMVER-MAJOR) events: migrate to internal/errors (James M Snell) #15623
  • [e5c290bed9] - (SEMVER-MAJOR) fs: refactor close to use destroy (Matteo Collina) #15407
  • [2249234fee] - (SEMVER-MAJOR) fs: invoke callbacks with undefined context (Rich Trott) #14645
  • [f2f391e575] - (SEMVER-MAJOR) http: send 400 bad request on parse error (mog422) #15324
  • [10be20a0e8] - (SEMVER-MAJOR) http: set socket timeout when socket connects (Luigi Pinca) #8895
  • [620ba41694] - (SEMVER-MAJOR) http: don't double-fire the req error event (fengmk2) #14659
  • [156549d8ff] - (SEMVER-MAJOR) http: disable OutgoingMessage pipe method (Roee Kasher) #14358
  • [2fa2a60721] - (SEMVER-MAJOR) http: simplify if statement (Ruben Bridgewater) #13857
  • [80c9ef0b6b] - (SEMVER-MAJOR) http: edit _storeHeader to check for Trailer header (Artur G Vieira) #12990
  • [f55ee6e24a] - (SEMVER-MAJOR) http2: make --expose-http2 flag a non-op (James M Snell) #15535
  • [bdfbce9241] - (SEMVER-MAJOR) http_client, errors: migrate to internal/errors (Weijia Wang) #14423
  • [4843c2f415] - (SEMVER-MAJOR) https: convert to using internal/errors (Rami Moshe) #15603
  • [4cf56ad6f2] - (SEMVER-MAJOR) inspector: migrate to internal/errors (James M Snell) #15619
  • [668ad44922] - (SEMVER-MAJOR) intl: unexpose Intl.v8BreakIterator (Ben Noordhuis) #15238
  • [c885ea727d] - (SEMVER-MAJOR) lib: deprecate fd usage for fs.truncate(Sync) (r1cebank) #15990
  • [095357e26e] - (SEMVER-MAJOR) lib: tweak use of internal/errors (Ruben Bridgewater) #13829
  • [8520e6f280] - (SEMVER-MAJOR) lib: fix urlObject parameter name in url.format (Eduardo Leggiero) #14031
  • [9836cf5717] - (SEMVER-MAJOR) lib: lazy instantiation of fs.Stats dates (Daniel Pihlstrom) #12818
  • [234353a1b8] - (SEMVER-MAJOR) lib,src: refactor buffer out of range index (larissayvette) #11296
  • [9d7574eef5] - (SEMVER-MAJOR) module: deprecate Module._debug (Jackson Tian) #13948
  • [a517466aa7] - (SEMVER-MAJOR) module: mark DEP0019 as EOL and remove compat code (Roman Reiss) #3384
  • [7f55349079] - (SEMVER-MAJOR) net: convert to using internal/errors (matzavinos) #14782
  • [b24e269a48] - (SEMVER-MAJOR) net: multiple listen() events fail silently (Eduard Bondarenko) #13149
  • [75a19fb379] - (SEMVER-MAJOR) net,child_process: improve naming in internal code (Anna Henningsen) #14449
  • [f6caeb9526] - (SEMVER-MAJOR) os: make EOL configurable and read only (XadillaX) #14622
  • [1f8d527e94] - (SEMVER-MAJOR) path: deprecate internal _makeLong, replace (James M Snell) #14956
  • [dcfbbacba8] - (SEMVER-MAJOR) path: use internal/errors.js (Sebastian Van Sande) #11319
  • [a253704446] - (SEMVER-MAJOR) process: make this value consistent (Rich Trott) #14645
  • [43e105f645] - (SEMVER-MAJOR) process: improve hrtime() error message (Rich Trott) #14324
  • [3129b2c035] - (SEMVER-MAJOR) process: use internal/errors in internalNextTick (Tobias Nießen) #13982
  • [9788e96836] - (SEMVER-MAJOR) querystring: convert to using internal/errors (Rami Moshe) #15565
  • [7a29f44071] - (SEMVER-MAJOR) repl: deprecate REPLServer.prototype.memory (Lance Ball) #16242
  • [e416b3ee36] - (SEMVER-MAJOR) repl: deprecate turnOffEditorMode (Lance Ball) #15136
  • [ed1ba4580b] - (SEMVER-MAJOR) repl: remove REPLServer.createContext side effects (Lance Ball) #14331
  • [2ca9f94e33] - (SEMVER-MAJOR) repl: make REPLServer.bufferedCommand private (Lance Ball) #13687
  • [3d9e7bb1d4] - (SEMVER-MAJOR) repl: remove unused function convertToContext (Nikolai Vavilov) #13434
  • [33b2b10b68] - (SEMVER-MAJOR) src: fix rename of entry frame in v8abbr.h (geek) #15362
  • [8f9e738a69] - (SEMVER-MAJOR) src: update ustack offset identifiers (geek) #15362
  • [205a4d2331] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 59 (Michaël Zasso) #15362
  • [ddc16e505b] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 58 (Michaël Zasso) #14730
  • [5f22375922] - (SEMVER-MAJOR) src: add support to pass flags to dlopen (Ezequiel Garcia) #12794
  • [784c6d40f8] - (SEMVER-MAJOR) src: use proper errors as coming from StringBytes (Anna Henningsen) #14579
  • [80ebb4282d] - (SEMVER-MAJOR) src: adjust windows abort behavior (Jared Kantrowitz) #13947
  • [db476fc8b5] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 57 (Myles Borins) #14004
  • [24709b2e4a] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 56 (Michaël Zasso) #13263
  • [6e86a6651c] - (SEMVER-MAJOR) stream: complete migration to internal/errors (Matteo Collina) #16589
  • [88fb359c57] - (SEMVER-MAJOR) stream: migrate _stream_readable use error codes (Ben Halverson) #15042
  • [db7d1339c3] - (SEMVER-MAJOR) stream: migrate to internal/errors (Ruben Bridgewater) #15665
  • [4536128e7c] - (SEMVER-MAJOR) stream: remove dead code (Ruben Bridgewater) #15665
  • [eb4940e2d2] - (SEMVER-MAJOR) string_decoder: Migrate to use internal/errors (Weijia Wang) #14682
  • [a7487c92e2] - (SEMVER-MAJOR) test: fix message test after V8 upgrade (Michaël Zasso) #15362
  • [fca7e49e44] - (SEMVER-MAJOR) test: adjust windows failed alloc test to V8 6.2 (Bartosz Sosnowski) #14730
  • [95c8df18f1] - (SEMVER-MAJOR) test: add test to verify ErrnoException path (Daniel Bevenius) #13958
  • [0d3ef5b0f8] - (SEMVER-MAJOR) test: check this value for nextTick() (Rich Trott) #14645
  • [c6126b1308] - (SEMVER-MAJOR) test: refactor test-fs-stat (Rich Trott) #14645
  • [eaaec57332] - (SEMVER-MAJOR) test: use worker.exitedAfterDisconnect consistently (James M Snell) #13702
  • [839faae45a] - (SEMVER-MAJOR) timers: cleanup extraneous property on Immediates (Jeremiah Senkpiel) #16355
  • [ce3586da31] - (SEMVER-MAJOR) timers: warn on overflowed timeout duration (Jeremiah Senkpiel) #15627
  • [11f7dcf91e] - (SEMVER-MAJOR) timers: do not expose .unref()._handle._list (Jeremiah Senkpiel) #8422
  • [4d893e093a] - (SEMVER-MAJOR) timers: Migrate to use internal/errors (Weijia Wang) #14659
  • [468110b327] - (SEMVER-MAJOR) tls: deprecate parseCertString & move to internal (XadillaX) #14249
  • [0f7c06eb2d] - (SEMVER-MAJOR) tls: fix object prototype type confusion (Ben Noordhuis) #14447
  • [a7dccd040d] - (SEMVER-MAJOR) tls: type checking for key, cert and ca options (Jimmy Cann) #14807
  • [3ccfeb483d] - (SEMVER-MAJOR) tls: migrate tls.js to use internal/errors.js (Michael Dawson) #13994
  • [c88ba036b4] - (SEMVER-MAJOR) url: ensure search property is consistently null vs empty (Justin Beckwith) #13606
  • [b1c8f15c5f] - (SEMVER-MAJOR) util: use constructor name (Ruben Bridgewater) #14886
  • [3b0e800f18] - (SEMVER-MAJOR) util: make util.debuglog() consistent with doc (Vse Mozhet Byt) #13841
  • [58831b2f24] - (SEMVER-MAJOR) uv: improvements to process.binding('uv') (James M Snell) #14933
  • [ef238fb485] - (SEMVER-MAJOR) v8: migrate setFlagsFromString to internal/errors (James M Snell) #16535
  • [b3e5c4621d] - (SEMVER-MAJOR) v8: add new to the throw statement (Ruben Bridgewater) #13857
  • [88e55fe5e0] - (SEMVER-MAJOR) vm: deprecate vm.runInDebugContext (Josh Gavant) #12815
  • [896eaf6820] - (SEMVER-MAJOR) zlib: finish migrating to internal/errors (James M Snell) #16540
  • [74891412f1] - (SEMVER-MAJOR) zlib: migrate to internal/errors (James M Snell) #15618

Semver-minor

  • [3e25e4d00f] - (SEMVER-MINOR) http: support generic Duplex streams (Anna Henningsen) #16267
  • [9c6f6b0633] - (SEMVER-MINOR) module: support custom paths to require.resolve() (cjihrig) #16397
  • [7f9eb4c29c] - (SEMVER-MINOR) util: graduate TextEncoder/TextDecoder, tests (James M Snell) #15743
  • [af3aa682ac] - (SEMVER-MINOR) util: add callbackify (Refael Ackermann) #12712
  • [36732084db] - (SEMVER-MINOR) util,assert: expose util.isDeepStrictEqual() (Rich Trott) #16084

Semver-patch

@jasnell jasnell added the wip Issues and PRs that are still a work in progress. label Sep 1, 2017
@jasnell jasnell changed the title [WIP] 2017-10-31, Version 9.0.0 (Current) [WIP] Proposal: 2017-10-31, Version 9.0.0 (Current) Sep 1, 2017
@MylesBorins
Copy link
Contributor

we may want to drop e5dc934 from v9.x-staging until #14161 is sorted out

@nodejs nodejs deleted a comment Sep 10, 2017
@jasnell jasnell force-pushed the v9.0.0-proposal branch 2 times, most recently from 25f6731 to 6891ac2 Compare October 17, 2017 22:52
@jasnell
Copy link
Member Author

jasnell commented Oct 17, 2017

RC.0 Build Underway: https://ci-release.nodejs.org/job/iojs+release/2125/
(not everyone will be able to access that link)

@jasnell jasnell changed the title [WIP] Proposal: 2017-10-31, Version 9.0.0 (Current) Proposal: 2017-10-31, Version 9.0.0 (Current) Oct 17, 2017
@@ -41,25 +45,6 @@ release.
<a href="doc/changelogs/CHANGELOG_V8.md#8.1.0">8.1.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V8.md#8.0.0">8.0.0</a><br/>
</td>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.10.1">7.10.1</a></b><br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing 7?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the same reason 5 is not listed. The changelogs are still there and accessible

@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2017

@jasnell can you include the list of commits here as it currently stands.

@jasnell
Copy link
Member Author

jasnell commented Oct 24, 2017

Yes. Will be updating this later on today with a plan towards having a new RC. It'll likely be later this afternoon as I'm waiting on the security release to be finished before I start on it.

@jasnell jasnell changed the base branch from master to v9.x October 28, 2017 22:44
@jasnell
Copy link
Member Author

jasnell commented Oct 28, 2017

All @nodejs/collaborators @nodejs/TSC ... I will be updating from master one final time tomorrow before working on generating and testing the release binaries. The release will happen on Tuesday.

@nodejs/build ... Heads up :)

@mcollina
Copy link
Member

#16589 should get in before release to ease compatibility with future readable-stream releases.

@apapirovski
Copy link
Member

apapirovski commented Oct 29, 2017

I would like to get a bunch of the http2 fixes in if possible, since they're pretty major. #16575, #16525 and #16580

That said, it's not a must :) so depends on timing

@jasnell jasnell added this to the 9.0.0 milestone Oct 29, 2017
@jasnell
Copy link
Member Author

jasnell commented Oct 29, 2017

@nodejs/collaborators @nodejs/tsc ... definitely last call. I will be doing one final rebase from master this afternoon after noon pacific time (just over one hour from now). Unless it is an absolutely critical bug fix, if it doesn't land by noon, it won't make it in to 9.0.0

@jasnell jasnell force-pushed the v9.0.0-proposal branch 4 times, most recently from 3383a94 to fcee247 Compare October 30, 2017 07:13
@jasnell jasnell removed the wip Issues and PRs that are still a work in progress. label Oct 30, 2017
@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2017

@nodejs/collaborators @nodejs/tsc ... I've completed what should be the final update. I will build a final RC in the morning, do some testing, then will build the release binaries by end of day, with intent of promoting those first thing tuesday morning. Please take one final look.

@AndreasMadsen
Copy link
Member

AndreasMadsen commented Oct 30, 2017

Oh, sorry. I completely forgot to land #16318

As discussed in #15454 (comment) and in the TSC meeting this should be part of the v9.0 release.

edit: landed in 23a3911

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Oct 30, 2017

* [[`2249234fee`](https://github.com/nodejs/node/commit/2249234fee)] - **(SEMVER-MAJOR)** **fs**: invoke callbacks with undefined context (Rich Trott) [#14645](https://github.com/nodejs/node/pull/14645)
* [[`f2f391e575`](https://github.com/nodejs/node/commit/f2f391e575)] - **(SEMVER-MAJOR)** **http**: send 400 bad request on parse error (mog422) [#15324](https://github.com/nodejs/node/pull/15324)
* [[`10be20a0e8`](https://github.com/nodejs/node/commit/10be20a0e8)] - **(SEMVER-MAJOR)** **http**: set socket timeout when socket connects (Luigi Pinca) [#8895](https://github.com/nodejs/node/pull/8895)
* [[`620ba41694`](https://github.com/nodejs/node/commit/620ba41694)] - **(SEMVER-MAJOR)** **http**: don't double-fire the req error event (fengmk2) [#14659](https://github.com/nodejs/node/pull/14659)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR-URL should be #14333

@rvagg
Copy link
Member

rvagg commented Oct 30, 2017

@jasnell you wanted confirmation that #16130 didn't have anything that would prevent it from landing as semver-minor after 9.0.0 goes out (i.e. so there's no rush to bundle it here). This is that confirmation, and if I'm wrong, then we'll force it to be semver-minor!

@rvagg rvagg mentioned this pull request Oct 30, 2017
3 tasks
@MylesBorins
Copy link
Contributor

MylesBorins commented Oct 31, 2017

A handful of concerning fails on CITGM

Most alarming is a module resolution failure in david on all platforms

Other less worrying problems include:

1 failing
   1) socket.monitor should read multiple events on monitor interval:
      Uncaught AssertionError: expected 7 to be within 0..5
       at Assertion.fail (node_modules\should\cjs\should.js:265:17)
       at Assertion.value [as within] (node_modules\should\cjs\should.js:340:19)
       at exports.Socket.<anonymous> (test\socket.monitor.js:103:22)
       at Object.self._zmq.onMonitorEvent (lib\index.js:543:12)
       undefinedadded 190 packages in 23.23s
 > [email protected] test /Users/iojs/build/workspace/citgm-smoker/nodes/osx1010/citgm_tmp/2d905b84-8e9e-4015-ba29-ec9013f618ba/shot
 > lab -a code -t 100 -L
   
   ............................................
 44 tests complete
 Test duration: 431 ms
 Assertions count: 0 (verbosity: 0.00)
 The following leaks were detected:SharedArrayBuffer, Atomics
 Coverage: 100.00%
 Linting results: No issues
 npm ERR! Test failed.  See above for more details.

@richardlau
Copy link
Member

Should tools/remark-cli be added to LICENSE (i.e. as we do for tools/eslint)?

@MylesBorins
Copy link
Contributor

@jasnell please do not release without including

#16637 ~ add license for remark-cli
#16634 ~ revert broken changes to module resolution algorithm

@cjihrig
Copy link
Contributor

cjihrig commented Oct 31, 2017

The shot failures aren't real. SharedArrayBuffer and Atomics are globals that just haven't been whitelisted by lab yet (hapijs/lab#748).

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

Build is failing on Windows. Tracking it down now.

@addaleax
Copy link
Member

@jasnell I’d assume that’s #16639?

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017 via email

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

This is currently waiting on #16634 and the 8.9.0 release. 8.9.0 needs to go out first so that I can update the changelog since there is some overlap in the commits.

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

Once 8.9.0 is released, I will update the changelog in this then proceed with the release.

@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

@gibfahn ... please ping me here once 8.9.0 is out :-)

  * Older experimental APIs have been removed.
    [[`d731369b1d`](d731369b1d)]
    [#14414](#14414)

* **Errors**
  * Improvements have been made to `buffer` module error messages.
  * The assignment of static error codes to Node.js error continues:
    * `buffer`
    * `child_process`
    * `console`
    * `crypto`
    * `dns`
    * `events`
    * `fs`
    * `http`
    * `inspector`
    * `net`
    * `path`
    * `process`
    * `querystring`
    * `readline`
    * `repl`
    * `streams`
    * `string_decoder`
    * `timers`
    * `tls`
    * `url`
    * `util`
    * `v8`
    * `zlib`

* **Child Processes**
  * Errors are emitted on process nextTick.

* **Domains**
  * The long-deprecated `.dispose()` method has been removed.

* **fs**
  * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`.
  * `fs` module callbacks are now invoked with an undefined context.

* **HTTP/1**
  * A 400 Bad Request response will now be sent when parsing fails.
  * Socket timeout will be set when the socket connects.
  * A bug causing the request `'error'` event to fire twice was fixed.
  * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`.

* **Intl**
  * The deprecated `Intl.v8BreakIterator` has been removed.

* **Modules**
  * The `require.resolve()` method now supports using custom lookup paths.

* **OS**
  * The `os.EOL` property is now read-only.

* **Timers**
  * `setTimeout()` will emit a warning if the timeout is larger that the maximum
    32-bit unsigned integer.
@jasnell
Copy link
Member Author

jasnell commented Oct 31, 2017

@tniessen
Copy link
Member

@jasnell jasnell merged commit fbde292 into v9.x Oct 31, 2017
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 31, 2017
jasnell added a commit to nodejs/nodejs.org that referenced this pull request Oct 31, 2017
@rvagg rvagg deleted the v9.0.0-proposal branch October 31, 2017 22:53
@rvagg
Copy link
Member

rvagg commented Oct 31, 2017

@jasnell armv6l binaries are in staging, can you promote please?

@cjihrig cjihrig mentioned this pull request Nov 7, 2017
targos referenced this pull request Apr 6, 2018
  * Older experimental APIs have been removed.
    [[`d731369b1d`](d731369b1d)]
    [#14414](#14414)

* **Errors**
  * Improvements have been made to `buffer` module error messages.
  * The assignment of static error codes to Node.js error continues:
    * `buffer`
    * `child_process`
    * `console`
    * `crypto`
    * `dns`
    * `events`
    * `fs`
    * `http`
    * `inspector`
    * `net`
    * `path`
    * `process`
    * `querystring`
    * `readline`
    * `repl`
    * `streams`
    * `string_decoder`
    * `timers`
    * `tls`
    * `url`
    * `util`
    * `v8`
    * `zlib`

* **Child Processes**
  * Errors are emitted on process nextTick.

* **Domains**
  * The long-deprecated `.dispose()` method has been removed.

* **fs**
  * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`.
  * `fs` module callbacks are now invoked with an undefined context.

* **HTTP/1**
  * A 400 Bad Request response will now be sent when parsing fails.
  * Socket timeout will be set when the socket connects.
  * A bug causing the request `'error'` event to fire twice was fixed.
  * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`.

* **Intl**
  * The deprecated `Intl.v8BreakIterator` has been removed.

* **Modules**
  * The `require.resolve()` method now supports using custom lookup paths.

* **OS**
  * The `os.EOL` property is now read-only.

* **Timers**
  * `setTimeout()` will emit a warning if the timeout is larger that the maximum
    32-bit unsigned integer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.