_http_outgoing: migrate to use internal/errors #14735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
jasnell
added
the
semver-major
80 tasks
refack
approved these changes
Aug 12, 2017
| common.expectsError( | ||
| () => res.setHeader(), | ||
| { | ||
| code: 'ERR_INVALID_HTTP_TOKEN', |
There was a problem hiding this comment.
@starkwang how much work will it to add the given value (in addition to the token name)?
There was a problem hiding this comment.
I've added some more information about the given value in the error message.
starkwang
force-pushed
the
http-outgoing-internal-errors
branch
from
ae9c960
to
0fcece2
Compare
3 tasks
|
Landed in 11a2ca2 |
refack
pushed a commit
that referenced
this pull request
Aug 14, 2017
PR-URL: #14735 Refs: #11273 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http, errors