-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node_zlib.cc assertion failure #14161
Comments
Can you check whether this happens with Node 8.1.3/the 8.2.0 RC as well? If it only happens with the latter, that would point to #13322 |
@addaleax I can reproduce with 8.2.0 RC, but not with 8.1.3, so hopefully it did not make it into any release lines yet. |
It did not :) /cc @mscdex (edit: adding this to the 9.0.0 milestone so we don’t forget it’s broken in master) |
Can this be closed now? |
I don't think this has been resolved yet, even though I currently can't try whether it still occurs, but I suspect that #14178 is related. |
As this is still not fixed and blocking npm updates in master and v9.x I think we may want to examine reverting add4b0a |
This reverts commit add4b0a. Fixes: nodejs#14161
Closes: nodejs#16280 Fixes: nodejs#14161
Closes: #16280 PR-URL: #16509 Fixes: #14161 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closes: #16280 PR-URL: #16509 Fixes: #14161 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closes: nodejs/node#16280 PR-URL: nodejs/node#16509 Fixes: nodejs/node#14161 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Closes: nodejs/node#16280 PR-URL: nodejs/node#16509 Fixes: nodejs/node#14161 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #16657 Refs: #16649 Refs: #14161 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #16657 Refs: #16649 Refs: #14161 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closes: nodejs/node#16280 PR-URL: nodejs/node#16509 Fixes: nodejs/node#14161 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
I found this while working on #4603.
npm install -g http-server
fails like this:Even though I can reliably reproduce this, it might be a bit difficult to reproduce for others as my current setup is a bit complicated (custom node, npm and permission setup thanks to #4603). I currently don't have time to look into this myself; my best guess is that it is due to node being unable to write to a file thanks to insufficient permissions and
zlib
not handling stream / IO failures correctly.The text was updated successfully, but these errors were encountered: