Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 866ee63 from upstream V8 #13630

Closed
wants to merge 1 commit into from
Closed

deps: cherry-pick 866ee63 from upstream V8 #13630

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 12, 2017

Original commit message:

[string] Re-enable result caching for String.p.split

Runtime::kStringSplit's result caching is only enabled when limit equals
kMaxUInt32.

BUG=v8:6463

Review-Url: https://codereview.chromium.org/2923183002
Cr-Commit-Position: refs/heads/master@{#45724}

Fixes: #13445

@nodejs/v8

I did not update V8_PATCH_LEVEL because V8 5.9 is still supported.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@targos
deps: cherry-pick 866ee63 from upstream V8
13fca70 
Original commit message:

    [string] Re-enable result caching for String.p.split

    Runtime::kStringSplit's result caching is only enabled when limit equals
    kMaxUInt32.

    BUG=v8:6463

    Review-Url: https://codereview.chromium.org/2923183002
    Cr-Commit-Position: refs/heads/master@{nodejs#45724}

Fixes: nodejs#13445
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jun 12, 2017
@targos
Copy link
Member Author

targos commented Jun 19, 2017

Ping @nodejs/v8

bnoordhuis
bnoordhuis approved these changes Jun 19, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suppose, but is there a reason why this hasn't been back-ported upstream?

@targos
Copy link
Member Author

targos commented Jun 19, 2017

It has been backported to 6.0 only.

Quoting @bmeurer:

Since the fix is trivial, it might be worth considering to cherry-pick this into Node master (which is now at 5.9).

@bmeurer
Copy link
Member

bmeurer commented Jun 19, 2017

LGTM, cc @schuay

@targos
Copy link
Member Author

targos commented Jun 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8755/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/749/

@targos
Copy link
Member Author

targos commented Jun 20, 2017

Thank you. Landed in 7cdcca7

@targos targos closed this Jun 20, 2017
@targos targos deleted the backport-split-fix branch June 20, 2017 13:26
targos added a commit that referenced this pull request Jun 20, 2017
@targos
deps: cherry-pick 866ee63 from upstream V8
7cdcca7 
Original commit message:

    [string] Re-enable result caching for String.p.split

    Runtime::kStringSplit's result caching is only enabled when limit equals
    kMaxUInt32.

    BUG=v8:6463

    Review-Url: https://codereview.chromium.org/2923183002
    Cr-Commit-Position: refs/heads/master@{#45724}

PR-URL: #13630
Fixes: #13445
Reviewed-By: Ben Noordhuis <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @bmeurer @bnoordhuis @nodejs-github-bot