doc: fix indentation issue #16507

maclover7 · 2017-10-26T01:03:26Z

If releases are indented, then that will cause release-post.js to render an odd looking blog post. Fixes the v8.8.1 changelog, and adds note to doc/releases.md.

Who knew two spaces could cause such trouble :)

Related PR: nodejs/nodejs.org#1425

cc @cjihrig

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc

Should not be nested under the bullet point. Headings need to be at the root level.

To avoid further weirdness (this was an odd one to track down!)

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

tniessen · 2017-10-28T19:21:46Z

Landed in 737239a .. 6a7210e

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: #16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Should not be nested under the bullet point. Headings need to be at the root level. PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

PR-URL: nodejs/node#16507 Refs: nodejs/nodejs.org#1425 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

maclover7 added 2 commits October 25, 2017 20:55

doc: fix CHANGELOG_V8 indentation

79e1504

Should not be nested under the bullet point. Headings need to be at the root level.

doc: add note to releases.md

ea5dbf6

To avoid further weirdness (this was an odd one to track down!)

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 26, 2017

cjihrig approved these changes Oct 26, 2017

View reviewed changes

maclover7 mentioned this pull request Oct 26, 2017

blog: fix indentation nodejs/nodejs.org#1425

Merged

apapirovski approved these changes Oct 26, 2017

View reviewed changes

gireeshpunathil approved these changes Oct 26, 2017

View reviewed changes

lpinca approved these changes Oct 26, 2017

View reviewed changes

hiroppy approved these changes Oct 26, 2017

View reviewed changes

jasnell approved these changes Oct 26, 2017

View reviewed changes

tniessen closed this Oct 28, 2017

maclover7 deleted the jm-fix-v881 branch October 28, 2017 19:25

jasnell mentioned this pull request Oct 30, 2017

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

Merged

gibfahn mentioned this pull request Oct 31, 2017

v8.9.0 proposal #16630

Merged

MylesBorins added the dont-land-on-v6.x label Nov 16, 2017

MylesBorins mentioned this pull request Nov 21, 2017

v6.12.1 proposal #17180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: fix indentation issue #16507

doc: fix indentation issue #16507

maclover7 commented Oct 26, 2017 •

edited

Loading

tniessen commented Oct 28, 2017

doc: fix indentation issue #16507

doc: fix indentation issue #16507

Conversation

maclover7 commented Oct 26, 2017 • edited Loading

Checklist

Affected core subsystem(s)

tniessen commented Oct 28, 2017

maclover7 commented Oct 26, 2017 •

edited

Loading