Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix ordering error in errors.md #13274

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 29, 2017

/cc @TimothyGu

Checklist
Affected core subsystem(s)

doc errors

@Trott Trott added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 29, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels May 29, 2017
@Trott
Copy link
Member Author

Trott commented May 31, 2017

Landed in 102e1aa

@Trott Trott closed this May 31, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 31, 2017
PR-URL: nodejs#13274
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 5, 2017

If any part of this needs to be backported to v8.x, then a separate backport PR should be opened.

@Trott
Copy link
Member Author

Trott commented Jun 5, 2017

@jasnell This should land cleanly on 8.x as long as it lands after 234353a. If that commit is not landing on 8.x, then this one is not needed on 8.x either. If it is landing on 8.x, this one is needed.

@jasnell
Copy link
Member

jasnell commented Jun 5, 2017

234353a was a semver-major that I do not believe landed in time to make the 8.x cut so I think we're good.

@Trott Trott deleted the error-in-errors branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants