Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Route /rest/workflows/new correctly (no-changelog) #6572

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Jun 29, 2023

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (e63b398) 28.82% compared to head (2d50eee) 28.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6572      +/-   ##
==========================================
- Coverage   28.82%   28.76%   -0.07%     
==========================================
  Files        3042     3042              
  Lines      187564   187565       +1     
  Branches    20759    20758       -1     
==========================================
- Hits        54071    53956     -115     
- Misses     132654   132768     +114     
- Partials      839      841       +2     
Impacted Files Coverage Δ
...kages/cli/src/workflows/workflows.controller.ee.ts 82.90% <100.00%> (+0.14%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 29, 2023
@cypress
Copy link

cypress bot commented Jun 30, 2023

1 flaky tests on run #1360 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 PAY-590-fix-get-workflows-new-endpoint 🖥️ browsers:node18.12.0-chrome107 🤖 ...
Project: n8n Commit: 2d50eee5f6
Status: Passed Duration: 07:46 💡
Started: Jun 30, 2023 6:24 AM Ended: Jun 30, 2023 6:31 AM
Flakiness  cypress/e2e/15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Schedule Trigger node > should execute once per second when activated Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 3b9e65e into master Jun 30, 2023
@netroy netroy deleted the PAY-590-fix-get-workflows-new-endpoint branch June 30, 2023 06:51
MiloradFilipovic added a commit that referenced this pull request Jul 5, 2023
* master:
  fix(core): Remove typeorm patches, but still enforce transactions on every migration (#6594)
  feat(Strava Node): Add hide_from_home field in Activity Update (#5883)
  feat(Notion Node): Add option to update icon when updating a page (#5670)
  refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) (#6464)
  fix(core): Fix migrations for MySQL/MariaDB (#6591)
  fix(editor): Show retry information in execution list only when it exists (#6587)
  fix(Strapi Node): Fix issue with pagination (#4991)
  refactor(Item Lists Node): Refactoring (#6575)
  feat: Add crowd.dev node and trigger node (#6082)
  ci: Add Github Action to enforce template to issues (#5295)
  fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572)
  fix(Brevo Node): Rename SendInBlue node to Brevo node (#6521)
  fix(XML Node): Fix issue with not returning valid data (#6565)
  feat(HTTP Request Node): New http request generic custom auth credential (#5798)
  fix(core): Fix credentials test (#6569)
  fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563)
  docs: Add irreversible change warning for [email protected] (no-changelog) (#6558)
  feat: Add various source control improvements (#6533)
  feat(Twitter Node): Node overhaul (#4788)
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request Jul 6, 2023
* master: (50 commits)
  fix(Google Drive Node): Fix regex in file RLC (#6607)
  feat(HTML Node): 'Convert to table operation (#6540)
  ci: e2e tests don't need to enable saving manual executions
  🚀 Release 1.0.1 (#6606)
  fix(core): Make node execution order configurable, and backward-compatible (#6507)
  🚀 Release 0.236.0 (#6602)
  fix: Fix migrations for postgres and mysql (no-changelog) (#6600)
  fix(core): Improve the performance of last 2 sqlite migrations (#6522)
  refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529)
  fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598)
  ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog)
  fix(editor): Restore expression completions (#6566)
  refactor: Remove basic auth env vars from docker compose stacks (#6570)
  fix(core): Fix migrations for MySQL/MariaDB (#6591)
  fix(editor): Show retry information in execution list only when it exists (#6587)
  fix(Strapi Node): Fix issue with pagination (#4991)
  fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572)
  fix(XML Node): Fix issue with not returning valid data (#6565)
  fix(core): Fix credentials test (#6569)
  fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563)
  ...

# Conflicts:
#	packages/design-system/src/components/N8nCallout/Callout.vue
#	packages/editor-ui/src/App.vue
#	packages/editor-ui/src/plugins/i18n/locales/en.json
#	packages/editor-ui/src/stores/ui.store.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants